- Nov 17, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
This fixes dEQP-VK.graphicsfuzz.cov-condition-bitfield-extract-integer. For example, nir_ibitfield_extract(3, 1, 2) should return 1. Cc: 21.3 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!13791> (cherry picked from commit 011ea325)
-
It's needed for malloc() which is used by STACK_ARRAY Fixes: f695171e ("vulkan: add common entrypoints for sparse image requirements/properties") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13427> (cherry picked from commit 95dee515)
-
Fixes: 569afd37 ("intel/genxml: Copy gen12.xml to gen125.xml") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!13809> (cherry picked from commit 29025f66)
-
We had accidentally passed <x, y, z, l> instead of <l, x, y, z>. Fixes: b8ef3271 ("iris: Move suballocated resources to a dedicated allocation on export") Reviewed-by: Nanley Chery <nanley.g.chery@intel.com> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!13815> (cherry picked from commit f4004fde)
-
Oops. Forgot to account for the size here. Fixes: ca2d96db ("radv: Add caching for RT pipelines.") Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!13789> (cherry picked from commit 9494c566)
-
there's no way to know what an image will be used for, so this bit needs to always be added fixes KHR-GL46.packed_pixels.varied_rectangle.compressed_rgb cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13798> (cherry picked from commit 43c457a6)
-
No matter the format, this should return true if the instruction has an exec operand. Otherwise, eliminate_useless_exec_writes_in_block() could remove an exec write in a block if it's successor begins with: s2: %3737:s[8-9] = p_parallelcopy %0:exec s2: %0:exec, s1: %3738:scc = s_wqm_b64 %3737:s[8-9] Totals from 3 (0.00% of 150170) affected shaders (GFX10.3): CodeSize: 23184 -> 23204 (+0.09%) Instrs: 4143 -> 4148 (+0.12%) Latency: 98379 -> 98382 (+0.00%) Copies: 172 -> 175 (+1.74%) Branches: 95 -> 97 (+2.11%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Fixes: bc130497 ("aco: Eliminate useless exec writes in jump threading.") Closes: mesa/mesa#5620 Part-of: <mesa/mesa!13776> (cherry picked from commit d8946120)
-
If the same cmdbuf is submitted more than once, they were waiting on the same fence value. Fix this by clearing the value when beginning a new command buffer. This might fix spurious GPU hangs, especially on GFX9. Closes: mesa/mesa#5401 Cc: 21.3 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13777> (cherry picked from commit e94a899c)
-
Fixes: 3be42f9c ("mesa: rewrite glPushAttrib/glPopAttrib to get rid of malloc") Closes: mesa/mesa#5621 Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <mesa/mesa!13773> (cherry picked from commit 9d9de15a)
-
VK CTS just added some new tests to write to a compressed image from a compute shader, which was overrunning memory. The image width/height need to be sized according to the block sizes to avoid overwriting memory. dEQP-VK.image.sample_texture.*bit_compressed* Cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!13618> (cherry picked from commit 27903abb)
-
This fixes some crashes in VK-GL-CTS where it doesn't deal with these. Cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!13617> (cherry picked from commit 53a8faaf)
-
p_is_helper doesn't have any operands, so ACO's value numbering and/or the pre-RA optimizer could incorrectly recognize two such instructions as the same. This patch adds exec as an operand to p_is_helper in order to achieve correct behavior. Cc: mesa-stable Closes: mesa/mesa#5570 Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!13577> (cherry picked from commit d80c7f34)
-
Future LLVM header leads to __declspec(__restrict), which is invalid. Just undefine the restrict macro to keep __declspec(restrict). Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13505> (cherry picked from commit e0de7aa4)
-
Pattern match the point coord sysval and support lowering it as well. This is required to handle flipped framebuffers on Bifrost. However, what this pass normalizes to is the opposite of the hardware mode we used on Bifrost before, so we need to swap modes at the same time to prevent regressions. Fixes Piglit glsl-fs-pointcoord and glsl-fs-pointcoord_gles2 Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Cc: mesa-stable Part-of: <mesa/mesa!13073> (cherry picked from commit e257344a)
-
We need to guarantee that when vkQueueSubmit() returns the application can actually wait on a signaled semaphore/syncobj. When using a thread to do the submission to i915, this gets a bit tricky in the following case : A syncobj is used both as a wait & signal semaphore and has been signaled once already. It contains a fence before entering vkQueueSubmit(). This means we need to reset the syncobj to ensure when we return from vkQueueSubmit(), the syncobj contains no stale fence. Currently in the Anv, the submission thread is in charge of putting the new fence in the syncobj and also picks up the wait fence directly from the syncobj. This means we can't reset the syncobj from vkQueueSubmit(). The solution to this has been pointed by Bas & Jason : In vkQueueSubmit(), clone the wait syncobj fence into a new temporary syncobj that will be destroy after submission and use this temporary syncobj as a wait fence for i915. This allows us to reset the original syncobj in vkQueueSubmit(). For this to work with wait_before_signal behavior, we also need to do a wait-on-materialize on binary semaphores from vkQueueSubmit(). Otherwise the application thread calling vkQueueSubmit() could race the submission thread and pick up the wrong fence when cloing. v2: Use copy semantic for clone_syncobj_dma_fence() (Jason) Do the cloning prior to adding the syncobj to anv_queue_submit so that if the cloning fails don't have an invalid syncobj in anv_queue_submit (Jason) v3: Fix another syncobj leak (Jason) v4: Fix invalid argument order (Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Closes: mesa/mesa#4945 Part-of: <mesa/mesa!11474> (cherry picked from commit d2ff2b9e)
-
The previous doubles check (mesa/mesa#3459 ) checked that you didn't have full doubles emulation turned on, but we also need to check that you have doubles at all (emulated or not) or non-GL4 drivers will fail. Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Cc: mesa-stable Part-of: <mesa/mesa!13743> (cherry picked from commit a68a0c9e)
-
In order to implement GL_PRIMITIVES_GENERATED, v3d allocates a small resource and adds a command to the job to store the prim counts to it. However it was only doing this when TF was enabled which meant that if the query was used with a geometry shader but no TF then the query would always be zero. This patch makes the driver keep track of how many PRIMITIVES_GENERATED queries are in flight and then enable writing the prim count if its more than zero. Fix dEQP-GLES31.functional.geometry_shading.query.primitives_generated_* v2: Update CI expectations and references to fixed tests in commit log. v3: - Add comment that GL_PRIMITIVES_GENERATED query is included because OES_geometry_shader, but it is not part of OpenGL ES 3.1. (Iago) - Update Fixes to commit introducing geometry shaders. (Iago) Fixes: a1b7c084 ("v3d: fix primitive queries for geometry shaders") Signed-off-by: Neil Roberts <nroberts@igalia.com> Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!13712> (cherry picked from commit bdaf1858)
-
Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable qdws going out of scope leaks the storage it points to. Fixes: 9a7d6a11 ("virgl/drm: explicit context initialization") Suggested-by: Gert Wollny <gert.wollny@collabora.com> Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!13609> (cherry picked from commit 4a38ed82)
-
Set ra_class::regset and ra_class::index when deserializing. Fixes: 95d41a35 ("ra: Use struct ra_class in the public API.") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!13728> (cherry picked from commit 6eb86efe)
-
Eric Engestrom authored
-
- Nov 10, 2021
-
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
-
We reference the scratch BO using a bindless index in the command streamer instructions, but we forgot to add them to the BO list. v2: Make use of pipeline reloc list (Jason) v3: Don't add NULL BOs to the reloc list (Lionel) v4: Don't add BOs twice to reloc list when dealing with addresses (Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: eeeea5cb ("anv: Add support for scratch on XeHP") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!13544> (cherry picked from commit 46c37c86)
-
S_008D20_FINISH_DONE is a mask of queues and 1 means "wait on the gfx queue until the value is not 0" which can never happen when the driver captures from compute. Instead, use the full mask of possible queues. Cc: 21.3 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13694> (cherry picked from commit 379fab74)
-
this is used for pipeline comparisons, so it has to always be accurate cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13727> (cherry picked from commit 4dfb5818)
-
this was a little spaghetti-ish: the module hash was sometimes being applied during module update, sometimes in draw during program create, and then also it was removed when a shader unbind would cause the program to no longer be reachable now things are more consistent: * keep removing module hash when program becomes unreachable * only apply module hash in draw during updates there cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13727> (cherry picked from commit bfa81c1e)
-
Closes: mesa/mesa#4616 Fixes: e3101c96 ("anv/image: Disable multi-layer CCS_E on TGL+") Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!13680> (cherry picked from commit e6147895)
-
Looks like the __attribute__ version doesn't work for C++ in the Android build. Only found now because we don't enable -Wimplicit-fallthrough by default project wide for C++. Only ACO enables it. Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!13164> (cherry picked from commit aad80e47)
-
Fixes a crash in some desktop GL testcases in piglit. Cc: mesa-stable Part-of: <mesa/mesa!13635> (cherry picked from commit 7b578c12)
-
-static-libstdc++ doesn't exist on the Android NDK, casuing all later has_argument calls to return false even though the compiler supports that argument. Fixes: 3aee4627 "meson: add windows compiler checks and libraries" Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <!13164> (cherry picked from commit 22673a98)
-
The Vulkan spec got clarified recently and it's invalid (hw can support it though). Fixes new CTS dEQP-VK.api.buffer.invalid_buffer_features.*. Cc: 21.3 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13701> (cherry picked from commit ca7c748f)
-
zero is for success, nonzero is failure. Fixes: 0b60d6a2 ("d3d12: Support Linux eventfds for fences") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12268> (cherry picked from commit accd8326)
-
When the client calls vkMapMemory(), we have to align the requested offset down to the nearest page or else the map will fail. On platforms where we have DRM_IOCTL_I915_GEM_MMAP_OFFSET, we always map the whole buffer. In either case, the original map may start before the requested offset and we need to take that into account when we clflush. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!13610> (cherry picked from commit 90ac06e5)
-
We have to mark the root as non-spillable in case the interval is the child of some other interval, but we can't know whether it's the child of some other interval until it's been inserted. Move the setting of cant_spill below the insertion. This prevents us from using a bogus parent value. Fixes: 613eaac7 ("ir3: Initial support for spilling non-shared registers") Part-of: <mesa/mesa!13650> (cherry picked from commit db566904)
-
Eric Engestrom authored
This is already done on lines 475-480, resulting in them appearing twice in the summary. Fixes: 47946855 ("meson: allow egl_native_platform to be specified") Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!13278> (cherry picked from commit 9ad375bd)
-
shader_stages_mask and others expect MESA_SHADER_* based values, not PIPE_SHADER_*... Without this the fragment shader wouldn't appear in the "Pipelines" pane of RGP. Fixes: c276bde3 ("radeonsi/sqtt: export shader code to RGP") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!13696> (cherry picked from commit 3de072aa)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: d399c3e8 ("intel/dev: Add device info for ADL-S") Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <!13476> (cherry picked from commit 3b1a5b8f)
-
Cc: 21.2 21.3 <mesa-stable@lists.freedesktop.org> Part-of: <mesa/mesa!13472> (cherry picked from commit 10ee261c)
-
Fixes: e8cad57a ("gallium/trace: add pipe_vertex_state support") Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <mesa/mesa!13582> (cherry picked from commit f5794010)
-