- Aug 18, 2022
-
-
Dylan Baker authored
-
- Aug 16, 2022
-
-
Dylan Baker authored
-
When removing old histories, check against gpu fence. Otherwise, pending_results could have dangling pointers to the removed histories. Closes: mesa/mesa#7055 Cc: mesa-stable Part-of: <mesa/mesa!18040> (cherry picked from commit b8a916fd)
-
When primitive is points, EndPrimitive can't be used to count primitive. Need to use vertex count instead. And it's also not needed to do vertex per primitive count and overwrite incomplete primitive work for points. Fixes: 2be99012 ("nir: Add ability to count emitted GS primitives.") Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!17805> (cherry picked from commit 84956286)
-
The validation layers complained: > Validation Error: [ VUID-VkPhysicalDeviceGroupProperties-sType-sType ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xc9edee8b | vkEnumeratePhysicalDeviceGroups: parameter pPhysicalDeviceGroupProperties[0].sType must be VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_GROUP_PROPERTIES The Vulkan spec states: sType must be VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_GROUP_PROPERTIES (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkPhysicalDeviceGroupProperties-sType-sType ) Signed-off-by: Eric Engestrom <eric@igalia.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Fixes: c196ffac ("vk-device-select: add device group support") Part-of: <mesa/mesa!18037> (cherry picked from commit 45884538)
-
TEX instrutions can't write xyz and w to separate registers so we need to create variables from them first, otherwise we can create two variables from ALU writing the same register xyz and w in other branch (this usually works when TEX is not present as the xyz and w can read/write from different registers). This fixes regalloc because the variables are later used as a graph nodes. The variable order should not matter but it slightly does (leading to approx 0.3% shader-db temps increase as compared to previous state), so just sort the variables list afterwards to be as close to the previous behavior as possible and prevent the regression. CC: mesa-stable Closes: mesa/mesa#6936 Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Filip Gawin <filip@gawin.net> Part-of: <mesa/mesa!17987> (cherry picked from commit 88fd397c)
-
For post-transformed vertices, w = 0 is similar to w = 1. Replace the value to fix rcp(w). It is common for apps to pass w = 0 for position_t. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit b5df2056)
-
Due to the driver live shader cache, it's possible two different d3d9 shaders get the same cso. As it's disallowed to destroy a shader cso being bound, nine checks for this scenario. However it was not taking into account the cso might be from a different shader. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit 93da6e9f)
-
Invalidating all state groups is not sufficient, as some states check for actual changes. The correct way is to invalidate the commit mask. Found with a wine test. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit 4c65ccab)
-
The previous code was incorrectly checking the previous value of alphatestenable. In addition, remove an optimization that cannot hit (as we filter out redundant state settings). cc: mesa-stable Fixes: 1272640d ("st/nine: Fix alpha to coverage states") Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit 4f953ad5)
-
Fixes a crash in a ffxi trace, which draws out of bounds. This was previously resulting in trying to fill a buffer resource not big enough. cc: mesa-stable Fixes: 380c2bf8 ("st/nine: Optimize dynamic systemmem buffers") Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit e5124e83)
-
Without this it may crash running wine tests. According to the test themselves, the correct behaviour is a bit more complicated, but that's a first step. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit b74febff)
-
Fixes: e342081c ("util/format: Assert that formats are valid") Closes #7020 Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <mesa/mesa!18024> (cherry picked from commit 075b72ea)
-
just like clover Closes: mesa/mesa#5666 Fixes: 1506ea2e ("Move a bunch of the CLC stuff from src/microsoft to common code") Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!17682> (cherry picked from commit b5b85514)
-
Dylan Baker authored
-
- Aug 12, 2022
-
-
In create_rt_shader, we were setting group_idx to the stage index before. Fixes the following tests: dEQP-VK.ray_query.builtin.instancecustomindex.miss.aabbs dEQP-VK.ray_query.builtin.objectrayorigin.miss.triangles Fixes: c39cccec ("radv/rt: use stage ID as handle for general and closestHit shaders") Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!17936> (cherry picked from commit 2d39227a)
-
It's already correctly cleaned in radv_device_init_meta(). This fixes a recent regression with dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail. Fixes: 1a95d43e ("radv: Simplify the meta init fail path") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <mesa/mesa!17952> (cherry picked from commit 37dfa4e3) Conflicts: src/amd/ci/radv-hawaii-aco-fails.txt src/amd/ci/radv-oland-aco-fails.txt Stable: - remove CI files that don't exist in 22.2
-
these are required framebuffer formats in certain versions of GL, so don't create a texture that can't later be bound to a framebuffer see also spec@!opengl 3.0@required-texture-attachment-formats cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!17687> (cherry picked from commit 28d033b3)
-
neither of these have a real alpha channel, so reuse the xrgb blend clamping here to ensure the "right" alpha value is used cc: mesa-stable fixes: spec@arb_texture_float@fbo-blending-formats Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!17687> (cherry picked from commit 4f28e282)
-
Currently the sb.MOCS is being reset to zero after struct init. Signed-off-by: sjfricke <spencerfricke@gmail.com> Fixes: c27fcb1d ("isl: Fill in MOCS for NULL depth, stencil, and HiZ buffers.") Reviewed-by: Nanley Chery <nanley.g.chery@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17985> (cherry picked from commit 861167f4)
-
Deleted buffers were not unbound in glthread. Fixes: 4fa24747 - glthread: call _mesa_glthread_BindBuffer unconditionally Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!17976> (cherry picked from commit 28e35167)
-
Tests: dEQP-GLES2.functional.lifetime.delete_bound.framebuffer dEQP-GLES2.functional.state_query.integers.framebuffer_binding_getinteger Fixes: e48f6768 - glthread: don't sync for more glGetIntegerv enums for glretrace Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!17976> (cherry picked from commit eb4036ea)
-
The nir shader memory is freed in nir_to_tgsi(), but the already freed shader info is referenced later when create compute state. To avoid referencing the freed memory, copy the shader info first before calling nir_to_tgsi. Fixes vmx crash running aztec on SVGA driver. Fixes: 580f1ac4 ("nir: Extract shader_info->cs.shared_size out of union") Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!17999> (cherry picked from commit 4393be82)
-
Dylan Baker authored
-
clc_compiler_test.cpp:1322:67: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list log(0.0f) / log(2), log(1.0f) / log(2), log(2.0f) / log(2), log(3.0f) / log(2) clc_compiler_test.cpp:2306:25: error: non-constant-expression cannot be narrowed from type 'std::vector<unsigned int>::size_type' (aka 'unsigned long long') to 'unsigned int' in initializer list CompileArgs args = { inout.size(), 1, 1 }; Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> (cherry picked from commit ecfda9a0) Part-of: <mesa/mesa!18030>
-
- Aug 11, 2022
-
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: mesa/mesa#7013 Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17945> (cherry picked from commit 56bb29cb)
-
Fixes: 3415bf02 ("egl: Add a basic Windows driver") Suggested-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Daniel Stone <daniels@collabora.com> Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Sidney Just <justsid@x-plane.com> Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!12964> (cherry picked from commit 17eda68d)
-
Fixes: 3415bf02 ("egl: Add a basic Windows driver") Suggested-by: Yonggang Luo <luoyonggang@gmail.com> Acked-by: Daniel Stone <daniels@collabora.com> Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Sidney Just <justsid@x-plane.com> Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com> Tested-by: Yonggang Luo <luoyonggang@gmail.com> Part-of: <mesa/mesa!12964> (cherry picked from commit efd2ae6c)
-
this is the "default" size that's expected cc: mesa-stable Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17874> (cherry picked from commit b7eda568)
-
this should match the image type cc: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!17874> (cherry picked from commit 632e1b66)
-
Dylan Baker authored
-
- Aug 10, 2022
-
-
(cherry picked from commit f0558c6f) Part-of: <mesa/mesa!17877>
-
meson can work out the dependencies. (cherry picked from commit 8977913a) Part-of: <mesa/mesa!17877>
-
(cherry picked from commit 381f234a) Part-of: <mesa/mesa!17877>
-
(cherry picked from commit 5f7538f2) Part-of: <mesa/mesa!17877>
-
(cherry picked from commit 46baf864) Part-of: <mesa/mesa!17877>
-
(cherry picked from commit e99703b5) Part-of: <mesa/mesa!17877>
-
(cherry picked from commit 8e61bee3) Part-of: <mesa/mesa!17877>
-
Also drop unused - tu_instance_extension_supported - tu_physical_device_api_version - tu_physical_device_extension_supported - tu_device_submit_deferred_locked - tu_get_perftest_option_name (cherry picked from commit 6666ec39) Part-of: <mesa/mesa!17877>
-
(cherry picked from commit 9d9bf785) Part-of: <mesa/mesa!17877>
-