- Mar 24, 2021
-
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
They seem to be passing, for some reason.
-
- Mar 23, 2021
-
-
Dylan Baker authored
This reverts commit 1dd817ff.
-
My previous patch merged as 2b1930a5 was incomplete Fixes the following building error: FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/vulkan.anv_intermediates/LINKED/vulkan.anv.so ... ld.lld: error: undefined symbol: property_get >>> referenced by os_misc.c:193 (external/mesa/src/util/os_misc.c:193) >>> os_misc.o:(os_get_option) in archive out/target/product/x86_64/obj/STATIC_LIBRARIES/libmesa_util_intermediates/libmesa_util.a Cc: 21.0 <mesa-stable@lists.freedesktop.org> Fixes: eeecc21d ("util: Add property_get() fallback for android") Fixes: 2b1930a5 ("android: radv: add libcutils shared dependency") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Acked-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!9744> (cherry picked from commit cb428760)
-
This target is used to determine whether MS scaling factors are to be uploaded. Fixes: 1288ac76 ("nv50: don't try to upload MSAA settings for BUFFER textures") Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!9740> (cherry picked from commit 38371ff6)
-
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Closes: mesa/mesa#3598 Cc: mesa-stable Part-of: <mesa/mesa!9429> (cherry picked from commit dad3cda6)
-
Viewports must be initialized with the appropriate swizzles (for hardware that supports this feature). Fixes: 90fcb3fe (st/mesa: add NV_viewport_swizzle support) Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!9732> (cherry picked from commit 3e68e7f9)
-
Fixes: 2d4597de ("pan/bi: Use autogenerated modifiers") Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!9719> (cherry picked from commit 28bf06f3)
-
Fixes: f0d29238 ("i965/gen11: Emit SLICE_HASH_TABLE when pipes are unbalanced.") Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com> Part-of: <mesa/mesa!9505> (cherry picked from commit b9a7f931)
-
Dylan Baker authored
-
- Mar 19, 2021
-
-
Rhys Perry authored
This can be created by subgroupBallotFindMSB(). Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Closes: mesa/mesa#4458 Part-of: <mesa/mesa!9654>
-
Acked-by: Daniel Stone <(daniels@collabora.com)> Part-of: <mesa/mesa!9018> (cherry picked from commit f59e6ad5)
-
- Mar 18, 2021
-
-
Windows doesn't actually distribute a full TLS CA certificate store, but pulls them in over time with Windows Update. Try to prime it by manually pulling the certificates and installing them. This bumps the Windows tag to force a rebuild. Acked-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <!9618> (cherry picked from commit e6aacec9) Conflicts: .gitlab-ci.yml
-
LLVM is moving to the 13 release, but LLVM-SPIRV is still so in the past. Given that LLVM 12.0.0 is still not out (we are at 12.0.0-rc1 today), use the `release/12.x` branch for LLVM. We should also tag LLVM-SPIRV, but... it seems that they haven't caught up yet, so keep using the master branch, but add a note for a future committer. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Part-of: <mesa/mesa!8740> (cherry picked from commit 8deca5a7)
-
The new registry caching in place for registry.fd.o can not handle layers bigger than 5 GB. The last layer we used to build on windows was 5.2 GB, meaning that the upload would fail. Split the layers by calling multiple `RUN`, hoping that the size will be roughly split between those steps if we have a special layer for VS2019. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Part-of: <mesa/mesa!8740> (cherry picked from commit a69ab2ae)
-
https://gitlab.freedesktop.org/mesa/mesa/-/jobs/6898838 failed at uploading the containers but got kicked out right before being able to give us a valid error. Bump the timeout for windows container builds, to not have this unfortunate situation. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Part-of: <mesa/mesa!8740> (cherry picked from commit 0ef1f418)
-
Since the child process doesn't call exec(), exit() attempted to run atexit handlers registered by the parent process. This could result in the child process hanging in exit() if there were still disk cache threads alive when the parent process called fork(). (The CI runners hit this multiple times when running tests in strace) Fixes: 6a246f5c "aco/tests: Fix deadlock for too large test lists" Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!9472> (cherry picked from commit d4116919)
-
This approach is taken from the Vulkan spec[1], where a robust maxLod of 0.25 is proposed instead of 0.0. This has the effect of allowing room for both minification and magnification filters, yet still rounding down to the right miplevel in the end. [1]: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkSamplerCreateInfo.html#_description Fixes: 8d46e35d ("zink: introduce opengl over vulkan") Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!9649 > (cherry picked from commit 539036a9) Conflicts-resolved-by: Dylan Baker <dylan@pnwbakers.com> Conflicts: src/gallium/drivers/zink/ci/deqp-zink-lvp-fails.txt This CI file does not exist (and is not used AFAICT) in the 21.0 branch, so I've removed it.
-
this was only implemented for textures (I assume because drivers which implement the corresponding intrinsic don't support multisampled images), but it's also used for shader images Fixes: 22fdb2f8 ("nir/spirv: Update to the latest revision") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!9682> (cherry picked from commit 50881d59)
-
Cc: mesa-stable Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!9678> (cherry picked from commit 89c8e22c)
-
I think we need to care about this here as well, otherwise the variant logic might be short-circuited. Fixes: 7eb5fd98 ("mesa/st: handle running nir lower passes for ucp and psiz in tess stage") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!9631> (cherry picked from commit 78de2de8)
-
I think we need to care about this here as well, otherwise the variant logic might be short-circuited. Fixes: ad0037fc ("mesa/st: set lower_point_size for tes/gs during program update") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!9631> (cherry picked from commit bdfe0e3e)
-
this should be fine and good Fixes: c768c529 ("zink: force stencil format for stencil-only samplers and swizzle the right component") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!9673> (cherry picked from commit e02d1eb9)
-
new_draw has updated draw count. Stale info in draw caused regression with piglit gl-3.0-multidrawarrays-vertexid -indirect fixes piglit test ./gl-3.0-multidrawarrays-vertexid -indirect Fixes: 1cd455b1 ("gallium: extend draw_vbo to support multi draws") Reviewed-by: Brian Paul <brianp@vmware.com> Reviewed-by: Charmaine Lee <charmainel@vmware.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!9656> (cherry picked from commit c6c532fa)
-
Since states were not updated in fast path for restoring light attributes, seen darker images in solidworks2012_viewprt.trace Fixes regression seen with solidworks2012_viewport.trace Fixes: 7fa9d9d0 ("mesa: add a fast path for restoring light attributes") Reviewed-by: Brian Paul <brianp@vmware.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!9657> (cherry picked from commit edbbf453)
-
If we load constant data using pull constant SENDS, and we later load that register with some other data, we can end up in a situation where we don't track the initial fixed register write and therefore end up using uninitialized registers. This tracks write-on-write of fixed GRFs like we do for normal virtual GRFs. v2: Fix post_alloc_reg case (Jason) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!9667> (cherry picked from commit 8b6d2210)
-
This seems to be originally introduced from 2a0d45ae, and 562aaea0 misused the method. Fixes: 2a0d45ae "freedreno/ir3: Add a NIR pass to select tex instructions eligible for pre-fetch" Fixes: 562aaea0 "freedreno/ir3: respect tex prefetch limits" Signed-off-by: Hyunjun Ko <zzoon@igalia.com> Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <mesa/mesa!9125> (cherry picked from commit 433cdd1c)
-
Dylan Baker authored
-
- Mar 17, 2021
-
-
Dylan Baker authored
This is a backport of 0a1c533c and 806c6121
-
Dylan Baker authored
-
- Mar 15, 2021
-
-
Dylan Baker authored
-
Vulkan spec says If multiview is enabled in the render pass, this value will be one of the bits set in the view mask of the subpass the pipeline is compiled against. If multiview is not enabled in the render pass, this value will be zero. Closes: mesa/mesa#4446 Fixes: 0db70703 ("anv/pipeline: Add shader lowering for multiview") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!9574> (cherry picked from commit f603a2c2)
-
Read vlVaBuffer->size bytes instead of an hardcoded value. Fixes: deb7dc82 ("frontends/va: handle protected slice data buffer") Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com> Reviewed-by: James Zhu <James.Zhu@amd.com> Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!9553> (cherry picked from commit 9e5623cc)
-
the push set index isn't always 0, so the offsets need to be updated in order to avoid clobbering other sets Fixes: 6be19765 ("lavapipe: add support for VK_KHR_push_descriptor") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!9558> (cherry picked from commit 536533f5)
-
gl_MaxVaryingFloats was not removed from core until 4.20 and is still available in compat shaders. Found while writing some new CTS to test the correct declarations of this constant. Fixes: 0ebf4257a385i ("glsl: define some GLES3 constants in GLSL 4.1") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!9514> (cherry picked from commit 684f97de)
-
Starting with d0d039a4, we emit writes to the push constant chunk of the payload to stomp out-of-bounds data to zero for Vulkan. Then, in 369eab94, we started emitting shader preamble code for emulated push constants on Gen12.5 parts. In either of these cases, we can run into issues if we don't have a proper live range for some of the payload registers where they get used for something and then smashed by our push handling code. We've not seen many issues with this yet because it only happens when you have dead push constants. Fixes: d0d039a4 "anv: Emit pushed UBO bounds checking code..." Fixes: 369eab94 "intel/fs: Emit code for Gen12-HP indirect..." Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!9501> (cherry picked from commit b9e9f92f)
-
This reverts commit 6c8cc9be. A spec bug was resolved confirming the original behaviour. Also it seems the game Foundation no longer depends on the incorrect behaviour. Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!9486> (cherry picked from commit 17725694)
-
Obviously this didn't affect correctness. Not sure about performance. It also changes enabled_channels to match radeonsi. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Fixes: f29c81f8 ("aco: use VOP2 for v_cvt_pkrtz_f16_f32 if possible") Part-of: <mesa/mesa!9459> (cherry picked from commit 341dd9d8)
-
If a SPIR-V module contains for example both a geometry and a compute shader, when processing the geometry shader its vertices out, input primitive and output primitive attributes would get overwritten by the value of the WorkgroupSize. ``` ; SPIR-V ; Version: 1.5 ; Generator: Khronos; 17 ; Bound: 12 ; Schema: 0 OpCapability Geometry OpCapability Shader %1 = OpExtInstImport "GLSL.std.450" OpMemoryModel Logical GLSL450 OpEntryPoint Geometry %main "main" OpEntryPoint GLCompute %main_0 "main" OpExecutionMode %main InputPoints OpExecutionMode %main Invocations 1 OpExecutionMode %main OutputTriangleStrip OpExecutionMode %main OutputVertices 4 OpExecutionMode %main_0 LocalSize 1 1 1 OpSource GLSL 460 OpSource GLSL 460 OpName %main "main" OpName %main_0 "main" OpModuleProcessed "Linked by SPIR-V Tools Linker" OpDecorate %gl_WorkGroupSize BuiltIn WorkgroupSize %void = OpTypeVoid %6 = OpTypeFunction %void %uint = OpTypeInt 32 0 %v3uint = OpTypeVector %uint 3 %uint_1 = OpConstant %uint 1 %gl_WorkGroupSize = OpConstantComposite %v3uint %uint_1 %uint_1 %uint_1 %main = OpFunction %void None %6 %10 = OpLabel OpReturn OpFunctionEnd %main_0 = OpFunction %void None %6 %11 = OpLabel OpReturn OpFunctionEnd ``` Running spirv_to_nir on the SPIR-V sample above and for the geometry entry point would say that (among others): * vertices out: 1 * input primitive: LINES * output primitive: LINES By removing any reference to `%gl_WorkGroupSize`, the output would change to (among others): * vertices out: 4 * input primitive: POINTS * output primitive: TRIANGLE_STRIP Fixes: 7d862ef5 ("spirv: Rework handling of spec constant workgroup size built-ins") v2: * Move the check from inside `handle_workgroup_size_decoration_cb()` to its caller (Caio Marcelo de Oliveira Filho ) * Add an assert on the shader stage before using `workgroup_size_builtin` (Caio Marcelo de Oliveira Filho ) Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Signed-off-by: Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!9418> (cherry picked from commit 4a408ff7)
-