- Feb 25, 2024
-
-
This instruction behaves the same as *OpCopyObject* by making a copy of _Value_. Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Reviewed-by:
Faith Ekstrand <faith.ekstrand@collabora.com> Reviewed-by:
Caio Oliveira <caio.oliveira@intel.com> (cherry picked from commit 5df7be80) Part-of: <mesa/mesa!27740>
-
- Feb 24, 2024
-
-
Part-of: <mesa/mesa!27286> (cherry picked from commit fa1c9618)
-
Eric Engestrom authored
Overkill but better than being prevented from accepting backport MRs because Collabora deleted these files from the S3 bucket *yet again*...
-
- Feb 14, 2024
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Another game that can't get AS updates right. Cc: mesa-stable Part-of: <mesa/mesa!27590> (cherry picked from commit afab80bd)
-
For some yet unknown reason the CS L3 coherency setting is different on MTL than DG2. Fixes issues in tests from the subgroup : dEQP-VK.api.buffer_marker.* Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: c8e122a7 ("anv: Implement rudimentary VK_AMD_buffer_marker support") Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!27613> (cherry picked from commit e54638dd)
-
this logic relies on constant indexing for compact arrays, but this is frequently not the case for compact array builtins (e.g., gl_TessLevelOuter). the usual strategy of lowering to temps isn't viable in TCS, which means io lowering has to be able to handle indirect access to these builtins without crashing cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!27534> (cherry picked from commit 9e2c7314)
-
The round up in 'next_address_8kb = DIV_ROUND_UP(push_constant_kb, 8)' was not decreasing the amount of URB available for Mesh and Task, what could cause an over allocation of URB. There was also no minimum entries enforcement for Mesh and Task, what could cause 0 r.mesh_entries to be set in a case where tue_size_dw is 90% > than mue_size_dw. Same for r.task_entries when Task is enabled. Also adding a few more asserts to help debug. This fixes at least dEQP-VK.mesh_shader.ext.properties.mesh_payload_size in LNL but it has potential to fixes other Mesh tests as well. Cc: mesa-stable Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
-
https://github.com/llvm/llvm-project/pull/81287 Foz-DB Navi31: Totals from 406 (0.52% of 78112) affected shaders: Instrs: 585342 -> 585750 (+0.07%) CodeSize: 3077856 -> 3079456 (+0.05%); split: -0.00%, +0.05% Latency: 3263165 -> 3263326 (+0.00%); split: -0.00%, +0.01% InvThroughput: 664092 -> 664114 (+0.00%); split: -0.00%, +0.00% VClause: 11143 -> 11537 (+3.54%) SClause: 11878 -> 11884 (+0.05%) Copies: 39807 -> 39815 (+0.02%) Cc: mesa-stable Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!27569> (cherry picked from commit 61214972)
-
Fixes: 2645003b ("rusticl: Create CL mem objects from GL") Signed-off-by:
Karol Herbst <kherbst@redhat.com>
Part-of: <mesa/mesa!27385>
(cherry picked from commit 3f7b3449) -
Closes: mesa/mesa#10505 Fixes: 2645003b ("rusticl: Create CL mem objects from GL") Signed-off-by:
Karol Herbst <kherbst@redhat.com>
Part-of: <mesa/mesa!27385>
(cherry picked from commit 11729133) -
Cc: mesa-stable Signed-off-by:
Karol Herbst <kherbst@redhat.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!27385> (cherry picked from commit 727cddd3)
-
When doing query result copies in 3D mode, we're flushing the render target cache, but the shader writes go through the dataport. Fixes flakes/fails in piglit with shader query copies forced with Zink : $ query_copy_with_shader_threshold=0 ./bin/arb_query_buffer_object-coherency -auto -fbo Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org>
Part-of: <mesa/mesa!26797>
(cherry picked from commit c53a4711) -
Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org>
Part-of: <mesa/mesa!26797>
(cherry picked from commit 2437556d) -
Without this, on some "buggy" qemu cpu setup, LLVM could crash if LLVM detects the wrong CPU type. Fixes: f92cadcc ("llvmpipe: Always using util_get_cpu_caps to get cpu caps for llvm on x86") Signed-off-by:
Lepton Wu <lepton@chromium.org> Reviewed-by:
Yonggang Luo <luoyonggang@gmail.com> Part-of: <mesa/mesa!27539> (cherry picked from commit 04d26ceb)
-
When bitrate or fps change is detected, only update rate control parameters instead of completely reinitializing encode session. This fixes an issue where if application changed bitrate or fps often, the output bitrate would significantly overshoot the target bitrate in some cases. In other cases, the output bitrate would be extremely low instead. Cc: mesa-stable Reviewed-by:
Ruijing Dong <ruijing.dong@amd.com> Part-of: <mesa/mesa!27548> (cherry picked from commit 8d44a115)
-
It is possible to free memory backing images before images are destroyed : VkFreeMemory: "Memory can be freed whilst still bound to resources, but those resources must not be used afterwards." The spec leaves us the option to keep a reference on the associated memory and free it only when all the bound resources have been destroyed. Here we choose to free memory immediately. One particular test in the CTS (dEQP-VK.synchronization.internally_synchronized_objects.pipeline_cache_graphics) does the following : imgA = vkCreateImage() imgB = vkCreateImage() memA = vkAllocateMemory() vkBindImageMemory(imgA, memA) # Aux mapping with ref count = 1 vkFreeMemory(memA) # Aux mapping removed, ref count = 0 memB = vkAllocateMemory() # Same address as memA vkBindImageMemory(imgB, memB) vkDestroyImage(imgA) # Removes the mapping of imgB-memB vkQueueSubmit() # hang with pagefault in AUX-TT The solution implemented in this change is to not do anything AUX-TT related in vkFreeMemory(). This soluation has some consequences, because a virtual memory address range freed and reallocated cannot be rebound in the AUX-TT until all the associated resources have released their AUX-TT mapping (to bring back the AUX-TT refcount of the range to 0). This should still be better than keeping the memory allocated through refcounting of the anv_bo. Signed-off-by: -
Rob worded it well in 9e8450b6. "We don't want util_cpu to vomit cpu caps all over the test output." This reverts commit c6979d97. Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!27564> (cherry picked from commit 62fa5c8d)
-
If a program does two blits in a row, we internally do a sequence of operations that involves binding vb0. Previously, the vb0 state after each operation would look something like: | operation | cmd->state.gfx.vb0 | hardware | save->vb0 | | ---------------------------- | ------------------ | --------- | --------- | | | user | user | | | nvk_meta_begin() | user | user | user | | BindVertexBuffers(internal0) | internal0 | internal0 | user | | nvk_meta_end() | internal0 | user | | | nvk_meta_begin() | internal0 | user | internal0 | | BindVertexBuffers(internal1) | internal1 | internal1 | internal0 | | nvk_meta_end() | internal1 | internal0 | | That is, CmdBindVertexBuffers() would update cmd->state.gfx.vb0, but nvk_meta_end() would not. This meant that the last operation would bind a driver-internal buffer instead of the original value that the user set. This change fixes the issue by tracking cmd->state.gfx.vb0 in nvk_cmd_bind_vertex_buffer(), which both CmdBindVertexBuffers() and nvk_meta_end() call into. After this commit, the state looks like: | operation | cmd->state.gfx.vb0 | hardware | save->vb0 | | ---------------------------- | ------------------ | --------- | --------- | | | user | user | | | nvk_meta_begin() | user | user | user | | BindVertexBuffers(internal0) | internal0 | internal0 | user | | nvk_meta_end() | user | user | | | nvk_meta_begin() | user | user | user | | BindVertexBuffers(internal1) | internal1 | internal1 | user | | nvk_meta_end() | user | user | | To test this commit, build gtk4 commit 87b66de1, run: GSK_RENDERER=vulkan gtk4-demo --run=image_scaling then select trilinear filtering in the dropdown and check for rendering artifacts. Fixes: e1c66501 ("nvk: Use vk_meta for CmdClearAttachments") Part-of: <mesa/mesa!27559> (cherry picked from commit d98ff2cc) -
Cc: mesa-stable Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!27537> (cherry picked from commit cd6d9c59)
-
Public docs are apparently wrong: https://github.com/llvm/llvm-project/pull/79598#issuecomment-1933988048 Cc: mesa-stable Reviewed-by:
-
vulkan_icd_link_args was added for other vulkan drivers but not hasvk. Without it, statically linked json-c symbols are wrongly exported. Ref: 2b1e9b0f ("anv: add linker script to fix android symbols") Fixes: 78578a6d ("vk: move radv's linker symbols scripts for use in all drivers") Reviewed-by:
Jordan Justen <jordan.l.justen@intel.com> Part-of: <mesa/mesa!27540> (cherry picked from commit fb7240be)
-
the spec allows this and tests like spec@arb_texture_multisample@arb_texture_multisample-dsa-texelfetch expect it cc: mesa-stable Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!25931> (cherry picked from commit fab5c706)
-
Output debug info only when explicitly requested with TU_DEBUG=startup otherwise we should be silent. Closes: mesa/mesa#10213 Fixes: a6691476 ("tu: Always print startup failure messages") Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!27527> (cherry picked from commit c8cc7c5c)
-
valhall_disasm compilation fails if the valhall_enums.h has not be generated. Fixes: 619566de ("pan/va: Generate header containing enums") Closes: mesa/mesa#10553 Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Part-of: <mesa/mesa!27524> (cherry picked from commit 49069a12)
-
Apparently, Midgard GPUs don't like when the last 2 words of compute/vertex jobs contain garbage. Extend the compute job definition to include a padding section thus aligning the job on a 64-byte boundary, and add the according pan_section_pack() calls where we have a compute job filled. Fixes: b76420be ("panfrost: Split command stream descriptor definitions per-gen") Closes: mesa/mesa#10558 Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Tested-by:
Anton Bambura <jenneron@postmarketos.org> Part-of: <mesa/mesa!27515> (cherry picked from commit 5b1b76e9)
-
The game uses shader with `location=0` and `location=1` outputs where it wants dual source blending and should've used `location=0, index=0` and `location=0, index=1`. Cc: mesa-stable Closes: mesa/mesa#10413 Signed-off-by:
Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Reviewed-by:
-
SPECviewperf creo-03 needs GL_EXT_shader_image_load_store in order for its shaders to compile but we don't support a few corner cases that didn't make it into the ARB variant. It seems to run fine with an override, so just do that for now. Cc: mesa-stable Acked-by:
-
A bit surprised that this didn't show up in any piglit or deqp. Fixes: cf0c7258 ("freedreno/a5xx: MSAA") Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!27508> (cherry picked from commit c3062e34)
-
Vertex shaders were writing TEXCOORDs before GENERICS, however fragment shaders were reading it the opposite way, so this caused problems for shaders that used both TEXCOORD and GENERIC varyings. Fixes: d4b8e8a4 Closes: mesa/mesa#10489 Signed-off-by:
Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by:
Filip Gawin <filip.gawin@collabora.com> Part-of: <mesa/mesa!27469> (cherry picked from commit 0ac68019)
-
iris_wait_syncobj() succeed if IOCTL return is 0 otherwise it failled. Cc: mesa-stable Signed-off-by:
-
It can be the case that a collect and one of its sources are assigned to non-overlapping parts of the same merge set, for example: ssa_1 = ... ssa_2 = ... ssa_3 = ... ssa_4 = collect ssa_1, ssa_2 (kill), ssa_3 ... = ssa_4 (kill) ssa_5 = collect ssa_1, ssa_3 ... = ssa_1 (kill) ... = ssa_3 (kill) ... = ssa_5 (kill) If we merge the first collect first, we get a merge set: ssa_1 (offset 0) ssa_2 (offset 2) ssa_3 (offset 4) ssa_4 (offset 0) Now, we decide to merge ssa_1 and ssa_5: ssa_1 (offset 0) ssa_2 (offset 2) ssa_3 (offset 4) ssa_4 (offset 0) ssa_5 (offset 0) ssa_3 cannot become a child of ssa_5 in the interval tree, just like a source not in the same merge set, so we should not remove it and then reinsert it assuming that RA will make it a child of ssa_5. This fixes an RA validation error in Farming Simulater. Fixes: 0ffcb19b ("ir3: Rewrite register allocation") Part-of: <mesa/mesa!27497> (cherry picked from commit aeed5fd9)
-
Allows to use zink with drivers that do not expose this extension. Backport-to: 23.3 24.0 Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Signed-off-by:
Corentin Noël <corentin.noel@collabora.com> Part-of: <mesa/mesa!27516> (cherry picked from commit 72886cbe)
-
Eric Engestrom authored
-
- Feb 06, 2024
-
-
Follow the same logic as H264. Fixes: 5edbecb8 ("frontends/va: adding va av1 encoding functions") Reviewed-by:
-
`$ meson wrap update zlib` Cc: mesa-stable Reviewed-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!27311> (cherry picked from commit 56f31d18)
-
No fossil-db changes. Signed-off-by:
-
AoE4 samples texture on the edge between texels, which can cause unexpected texel to be returned, and cause misrenderings. This workaround enables coordinate rounding even in NEAREST mode, which fixes the problem. Cc: mesa-stable Closes: mesa/mesa#9864 Signed-off-by:
-
