- May 19, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
If CRC data is currently invalid and the current batch will make it valid, write even clean tiles to make sure CRC data is updated. Fixes: 8ba2f9f6 ("panfrost: Create a blitter library to replace the existing preload helpers") Part-of: <mesa/mesa!10566> (cherry picked from commit e241ca6e)
-
Part-of: <mesa/mesa!10566> (cherry picked from commit 1c58614c)
-
- May 18, 2021
-
-
We only need the format swizzle, not the full swizzle. Fixes: 57e796a1 ("radv: Implement VK_EXT_custom_border_color") Gitlab: mesa/mesa#4020 Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!9731> (cherry picked from commit 74d36c4f)
-
The start offset of the vertex samplers isn't zero, but the indexing of the passed in views array is still zero based. Use the correct indexing variable to fix vertex sampler setup. Cc: <mesa-stable@lists.freedesktop.org> Fixes: 81ab9fe2 ("etnaviv: handle NULL views in set_sampler_views") Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!10724> (cherry picked from commit 92ed827f)
-
There is a regression that made it impossible to export gem handles with write access. That is, a client may export gem handles of each buffer plane, then export dmabuf fds using these handles, and mmap these dmabuf in a different process (this is what Chromium does). After mesa/mesa!4861 , it became impossible as mmap resulted in EACCESS error as slightly different approach was taken for exporting these gem handles. This CL fixes exporting gem handles (which are exported from dmabuf fds) by adding the DRM_RDWR flag. Cc: mesa-stable Fixes #3119 Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!10850> (cherry picked from commit 5eaf8b59)
-
There is a regression that made it impossible to export gem handles with write access. That is, a client may export gem handles of each buffer plane, then export dmabuf fds using these handles, and mmap these dmabuf in a different process (this is what Chromium does). After mesa/mesa!4861 , it became impossible as mmap resulted in EACCESS error as slightly different approach was taken for exporting these gem handles. This CL fixes exporting gem handles (which are exported from dmabuf fds) by adding the DRM_RDWR flag. Cc: mesa-stable Fixes #3119 Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!10851> (cherry picked from commit b74898ef)
-
It's perfectly legal to declare multiple SSBOs that point to the same binding/descriptor_set with different access mask. Currently, it will always get the first one in the list that matches binding/desc_set regardless of the access mask, but other variables might have different access mask. Fix this by being conservative if another variable uses the same binding/desc_set because we can't get it reliably without adding a new field to vulkan_resource_index. This fixes rendering issues in Resident Evil Village with vkd3d-proton. This bug has been uncovered by ("spirv: Don't remove variables used by resource indexing intrinsics") because variables are no longer removed No fossils-db changes. Cc: 21.1 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!10692> (cherry picked from commit 1b1c726c)
-
Eric Engestrom authored
-
Fixes crash in dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.last_frag_data when using this pass. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10411> (cherry picked from commit 73eb497b)
-
Gallium wants the depth or stencil component replicated on all .XYZW. That's easily done on pre-v7 since we can forge all the swizzles we want, but Bifrost v7 only supports a few combinations, so we have to combine the user swizzle with our own 'replicate' swizzle to make it work. Note that v7 has a trick to make border color work when the GRBA order is chosen: they apply the red border color to the green component. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!10612> (cherry picked from commit f08c1413)
-
It takes an intrinsic, not an ALU op. Fixes a clang complaint about enum conversion. Fixes: 306800d7 ("pan/midgard: Lower gl_VertexID/gl_InstanceID to attributes") Part-of: <mesa/mesa!10843> (cherry picked from commit 958f11d5)
-
Closes: #4777 Fixes: 4e861ac4 ("i915g: Add more optimizations") Fixes: f34fd58e ("i915g: implement unfenced relocs for textures using tiling bits") Fixes: beaf039f ("i915g: cleanup static state calculation, part 1") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!10811> (cherry picked from commit 3e74bbf6)
-
Eric Engestrom authored
-
Don't depend moving between samples on key->multisample Big CI wins Reported-by: Erik Faye-Lund <kusmabite@gmail.com> Reviewed-by: Emma Anholt <emma@anholt.net> Fixes: 210d714f ("llvmpipe: handle multisample color stores.") Part-of: <mesa/mesa!10780> (cherry picked from commit 172c719b)
-
BOs in the cache are chronological, so we try oldest BOs first. That means if we find the oldest BO is busy, likely every BO is busy, and we should bail early. This dramatically reduces the useless cycles spent in bo_wait. I studied the BO cache of the following drivers, all of which handle this correctly: iris, lima, etnaviv, freedreno, vc4, v3d, v3dv. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!10794> (cherry picked from commit 77d04989)
-
Imported resources will not necessarily have their line stride aligned on 64 bytes, and things prove to work just fine even on Bifrost, so let's relax the condition and drop the comment stating that Bifrost needs pixel lines to be aligned on 64 bytes. Reported-by: Icecream95 <ixn@disroot.org> Suggested-by: Icecream95 <ixn@disroot.org> Fixes: 051d62cf ("panfrost: Add a pan_image_layout_init() helper") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!10423> (cherry picked from commit 6b036d13)
-
Fixes: a124c47b ("panfrost: Fix NULL derefs in pan_cmdstream.c") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!10393> (cherry picked from commit dad599f1)
-
We need to know if there's a temporary in SCC before the instruction, not after. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Fixes: 93c8ebfa ("aco: Initial commit of independent AMD compiler") Part-of: <mesa/mesa!10459> (cherry picked from commit 4e459df0)
-
Fixes: d659ce0d ('aco/ra: prevent underflow register for p_create_vector operands') Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!10832> (cherry picked from commit b9601692)
-
This fixes some new cts tests that exercise blitting between compressed and uncompressed formats. Cc: mesa-stable Signed-off-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!10830> (cherry picked from commit 72fd1260)
-
MSVC uses different decorated names for 32-bit versus 64-bit. Declare all argument sizes for 32-bit because computing the actual size would be difficult. Fixes: 9be7aa3f ("vulkan: Add a common entrypoint table generator") Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Acked-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <!10573> (cherry picked from commit fb7be787)
-
This will be used in the following patch. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!10763> (cherry picked from commit 1a71d6aa)
-
Eric Engestrom authored
-
Some apps such as Gamescope crash under the mere presence of the virtio Vulkan driver without using a device. This is because virtgpu::fd is zero-initialized upon allocation, which causes fd 0 to be closed in virtgpu_destroy. Cc: mesa-stable Fixes: 247232d5 ("venus: add experimental renderers") Signed-off-by: Joshua Ashton <joshua@froggi.es> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Chia-I Wu <olvaffe@gmail.com> Part-of: <mesa/mesa!10814> (cherry picked from commit 6fcf3314)
-
We need to divide these by their divisors and special-case COSITED_EVEN. Fixes NV12 compositing in Gamescope. Fixes: 91702374 ("radv: Add ycbcr lowering pass.") Cc: mesa-stable Signed-off-by: Joshua Ashton <joshua@froggi.es> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!10816> (cherry picked from commit 855cb78d)
-
Supposedly avoids GPU hangs in BF4. See HSD 1707282275 and 14013111325. v2. Fix bug in WA implementation. (Sagar) Cc: mesa-stable Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Part-of: <mesa/mesa!8755> (cherry picked from commit bcdebf4f)
-
Supposedly avoids GPU hangs in BF4. See HSD 1707282275 and 14013111325. v2. Fix bug in WA implementation. (Sagar) Cc: mesa-stable Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Part-of: <mesa/mesa!8755> (cherry picked from commit eef4c708)
-
This will be used for an MCS workaround. Cc: mesa-stable Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Part-of: <mesa/mesa!8755> (cherry picked from commit 608c1316)
-
The load-store vectorizer can create a large amount of unnecessary nir_op_vec and nir_op_mov instructions. This prevents nir_opt_move from stalling to much and potentially also helps other passes. Closes: #4778 Fixes: 1958381c ('radv: Reorder some NIR optimizations in preparation for the I/O changes.') Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!10804> (cherry picked from commit b3eb87aa)
-
It could happen that we tested negative out-of-range registers for p_create_vector operands resulting in a crash. Fixes: 8962510e ('aco/ra: Conservatively refactor get_reg_specified to use PhysRegInterval') Closes: #4697 Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!10799> (cherry picked from commit d659ce0d)
-
Otherwise the lowering pass might try to lower any other load from a deref if its data.location value happens to be zero. Fixes: 418c4c0d compiler/nir: extend lower_fragcoord_wtrans to support VARYING_SLOT_POS Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!10577> (cherry picked from commit e418710f)
-
Cc: mesa-stable Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!10781> (cherry picked from commit df5b1496)
-
Otherwise, the game crashes on startup under xwayland. Closes: #4650 Cc: mesa-stable Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!10750> (cherry picked from commit c62d58c8)
-
v2: don't leak spec_entries v3: Also switch to VK_ERROR_UNKNOWN when parsing fails Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!10790> (cherry picked from commit 938e52a6)
-
Cc: mesa-stable Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com> Part-of: <mesa/mesa!9465> (cherry picked from commit e435511b)
-
Cc: mesa-stable Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Nanley Chery <nanley.g.chery@intel.com> Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com> Part-of: <mesa/mesa!9465> (cherry picked from commit 89f33126)
-
a fence applies to all the submitted cmdbufs, so it's necessary to do the flush which creates the user fence after all the cmdbufs have been processed in order to avoid creating a fence that only applies to the first cmdbuf Fixes: b38879f8 ("vallium: initial import of the vulkan frontend") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!10795> (cherry picked from commit cf3f17a6)
-
this breaks the driver! the uploader always maps its own pointer, so modifying that at any point just explodes things later Fixes: d179c5d2 ("zink: implement threaded context") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!10787> (cherry picked from commit 8e2ac244)
-