- Aug 19, 2020
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Fixes: 20d0ae46 ("nv50/ir: implement global atomics and handle it for nir") Signed-off-by: Karol Herbst <kherbst@redhat.com> Reviewed-by: Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!6367> (cherry picked from commit b283fb33)
-
This was updating the wrong counters. Reviewed-by: Eric Engestrom <eric@engestrom.ch> Fixes: a6f6ca37 ("llvmpipe: add initial shader create/bind/destroy variants framework.") Part-of: <mesa/mesa!6339> (cherry picked from commit e137bbb8)
-
We really need to update the enum for consistency, but that involves a bunch of GL & bitfield work which is error-prone, so since this is a fix for stable lets do the simple things. Confirmed that nothing in radv/aco/nir/spirv uses MAX_VERT_ATTRIB except the one thing I bumped. CC: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6120> (cherry picked from commit f038b3a1)
-
Game does the equivalent of a ALIGN(..., minUniformBufferOffsetAlignment >> 4) which breaks when said alignment is <16 with a SIGFPE. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6120> (cherry picked from commit 0067f899)
-
This adds applicationName + version through like engineName. Rationale: A game (World War Z) includes the store name in the executable name, so has multiple executable names. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!6120> (cherry picked from commit a1d4721e)
-
Anything that fails the is_external_block check is getting the vtn_local_load/store path which does read-modify-write which isn't correct if the variable mode can be written cross-workgroup. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!6372> (cherry picked from commit b479de85)
-
OpCopyMemory doesn't care about mismatched decorations, only about matching types. Closes: mesa/mesa#3418 Fixes: bf1a1eed Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!6344> (cherry picked from commit b6ebf6eb)
-
Oops ... Fixes: 64768111 "radv: Handle slightly different image dimensions." Closes: mesa/mesa#3417 Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!6337> (cherry picked from commit 50b03959)
-
KHR-GL45.robust_buffer_access_behavior.vertex_buffer_objects on the CTS 4.6.0 branch and this fixes it. Roland identified that if the vertex format doesn't contain channels then we shouldn't be overriding them to 0, so RGB fetch out of bounds should return 0 for RGB, but the A channel should still be getting back 1. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!6287> (cherry picked from commit 430e3310)
-
When importing a DMA-BUF, the image layout created in vkImageCreate may not match the imported BO's. To make this work we redo the layout based on the metadata of the imported image. The original patch did a delayed allocation just as for AHB, but that does not work for images that are not imported (but e.g. exported only). Original patch by Simon Ser <contact@emersion.fr> Closes: mesa/mesa#2801 CC: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6274> (cherry picked from commit d19bc94e)
-
This change fixes off-by-one results in corner cases such as 0xffffffff / 0x11111111. For details refer to LLVM bug 46212. Fixes: 8b98d095 ('nir/lower_idiv: add new llvm-based path') Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6281> (cherry picked from commit 8277334f)
-
inputs_read/outputs_written are used for a shader stage to determine the layout of input and output storage. Adjacent stages must agree on the layout, so adjacent input/output bitfields must match. Most of the time, cross-stage optimizations make that happen anyway, but there are some cases (with special values like clip distances and point size) where this doesn't happen. Fixes crashes in dEQP-VK.subgroups.*.framebuffer.*_tess_eval Closes: mesa/mesa#3210 Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!6102> (cherry picked from commit 2701f887)
-
Port the change done for RGBX8888 in 02a1f953. If XR24 images are considered to be VIEW_CLASS_24_BITS-compatible, it's reasonable to assume that XB24 images would be as well. Fixes: bf576772 ("dri_util: add driImageFormatToSizedInternalGLFormat function") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!6095> (cherry picked from commit 8abf59ff)
-
It could happen that only the branch condition was computed in WQM and not the branch instruction. There is now some rendundancy which should be cleaned up. Fixes: 3817fa7a ('aco: fix WQM handling in nested loops') Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6260> (cherry picked from commit fdb97d3d)
-
Found by inspection, doesn't fix anything known. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!6279> (cherry picked from commit e4c6204d)
-
Found by inspection. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!6277> (cherry picked from commit 02562505)
-
MSAA worked before etnaviv landed in upstream mesa but got broken over time. Disable MSAA completely until it is fixed again. Fixes problems/crashes with applications that want to make use of MSAA. Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Part-of: <mesa/mesa!5608> (cherry picked from commit 044b2385)
-
setup_nir() is done for all shaders before any of them are selected, so constant_data_offset could be incorrect for the first shader. Fixes incorrect geometry in Mafia III and Max Payne 3. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: mesa-stable Closes: mesa/mesa#2768 Part-of: <mesa/mesa!6205> (cherry picked from commit 6e705081)
-
We cannot decompress from the compute queue. While I'm pretty sure VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL is only useful on the graphics queue, I cannot find a VU that prevents the transition from happening on another queue, so we need to be careful here. This patch ensures we do the decompression on the barrier that changes the queue ownership. Another problem was that DCC images were considered fast-clearable when not DCC compressed, which resulted in a mess with concurrent queue ownership. Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#3387 Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6252> (cherry picked from commit e362ccb2)
-
Currently Linux kernel gathers performance counters at fixed intervals (~5-10ms), so if application uses AMD_performance_monitor extension and immediately after glFinish() asks GL driver for HW performance counter values it might not get any data (values == 0). Fix this by moving the "read counters from kernel" code from "is query ready" to "get counter values" callback with a loop around it. Unfortunately it means that the "read counters from kernel" code can spin for up to 10ms. Ideally kernel should gather performance counters whenever we ask it for counter values, but for now we have deal with what we have. Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!5788> (cherry picked from commit 2fbab5a1)
-
Eric Engestrom authored
The option is not a toggle to "allow GPU vendor to be overridden", it *is* the override. Fixes: dca119f1 ("mesa/gallium: add dric option to allow overriding GL vendor string") Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!6207> (cherry picked from commit 7fbadfc3)
-
Eric Engestrom authored
Cc: mesa-stable Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Part-of: <mesa/mesa!4448> (cherry picked from commit 800816d7)
-
Eric Engestrom authored
Cc: mesa-stable Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Part-of: <mesa/mesa!4448> (cherry picked from commit 351d513e)
-
Eric Engestrom authored
Cc: mesa-stable Signed-off-by: Eric Engestrom <eric@engestrom.ch> Part-of: <!6134> (cherry picked from commit e3069c42)
-
The code applied the restriction too late, which could overflow LDS size, which started happening more often after the minimum vertex count was increased for Sienna. Incorporate the clamping into the previous code for rounding up the counts. Now the LDS size can never overflow, but it may use vector lanes less efficiently (max_gsprims can be decreased more), which will be addressed in the next commit. Fixes: 4ecc39e1 ("radeonsi/gfx10: NGG geometry shader PM4 and upload") Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!6137> (cherry picked from commit 64c741ff)
-
Fixes: 88efb63c ("radeonsi/gfx10: implement Wave32") Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!6137> (cherry picked from commit b6fb09fd)
-
We don't want to leak in case of failure. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reported-by: Ivan Briano <ivan.briano@intel.com> Fixes: 246261f0 ("anv: prepare the driver for delayed submissions") Fixes: 34f32a6d ("anv: implement VK_KHR_timeline_semaphore") Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!6200> (cherry picked from commit b43bcb05)
-
After updating vertex outputs being written based on optimized NIR, they may go out of sync with outputs in mesa IR. Which is translated to TGSI and used together with NIR if draw doesn't have llvm. It's much easier to treat such outputs as zero because there is no pass to entirely get rid of them. Similar to eeab9c93 but now for outputs. Fixes: d684fb37 Closes: mesa/mesa#3365 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!6187> (cherry picked from commit 782ba8d3)
-
We advertised the extension string but never the feature bit. Doh! Fixes: c57338b9 "anv: Enable SPV_INTEL_shader_integer_functions2..." Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!6033> (cherry picked from commit 7f06d194)
-
When nothing is going to be flushed, the kernel will get no job that signals the syncobj. Signal it by ourselves, otherwise it will never get signaled. Closes: #3371 Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!6190> (cherry picked from commit 9e397956)
-
Eric Engestrom authored
-
Eric Engestrom authored
-
- Aug 05, 2020
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Fixes: 9680a754 "radeonsi/gfx9: enable SDMA buffer copying & clearing" Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!4895> (cherry picked from commit 07a49bf5)
-
Otherwise it doesn't compile. Reviewed-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: aba57b11 ("anv: support GetSwapchainGrallocUsage2ANDROID for Android") Part-of: <mesa/mesa!6112> (cherry picked from commit ff0dbf20)
-
One day, we may want copy_prop_vars or other passes to be able to see through certain types of casts such as when someone casts a uint64_t to a uvec2. However, for now we should just avoid casts all together. Fixes: d8e3edb7 "nir/deref: Support casts and ptr_as_array in..." Tested-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!6072> (cherry picked from commit 611f654f)
-