Skip to content
Snippets Groups Projects
  1. May 02, 2022
  2. May 01, 2022
  3. Apr 30, 2022
  4. Apr 29, 2022
  5. Apr 28, 2022
  6. Apr 26, 2022
  7. Apr 23, 2022
  8. Apr 22, 2022
  9. Apr 21, 2022
  10. Apr 20, 2022
  11. Apr 19, 2022
    • Camilo Celis Guzman's avatar
      gstav1parse: fixup various possible logical errors · 3eb5d669
      Camilo Celis Guzman authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Found via an analyzed build for Clang. Specifically we had:
      
      gstav1parse.c[1850,11] in gst_av1_parse_detect_stream_format: Logic error: The left operand of '==' is a garbage value
      gstav1parse.c[1606,11] in gst_av1_parse_handle_to_small_and_equal_align: Logic error: The left operand of '==' is a garbage value
      
      Also a couple of false-positives:
      
      gstav1parse.c[1398,24] in gst_av1_parse_handle_one_obu: Logic error: Branch condition evaluates to a garbage value
      gstav1parse.c[1440,37] in gst_av1_parse_handle_one_obu: Logic error: The left operand of '-' is a garbage value
      
      Part-of: <gstreamer/gstreamer!2240>
      3eb5d669
    • Nirbheek Chauhan's avatar
      meson: Add -Wl,-rpath,${libdir} on macOS · f67d8759
      Nirbheek Chauhan authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      We made the gstreamer installation prefix relocatable by picking up
      plugins relative to the location of libgstreamer-1.0.dylib, similar to
      how it's done for Windows:
      
      !1627
      
      This had a lot of side-effects:
      
      #1051
      cerbero#363
      cerbero#371
      cerbero#362
      
      A partial fix for the cerbero side of these was:
      
      cerbero!807
      
      However, this relied on the consumers knowing that they need to add
      `LC_RPATH` entries to the libdir of the prefix. This is done
      automatically by build systems like Meson, but not by others, such as
      Autotools, CMake, Cargo, XCode, etc. For those, we need to add the
      RPATH entries to the gstreamer-1.0.pc file.
      
      This also has the side-effect of fixing the loading of gstreamer rust
      plugins on macOS:
      
      Fixes #1159
      
      Fixes #1149
      
      Part-of: <!2237>
      f67d8759
    • Jan Schmidt's avatar
      playbin3: Remove stale code · cf61b8aa
      Jan Schmidt authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Remove now-unused get_stream_type_for_event() function.
      
      Part-of: <!2236>
      cf61b8aa
    • Jan Schmidt's avatar
      playbin3: Hold playbin lock on pad-added · 45a709cf
      Jan Schmidt authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Take the playbin lock when accessing the combiner
      to add a new pad to link to. Fixes races against
      streams-selected messages triggering reconfiguration.
      
      Part-of: <!2236>
      45a709cf
    • Jan Schmidt's avatar
      playbin3: Reconfigure on streams-selected message. · 5e386415
      Jan Schmidt authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Don't reconfigure outputs when the select-streams
      event is sent from the app, as the selection may
      not take effect for some time. Instead, wait
      for the pipeline to confirm the new set of
      selected streams when it sends the message.
      
      Part-of: <!2236>
      5e386415
Loading