- Jun 29, 2022
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Jun 28, 2022
-
-
Extend the packed_instr struct to support texops above nir_texop_fragment_fetch_amd. Fixes: 603e6ba9 ("nir: add two new texture ops for multisample fragment color/mask fetches") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17186> (cherry picked from commit 370ca074)
-
The postponed spill is predicated using the condition from the last write, but this is only correct if the register was only written once in the TMU sequence, or if it is always written with the same predication. While we could try to track whether this is the case or not, it would make the postponed spill path even more complex than it already is, so let's just avoid predicating these. We are already discouraging TMU spilling of registers in the middle of TMU sequences, so this should not be a very common case. Cc: mesa-stable Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!17201> (cherry picked from commit cfccd93e)
-
If we are spilling a register that is used in the middle of a TMU sequence, we postpone the spill until the TMU sequence finishes, at which point we inject the spill and rewrite the original instruction to write to the new temp. However, this doesn't work if the register is written multiple times during the TMU sequence. In that scenario, we need to ensure that all writes are rewritten to use the new temp, not just the last one. Cc: mesa-stable Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!17201> (cherry picked from commit 98420408)
-
Cc: mesa-stable Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!17201> (cherry picked from commit 0bc65b1d)
-
this should be a VkResult Fixes: ab1941fc ("zink: handle zombie swapchains") Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!17149> (cherry picked from commit c1ce1889)
-
ralloc is not thread-safe. While a given context can only be accessed from a single thread at once, multiple contexts can be created against the same screen at once. The ralloc allocations against the shared screens will race. Depending on the result of the race, the same block of memory can be returned as the two new contexts in two different threads, causing a use-after-free when the context is freed later. We free the context explicitly when it's destroyed anyway. If screens are getting destroyed without the contexts getting destroyed first, that's a state tracker bug, not a Panfrost one. This matches what Iris does. Fixes crash in test_integer_ops.int_math on Panfrost. Fixes: 0fcf73bc ("panfrost: Move to use ralloc for some allocations") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17234> (cherry picked from commit f18492fa)
-
Dylan Baker authored
-
Dylan Baker authored
I don't know why they're suddenly passing, but not gonna complain
-
- Jun 27, 2022
-
-
Otherwise passes which expect offsets to be in bytes (like brw_nir_lower_mem_access_bit_sizes, called from brw_postprocess_nir) may produce incorrect results. Fixes 64-bit load/stores in task/mesh shaders. Fixes: c36ae42e ("intel/compiler: Use nir_var_mem_task_payload") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!16196> (cherry picked from commit 42b551fe)
-
Fixes: c93cbc77 ("intel/common: Add helper for URB allocation in Mesh pipeline") Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!16196> (cherry picked from commit 3dc6a98d)
-
Blorp emits its own 3DSTATE_DEPTH_BOUNDS, so we'll have to re-emit the expected state after that. Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Fixes: 56ef501e ("blorp: disable depth bounds") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!17205> (cherry picked from commit 3f6edbc7)
-
packed_instr::tex::dest must be last to match the packed_instr::any::dest position. Fixes: 35655865 ("nir/serialize: pack instructions better") Cc: stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17212> (cherry picked from commit ee536ea6)
-
Dylan Baker authored
-
- Jun 24, 2022
-
-
these must only be incremented if the image descriptor has changed cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17192> (cherry picked from commit 74dd6e69)
-
This change is pretty straightforward: if set this field when we don't emit the blend state, then the garbage at offset=0 will be set as a blend state, and this will cause artifacts until the proper blend state will be given. Cc: mesa-stable Closes: mesa/mesa#6544 Closes: mesa/mesa#6232 Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Reviewed-by: Nanley Chery <nanley.g.chery@intel.com> Part-of: <mesa/mesa!17132> (cherry picked from commit 318473ea)
-
CC: 22.1 22.0 <mesa-stable> Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Closes: mesa/mesa#1326 Part-of: <mesa/mesa!17199> (cherry picked from commit e060d98a)
-
GL_MAP_UNSYNCHRONIZED_BIT depends on the app having its threading handled correctly. This allows us to force disable the bit when they get it wrong. CC: 22.1 22.0 <mesa-stable> Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17199> (cherry picked from commit 5f686bfc)
-
these values should have all been set during pipeline compositing above, so reapplying the values is at best, redundant, and at worst, broken cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17219> (cherry picked from commit b74d3e71)
-
only the viewMask parameter of VkPipelineRenderingCreateInfoKHR can be accessed in the fragment stage, so for pipeline libraries it should be assumed that zs attachments exist for the purpose of copying dynamic state values, and then these dynamic states will naturally be pruned during final pipeline construction if the attachments turn out to not be present cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17219> (cherry picked from commit 2a69aeb9)
-
also add some unreachable() handlers for unknown types cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17219> (cherry picked from commit 7018b630)
-
The modifiers are u_vectors, but the code was trying to access them as dynarrays. This resulted in a wrong number of modifiers, which then later on would also lead to invalid reads used as modifiers. In the case of the iris driver, a wrongly read number of modifiers > 0 would also trigger an error message. Closes: mesa/mesa#6643 Fixes: b5848b2d ("egl/wayland: use surface dma-buf feedback to allocate surface buffers") Reviewed-by: Leandro Ribeiro <leandro.ribeiro@collabora.com> Reviewed-by: Simon Ser <contact@emersion.fr> Part-of: <mesa/mesa!17180> (cherry picked from commit f50fe9b0)
-
Dylan Baker authored
-
- Jun 23, 2022
-
-
This reverts commit 44a20bae. Signed-off-by: Renato Pereyra <renatopereyra@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!17118>
-
This reverts commit 24049b87. Signed-off-by: Renato Pereyra <renatopereyra@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!17118>
-
Dylan Baker authored
-
Not doing so crates skews occlusion queries. Fixes Zink's piglit occlusion_query tests. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: a4f502de ("anv: fix VK_DYNAMIC_STATE_COLOR_WRITE_ENABLE_EXT state") Closes: mesa/mesa#6205 Reviewed-by: Emma Anholt <emma@anholt.net> Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!15740> (cherry picked from commit 5d05ffa4)
-
For example, the proof for this pattern (('bcsel', ('flt', 'a@32', 0), 'b@32', 'c@32'), ('fcsel_ge', a, c, b)), would be bcsel(a < 0, b, c) bcsel(!(a < 0), c, b) bcsel(a >= 0, c, b) fcsel_ge(a, c, b) However, !(a < 0) => (a >= 0) is well known to produce different results if `a` is NaN. Instead of that replacement, use this replacement: bcsel(a < 0, b, c) bcsel(-0 < -a, b, c) bcsel(0 < -a, b, c) fcsel_gt(-a, b, c) This is NaN-safe and exact. Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Fixes: 0f5b3c37 ("nir: Add opcodes for fused comp + csel and optimizations") Part-of: <mesa/mesa!17048> (cherry picked from commit a2a2fbc5)
-
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Noticed-by: Georg Lehmann <dadschoorse@gmail.com> Fixes: 0f5b3c37 ("nir: Add opcodes for fused comp + csel and optimizations") Part-of: <mesa/mesa!17048> (cherry picked from commit ccd18ec4)
-
Fixes: 54221167 ("turnip: enable VK_EXT_line_rasterization") Part-of: <mesa/mesa!17190> (cherry picked from commit d4558380) Conflicts: src/gallium/drivers/zink/ci/zink-tu-a630-fails.txt CI file doesn't exist in 22.1, and has been deleted
-
This was missing, and the added validation caught it. Fixes: 708c47e6 ("nir: Validate nir_tex_instr::dest_type bitsize") Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!17172> (cherry picked from commit 4309e09d)
-
point size min/max values are provided through the state vars, so ensure these are always applied in order to respect ARB_point_parameters cc: mesa-stable Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!17145> (cherry picked from commit 4830cc77)
-
As it turns out, MOVs weren't the only instructions that blocked precise flags propagation in the transition to nir-to-tgsi. This commit fixes some rendering regressions caused by a4a34cd3. Fixes: a4a34cd3 Signed-off-by: Italo Nicola <italonicola@collabora.com> Reviewed-by: Gert Wollny <gert.wollny@collanora.com> Part-of: <mesa/mesa!17144> (cherry picked from commit 42a12649)
-
This was noticed as a problem in the EGL code, just fixup wsi. Cc: mesa-stable Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!17155> (cherry picked from commit d3e723fb)
-
These might not be required but be consistent with the wsi code. Cc: mesa-stable Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!17155> (cherry picked from commit c5dbb113)
-
wezterm in fullscreen 4k was exceeding the xcb max request size on the put image with llvmpipe. This fixes it to send sub-images, the Xlib put image used in glx does this internally, but not the xcb one, so just do it in sections here. Cc: mesa-stable Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!17155> (cherry picked from commit e6082ac6)
-
not sure when this broke but it broke cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17156> (cherry picked from commit e8fc5cca)
-
this forces surface resize as expected cc: mesa-stable fixes #6706 Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!17147> (cherry picked from commit ea005c9e)
-
cc: mesa-stable Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!17147> (cherry picked from commit 23b63e53)
-