- Jan 20, 2021
-
-
Dylan Baker authored
-
v_or_b32 with a v2b definition should use SDWA if is_partial=true. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Fixes: 56345b8c ("aco: allow reading/writing upper halves/bytes when possible") Part-of: <mesa/mesa!8577> (cherry picked from commit fcda9b67)
-
Ported from PAL. Fixes: 07c1504d ("radeonsi: implement SQTT support") Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!8480> (cherry picked from commit 41d22eb6)
-
This restores the previous logic because L2 coherency was fully implemented. It appears that flushing L2 metadata with a CS_DONE event hangs. This fixes GPU hangs with Monster Hunter World. Fixes: 4a783a3c ("radv: Use L2 coherency on GFX9+.") Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!8566> (cherry picked from commit c3ac6f7c)
-
If software decompression is used for ETC2, the alpha channel for sRGB8 textures would be set only if BGRA is true. Fixes: e5604ef7 "st/mesa/i965: Allow decompressing ETC2 to GL_RGBA" Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <!8529> (cherry picked from commit 290dcb26)
-
It is now valid for a node to have an index of zero. Fixes: 39aa8c4a ("pan/bi: Switch to new IR") Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!8358> (cherry picked from commit 5eb39dd9)
-
Fixes: 1893a380 ("pan/bi: Generate instruction printer") Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!8358> (cherry picked from commit a63960b7)
-
Fixes: 39aa8c4a ("pan/bi: Switch to new IR") Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!8358> (cherry picked from commit 3a16ab84)
-
Fixes: 9c7efc45 ("pan/bi: Add intrinsic emits for builder") Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!8358> (cherry picked from commit 92461a11) Conflicts: src/panfrost/bifrost/bifrost_compile.c
-
Add the tls_size from NIR before spilling so that it doesn't alias with spill slots. Fixes: 152bc5d1 ("pan/mdg: Support loads and stores to scratch memory") Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!8358> (cherry picked from commit a8c91f15)
-
Fixes: cbdc00ac ("nouveau: fix handling draw info") Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <!8539> (cherry picked from commit 087ef91c)
-
The min/max indices are valid. Set the bit to true to indicate that. Fixes glClear (+ clear_with_quads) on nouveau. Fixes: 72ff5309 (gallium: add pipe_draw_info::index_bounds_valid) Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reported-by:
Simon Ser <contact@emersion.fr> Tested-by:
Simon Ser <contact@emersion.fr> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!8546> (cherry picked from commit 111c0733)
-
Passing NULL for the views parameter should be the same as passing an array of NULL, according to the documentation. So let's respect that detail. This fixes a crash when using GALLIUM_HUD. Fixes: 8d46e35d ("zink: introduce opengl over vulkan") Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!8564> (cherry picked from commit 33373040)
-
Otherwise the offset might not match between the images that are aliased. Fixes: e553ea51 ("radv: Create sparse images.") Closes: #4072 Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!8535> (cherry picked from commit af1aef10)
-
get_screen_resources may trigger an active probe of display connections in the X server, which may take significant time and/or result in log file spam. Fixes: b5268d53 "wsi/x11: Detect Xwayland" Reported-by:
Sylvain Bertrand <sylvain.bertrand@legeek.net> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!8492> (cherry picked from commit 23f2e777)
-
This limits the exposure of these functions to when the extension is available. Prevents crashes otherwise, as the rest of the infrastructure doesn't necessarily expect these functions when the extension is not available. Fixes: 40c1f988 ("mesa,glsl: add support for GL_NV_shader_atomic_int64") Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!8533> (cherry picked from commit a0f4affc)
-
Used the wrong offset & pitch for gfx9. Fixes: 50bafb85 ("ac/surf: Add sparse texture info to radeon_surf.") Closes: #4072 Acked-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!8526> (cherry picked from commit c28469ba)
-
I missed two parts of the APIs for this, so add them, should fix crashes in gstreamer vulkan when it tries to load lvp. Cc: <mesa-stable@lists.freedesktop.org> Closes: #3989 Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <!8511> (cherry picked from commit 7b48d5d3)
-
- Jan 19, 2021
-
-
Fixes: bef3fedc ("pan/bi: Lower 8bit fragment outputs to 16bit") Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reported-by: Coverity Reviewed-by:
Boris Brezillon <boris.brezillon@collabora.com> Part-of: <mesa/mesa!8489> (cherry picked from commit 81becaa6)
-
The vulkan loader doesn't load layers for apps that require a newer version of vulkan, so this layer didn't get loaded for vulkan 1.2 apps. I would like to just stick 1.09 in there but it might be worth validating it works at new version of vulkan I suppose and the major doesn't revise that often Fixes: 9bc5b2d1 ("vulkan: add initial device selection layer. (v6)") Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!8508> (cherry picked from commit ca834d0b)
-
../src/util/u_debug_stack.c:97:20: error: incompatible pointer to integer conversion assigning to 'unw_word_t' (aka 'unsigned long') from 'void *' [-Werror,-Wint-conversion] pip.unwind_info = NULL; ^ ~~~~ 1 error generated. Fixes: 70c27200 "gallium/util: libunwind support" Closes: mesa/mesa#4094 Signed-off-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com> Part-of: <mesa/mesa!8507> (cherry picked from commit 08ac7b52)
-
Avoids regressing KHR-GL33.packed_pixels.pbo_rectangle.* when transitioning from mesa/main pack/unpack codegen to util/format's. Fixes: b28eb044 ("gallium: Add equivalents of packed MESA_FORMAT_*UINT formats.") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <!6297> (cherry picked from commit e5e75b71)
-
Dylan Baker authored
-
- Jan 15, 2021
-
-
So far we only write a maximum of 4 dwords further into the batch and it seems just going over the CS prefetch was enough. Turns out writing more dwords can delay the writes and we start prefetching stuff that hasn't landed in memory yet. This fixes the issue by stalling the CS to ensure the writes have landed before we go over the prefetch. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 796fccce ("intel/mi-builder: add framework for self modifying batches") Reviewed-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <mesa/mesa!8525> (cherry picked from commit d8154c40)
-
It is using the source level instead of the destiny level (base_level) to compute the dest offset. This fixes `framebuffer-blit-levels draw rgba -auto -fbo` piglit test. Fixes: 976ea90b ("v3d: Add support for using the TFU to do some blits.") Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!8491> (cherry picked from commit 08b16cfe)
-
Fixes the following building errors: FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so ... ld.lld: error: undefined symbol: r600::r600_nir_split_64bit_io(nir_shader*) >>> referenced by sfn_nir.cpp:981 (external/mesa/src/gallium/drivers/r600/sfn/sfn_nir.cpp:981) ... ld.lld: error: undefined symbol: r600::r600_nir_64_to_vec2(nir_shader*) >>> referenced by sfn_nir.cpp:1010 (external/mesa/src/gallium/drivers/r600/sfn/sfn_nir.cpp:1010) ... ld.lld: error: undefined symbol: r600::r600_merge_vec2_stores(nir_shader*) >>> referenced by sfn_nir.cpp:1015 (external/mesa/src/gallium/drivers/r600/sfn/sfn_nir.cpp:1015) Fixes: 165fb511 ("r600/sfn: add lowering passes to get 64 bit ops lowered to 32 bit vec2") Cc: 21.0 <mesa-stable> Signed-off-by:
Mauro Rossi <issor.oruam@gmail.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!8505> (cherry picked from commit 4bc9f7d5)
-
The flush VA space was only allocated for command buffers on the graphics queue. Also, the ZPASS_DONE event should never be emitted on compute queues because it hangs. Invalidating the L2 metadata cache is only required for coherency between the RBs and L2, so only on the graphics queue. The L2 cache is invalidated at beginning of any IBs and that should also invalidate the L2 metadata cache for compute anyways. Fixes: 4a783a3c ("radv: Use L2 coherency on GFX9+.") Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!8494> (cherry picked from commit c6849f96)
-
This should fix crashing piglit tests on the i915 classic driver. Fixes: 2358da81 - mesa: switch (Multi)DrawArrays to DrawGallium Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!8453> (cherry picked from commit 39c415d5)
-
Reported-by: Yugang Fan Fixes: cd3251d6 ("intel/iris: Build gen 12.5") Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!8426> (cherry picked from commit fc1bd69b)
-
Fixes black screen in some FNA games. Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#3431 Signed-off-by:
Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Reviewed-by:
Nanley Chery <nanley.g.chery@intel.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!7218> (cherry picked from commit 0c08a66c)
-
Dylan Baker authored
-
- Jan 14, 2021
-
-
If we don't tag compute sgpr as dirty they will point to the ol buffer location. This fixes arb_compute_shader-dlist with mcbp enabled. Fixes: 85a6bcca ("radeonsi: pass at most 3 images and/or shader buffers via user SGPRs for compute") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!8433> (cherry picked from commit 17f8e56c)
-
We sometimes use anv_layout_to_aux_state() to compute the aux state of an image during the resolve operations at the end of a render (sub)pass. If we're dealing with a multisampled image that is created without a transfer usage, our internal code might trigger a resolve using the transfer layout (see genX_cmd_buffer.c:cmd_buffer_end_subpass), for which the image doesn't the usage bit. The current code tries to AND the 2 usages which won't have any bit in common, thus skipping all checks below. v2: Add the transfer usages depending on attachment usage (Lionel) v3: Limit to samples > 1 (Jason) && DEPTH_STENCIL_ATTACHMENT_BIT (Lionel) v4: Add transfer usage at image creation (Jason) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 54b525ca ("anv: Rework anv_layout_to_aux_state") Closes: #4037 Reviewed-by: Reviewed-by: Tapani Pälli <tapani.palli@intel.com> (v1) Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!8307> (cherry picked from commit d4b4d69d)
-
Closes: mesa/mesa#4055 Fixes: b38879f8 Part-of: <mesa/mesa!8377> (cherry picked from commit 9c54928f)
-
Dylan Baker authored
-
- Jan 13, 2021
-
-
Significantly improves performance of a Control compute shader. Also seems to increase FPS at the very start of the game by ~5% (RX 580, 1080p, medium settings, no MSAA). fossil-db (Sienna): Totals from 81 (0.06% of 139391) affected shaders: SGPRs: 3848 -> 4362 (+13.36%); split: -0.99%, +14.35% VGPRs: 4132 -> 4648 (+12.49%) CodeSize: 275532 -> 659188 (+139.24%) MaxWaves: 986 -> 906 (-8.11%) Instrs: 54422 -> 126865 (+133.11%) Cycles: 1057240 -> 750464 (-29.02%); split: -42.61%, +13.60% VMEM: 26507 -> 61829 (+133.26%); split: +135.56%, -2.30% SMEM: 4748 -> 5895 (+24.16%); split: +31.47%, -7.31% VClause: 1933 -> 6802 (+251.89%); split: -0.72%, +252.61% SClause: 1179 -> 1810 (+53.52%); split: -3.14%, +56.66% Branches: 1174 -> 1157 (-1.45%); split: -23.94%, +22.49% PreVGPRs: 3219 -> 3387 (+5.22%); split: -0.96%, +6.18% Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!6538> (cherry picked from commit dfe429eb)
-
Totals from 18436 (13.23% of 139391) affected shaders (NAVI10): CodeSize: 138428504 -> 138172588 (-0.18%) Instrs: 26605127 -> 26541176 (-0.24%) Cycles: 1624994088 -> 1622461620 (-0.16%) VMEM: 3689892 -> 3689102 (-0.02%) SMEM: 1131767 -> 1131761 (-0.00%) Branches: 851796 -> 787852 (-7.51%) Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <!7814> (cherry picked from commit 288032a8)
-
Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6680> (cherry picked from commit 412291dd)
-
Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6680> (cherry picked from commit 6ecbccfb)
-
Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6680> (cherry picked from commit b03be30e)
-