Skip to content

anv: consider transfer usage for color/depth/stencil attachments

Lionel Landwerlin requested to merge llandwerlin/mesa:review/anv-aux-layout-implicit-resolve-fix into master

anv: consider transfer usage for color/depth/stencil attachments

We sometimes use anv_layout_to_aux_state() to compute the aux state of an image during the resolve operations at the end of a render (sub)pass.

If we're dealing with a multisampled image that is created without a transfer usage, our internal code might trigger a resolve using the transfer layout (see genX_cmd_buffer.c:cmd_buffer_end_subpass), for which the image doesn't the usage bit. The current code tries to AND the 2 usages which won't have any bit in common, thus skipping all checks below.

v2: Add the transfer usages depending on attachment usage (Lionel)

Signed-off-by: Lionel Landwerlin lionel.g.landwerlin@intel.com Fixes: 54b525ca ("anv: Rework anv_layout_to_aux_state") Closes: #4037 (closed)

Edited by Lionel Landwerlin

Merge request reports