- Dec 03, 2020
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Dec 02, 2020
-
-
Cc: mesa-stable Reviewed-by:
Rob Clark <robdclark@chromium.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit daaf5f1d)
-
llvmpipe was reporting 32 max const buffers, while sizing its arrays to 16 according to gallivm's #define. Fixes: 1d35f772 ("gallivm,llvmpipe,draw: Support multiple constant buffers.") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit d90107a2)
-
Cc: mesa-stable Reviewed-by:
Rob Clark <robdclark@chromium.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit 634384e4)
-
Fixes: d1465b3a ("freedreno: use u_transfer_helper") Reviewed-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!7695> (cherry picked from commit 9cc8fc7b)
-
Fixes: 8a05d6ff ("driconf: Make the driver's declarations be structs instead of XML.") Reviewed-by:
Rob Clark <robdclark@chromium.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit 0626e3a9)
-
This is only required for the DRI-path. For the swrast code-path, we don't need this. We also don't need to explicitly test for it in the DRI-path, because we test for KHR_external_memory_fd, which depends on KHR_external_memory. So no implementation will expose the former without the latter. Fixes: f1432fd3 ("zink: generate extension infrastructure using a python script") Reviewed-by:
Hoe Hao Cheng <haochengho12907@gmail.com> Part-of: <mesa/mesa!7882> (cherry picked from commit 59a6705c)
-
computerator depends on ir3_parser.h, which is a generated file, but this dependency is not expressed in the build. Fixes: 1e8808a4 ("freedreno/ir3: refactor out helper to compile shader from asm") Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!7870> (cherry picked from commit 9eee4054)
-
Fixes: fa97061a ("radv/winsys: Add binary syncobj ABI changes for timeline semaphores.") Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7866> (cherry picked from commit 6ec0953e)
-
I think that reducing the CU mask to 1 disabled CU per SA broke the WGP mode on VanGogh, causing a hang. To be sure, disable it on all chips. Fixes: 9538b9a6 - radeonsi: add support for Sienna Cichlid Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7721> (cherry picked from commit 69c927de)
-
If you did: si_pm4_set_reg(pm4, reg, val0); si_pm4_cmd_add(pm4, val1); si_pm4 set_reg(pm4, reg + 4, val1); it wrote val0 to reg, val1 to reg + 4, and val2 to reg + 8. This fixes it by clearing last_opcode in si_pm4_cmd_add, so that si_pm4_set_reg doesn't try to combine set_reg calls across si_pm4_cmd_add. Fixes: da78d50b - radeonsi: make si_pm4_cmd_begin/end static and simplify all usages Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7721> (cherry picked from commit 0d4f1dcd)
-
Fixes: 1f213964 - radeonsi: add support for displayable DCC for multi-RB chips Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7721> (cherry picked from commit e64d5cc4)
-
Dylan Baker authored
- Dec 01, 2020
-
-
In commit 00b28a50, Marek extended a number of optimizations that had been 32-bit specific to work on other bit-sizes. Most optimizations preserve the data type across the transformation. In other words, an optimization which generates e.g. fp64 operations only does so when the source expression also contains fp64 operations. These transformations are fine with respect to lowering, because we will lower away all expressions that would trigger the search portion of the expression, and so we'd never apply those rules. However, a few of the rules create new operations that run afoul of lowering passes. For example, ('bcsel', a, 1.0, 0.0) => ('b2f', a) where the result is a double would simply be a selection between two different 64-bit constants. The replacement expression, on the other hand, involves a nir_op_b2f64 ALU operation. If we're run after nir_lower_doubles, then it may not be legal to generate such an expression anymore (at least without running lowering again, which we don't do today). Regressions due to this are blocking the 20.3 release, so for now, we take the easy route and simply disallow those few rules when doing full softfp64 lowering, which fixes the immediate problem. But it doesn't solve the long-term problem in an extensible manner. In the future, we may want to add a `lowered_alu_ops` bitfield to the NIR shader, and as lowering passes are run, mark them as taboo. Then, we could have each algebraic transformation track which operations it creates in the replacement expression. With both of those in place, nir_replace_instr could compare the transformation's list of ALU ops against `lowered_alu_ops` and implicitly skip rules that generate forbidden ALU operations. Closes: mesa/mesa#3504 Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!7841> (cherry picked from commit 531843cf)
-
There was a temp which was defined in a branch but used outside, without a phi. Fixes: 62b5012e Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!7817> (cherry picked from commit 94f8cb29)
-
Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Lucas Stach <l.stach@pengutronix.de> Part-of: <!7832> (cherry picked from commit aad0c7c6)
-
Fixes: 584f2732 - st/mesa: factor ucp-lowering logic into helper Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!6946> (cherry picked from commit fdd3a448)
-
Fixes: 9545139c "mesa: skip FLUSH_VERTICES() if no samplers were changed" Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Part-of: <!6946> (cherry picked from commit 0a2117bc)
-
Fixes: 4cce4d22 ("radv: Fix a hang on CB change by adding flushes.") Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7813> (cherry picked from commit aed8d30b)
-
Fixes: 18e97817 r600/sfn: Use load_ubo_vec4 lowering pass Signed-off-by:
Gert Wollny <gert.wollny@collabora.com> Part-of: <!7715> (cherry picked from commit c41d0d0c)
-
This workaround fixes a hang while loading a renderdoc trace for me. Since the workload does 1 mip per cmdbuffer it is quite hard to confirm what exactly the conditions for the hang are but this is the most restrictive set I found and it corresponds to a workaround in AMDVLK as well. CC: mesa-stable Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7210> (cherry picked from commit 4cce4d22)
-
We forgot to document this previously, so let's add it now. Fixes: feb9462b ("zink: Added inbuilt debug logging from the VK_LAYER_LUNARG_standard_validation layer.") Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!7802> (cherry picked from commit 85647152)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Fixes: deaebc82 "nir: Add load_sampler_lod_paramaters_pan intrinsic" Part-of: <mesa/mesa!6587> (cherry picked from commit f6407b9b)
-
Fixes KHR-GL31.texture_size_promotion.functional Fixes: e4974852 Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <!7792> (cherry picked from commit a569ffeb)
-
Quoting the spec : "When a pool is destroyed, all descriptor sets allocated from the pool are implicitly freed and become invalid. Descriptor sets allocated from a given pool do not need to be freed before destroying that descriptor pool." This implies we might leak nodes allocated in the vma object. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 0a6d2593 ("anv: Allocate descriptor buffers from the BO cache") Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!7796> (cherry picked from commit 5d55ca9c)
-
Not every p_cbranch uses the SCC, but our optimizer thought so. Fixes: 8a32f57f Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!7677> (cherry picked from commit 8bd3fefb)
-
It fixes the following valgrind issue: ==141996== Invalid read of size 4 ==141996== at 0x61F8806: gl_nir_link_uniforms (gl_nir_link_uniforms.c:1788) ==141996== by 0x60F17AA: gl_nir_link_glsl (gl_nir_linker.c:672) ==141996== by 0x5C1AEDF: st_link_nir (st_glsl_to_nir.cpp:739) ==141996== by 0x5C15574: st_link_shader (st_glsl_to_ir.cpp:172) ==141996== by 0x5C673B0: _mesa_glsl_link_shader (ir_to_mesa.cpp:3117) ==141996== by 0x5E7B61C: link_program (shaderapi.c:1311) ==141996== by 0x5E7B61C: link_program_error (shaderapi.c:1419) ==141996== by 0x5E7CF8A: _mesa_LinkProgram (shaderapi.c:1911) ==141996== by 0x4923D13: stub_glLinkProgram (piglit-dispatch-gen.c:33956) ==141996== by 0x1142C0: link_and_use_shaders (shader_runner.c:1636) ==141996== by 0x1205A6: init_test (shader_runner.c:5347) ==141996== by 0x121555: piglit_init (shader_runner.c:5725) ==141996== by 0x4991C84: run_test (piglit_fbo_framework.c:50) It can be reproduced on `iris` using the following piglit test: instance-matching-shader-storage-blocks-align-qualifier-mismatch.shader_test Closes: #3818 Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Fixes: 47c35823 ("glsl: fix up location setting for variables pointing to a UBO's base") Signed-off-by:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Signed-off-by:
Andrii Simiklit <andrii.simiklit@globallogic.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7376> (cherry picked from commit a941618a)
-
with a sequence like this: glClear(STENCIL) glBeginTransformFeedback() ... glEndTransformFeedback() glClear(STENCIL) The second clear sometimes may produce an unexpected result. Calling si_flush_gfx_cs() when doing ngg -> legacy transition seems to be a valid workaround (both for the synthetic reproducer and the real Blender bug). Using flush flags or events (BOTTOM_OF_PIPE_TS, RESET_TO_LOWEST_VGT) didn't help. Closes: mesa/mesa#2941 Cc: mesa-stable Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7750> (cherry picked from commit 0b3bd7c5)
-
It should only recurse if there's enough space to add the phi sources. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Fixes: 72ac3f60 ("nir: add nir_unsigned_upper_bound and nir_addition_might_overflow") Part-of: <mesa/mesa!7748> (cherry picked from commit 65fbae16)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: 57c152af ("aco: select v_mul_{hi}_u32_u24 for 24-bit multiplications") Closes: mesa/mesa#3874 Part-of: <mesa/mesa!7759> (cherry picked from commit cf0b54cd)
-
Dylan Baker authored
-
- Nov 30, 2020
-
-
Dylan Baker authored
-
- Nov 25, 2020
-
-
Dylan Baker authored
It's borken ATM in general (not just on 20.3), and we want to kep the CI green. Once it's fixed we'll turn it back on.
-
Fixes: e893102b ("radv: Add VK_FORMAT_E5B9G9R9_UFLOAT_PACK32 rendering support.") Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7716> (cherry picked from commit 025cb900)
-
Fixes: 886d2d1a "spirv: Handle SpvOpTerminateInvocation" Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <!7734> (cherry picked from commit 66685679)
-
Vulkan can't scale while resolving using vkCmdResolveImage. For this we need to use util_blitter. The reason this wasn't a problem in the past, was that glBlitFramebuffer always set pipe_blit_info::render_condition_enable, and we always used that to bail out to util_blitter. When the latter changed, this broke. Fixes: 19906022 ("zink: more accurately track supported blits") Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!7745> (cherry picked from commit c0286fc0)
-
Marek pointed this out, not sure how we missed it. Fixes: 3dc6da1a ("gallium: add a non-multisample sample mask out behaviour flag.") Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!7741> (cherry picked from commit 105fc1c6)
-
These pass CTS, but I think are missing some stuff CTS doesn't test. This is one of the base Vulkan 1.0 features and I'd like to support it for conformance. Cc: "20.3" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7705> (cherry picked from commit 87c70f19)
-