- Aug 11, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
- Aug 10, 2021
-
-
Eric Engestrom authored
With our ff-only merge setup, the commit date ends up being when the commit actually landed (as opposed to when it was first written). Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Dylan Baker <dylan@pnwbakers.com> Cc: mesa-stable Part-of: <mesa/mesa!12289> (cherry picked from commit 4128acde)
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Dylan Baker <dylan@pnwbakers.com> Cc: mesa-stable Part-of: <mesa/mesa!12289> (cherry picked from commit 7ec42b5e)
-
Eric Engestrom authored
Let's just make it not-optional instead. Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Dylan Baker <dylan@pnwbakers.com> Cc: mesa-stable Part-of: <mesa/mesa!12289> (cherry picked from commit db14f2a9)
-
Fixes: fb29cef8 ("nir: add many passes that lower and optimize 16-bit input/outputs and samplers") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!11732> (cherry picked from commit 9b57a818)
-
Otherwise drivers that don't use 16-bit slots for varyings will get confused and have their driver_locations scribbled over. This has caused multiple problems for both Panfrost and Asahi this week. Given the only other user of the pass for varyings is radeonsi, which needs both together, I think this is the least controversial fix. Fixes: fb29cef8 ("nir: add many passes that lower and optimize 16-bit input/outputs and samplers") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!11732> (cherry picked from commit 03c18f7e)
-
v2: intialize test_val in constructor Closes: mesa/mesa#5185 Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com> Cc: mesa-stable Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!12234> (cherry picked from commit bdae3c36)
-
By creating the KMS side handles we allow GBM to return the proper KMS side GEM handles for imported buffers. Always creating the KMS side handles adds a bit of overhead, as we don't need them on all imported resources, but seems like the most robust solution for now. Cc: mesa-stable Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Simon Ser <contact@emersion.fr> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!12018> (cherry picked from commit 826f9577)
-
There are a number of drivers which do a trial-and-error import of buffers into the KMS side via renderonly. Some of those imports are expected to fail, so we should not print a error message in this case. All callers do proper error handling themselves. Cc: mesa-stable Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Simon Ser <contact@emersion.fr> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!12018> (cherry picked from commit 1bc22a2e)
-
Eric Engestrom authored
-
- Aug 09, 2021
-
-
In the compute dispatch path we do not allocate a huge amount of space to cover everything so the individual functions have to allocate. This was missing here, causing a hang in Cyberpunk when accessing the system menu at some locations with thread tracing enabled. Fixes: bd118657 ("radv: add support for push constants inlining when possible") Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!12271> (cherry picked from commit 02b60159)
-
If "a" is a multiple of "b", then the result would have been "b" instead of 0. No fossil-db changes. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Fixes: 0ef5f355 ("nir: add strength reduction pattern for imod/irem with pow2 divisor.") Part-of: <mesa/mesa!12039> (cherry picked from commit ec4b425f)
-
If a shader has code like this: uniform float timestamp; ... if (timestamp > 0.0) do_something() And timestamp is modified each frame, we'll end up generating a new variant per frame. This commit introduces a hard limit on the number of variants we generate for a single shader. Closes: mesa/mesa#5121 Fixes: b7501184 ("radeonsi: implement inlinable uniforms") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12138> (cherry picked from commit 9fe8ae3f)
-
Eric Engestrom authored
-
Eric Engestrom authored
-
The flock is per-fd, not per thread, and we do it outside of the main mutex. This was done to avoid having to wait in the mutex, but we can get a case where one ends up running the body with the flock unlocked. Fix this by adding a mutex that doesn't need to be locked for reads. Fixes: 4f0f8133 "util/fossilize_db: Do not lock the fossilize db permanently." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <!12266> (cherry picked from commit 30a359d6)
-
Fixes: 4f0f8133 "util/fossilize_db: Do not lock the fossilize db permanently." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12266> (cherry picked from commit 75266ee4)
-
For those 32-bit systems with 4G of cache. Fixes: 2ec1bff0 "util/fossilize_db: Split out reading the index." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12266> (cherry picked from commit 1c4dce1a)
-
Should void leaking entries on read failure. Fixes: 2ec1bff0 "util/fossilize_db: Split out reading the index." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12204> (cherry picked from commit d2d642cc)
-
Don't anticipate seeing any partial written headers but just in case we should probably wait on the lock to make sure whatever header was being written is finished being written. Fixes: 4f0f8133 "util/fossilize_db: Do not lock the fossilize db permanently." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12204> (cherry picked from commit 96bfefe8)
-
We should probably flush before we unlock the file again. Fixes: 4f0f8133 "util/fossilize_db: Do not lock the fossilize db permanently." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12204> (cherry picked from commit 30912770)
-
Otherwise we might restart reading from the middle of the entry. Fixes: 2ec1bff0 "util/fossilize_db: Split out reading the index." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12204> (cherry picked from commit 57ca0745)
-
If things went perfectly parsed_offset was never updated for the final entry and we'd seek_set to the start of the last entry. Is fun when appending to the file next. Fixes: 2ec1bff0 "util/fossilize_db: Split out reading the index." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12204> (cherry picked from commit 3c51a3aa)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Closes: mesa/mesa#5180 Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12217> (cherry picked from commit bc3c71b8)
-
Eric Engestrom authored
-
Eric Engestrom authored
-
- Aug 06, 2021
-
-
virgl doesn't yet support anisotropic filtering so don't advertise it. Fixes: a8987b88 ("virgl: add driver for virtio-gpu 3D (v2)") Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!11944> (cherry picked from commit e831c4a5)
-
The `argument::size` is supposed to represent the size of a pointer on the host and not on the device (for which argument::target_size` exists). v3: Use `sizeof(buf)` instead of `marg.size`. (Francisco Jerez) Fixes: 7c6f1d3b ("clover/nir: extract constant buffer into its own section") Reviewed-by: Francisco Jerez <currojerez@riseup.net> Signed-off-by: Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!10256> (cherry picked from commit b4e5bf06)
-
This resolves clover returning `CL_INVALID_ARG_SIZE` whenever the OpenCL CTS called `clSetKernelArg()` for 3-component vectors. Fixes: 21473865 ("clover/spirv: Add functions for parsing arguments, linking programs, etc.") v2: Remove “api/clsetkernelarg/set kernel argument for cl_int3” from the expected fails for llvmpipe Reviewed-by: Karol Herbst <kherbst@redhat.com> Signed-off-by: Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!10256> (cherry picked from commit a6c26a6a)
-
Most of the drivers don't set up the maximum value in the query info. So when later hud_pane_set_max_value() is invoked, we are using a rather "random" number. Turns out that in some 32bit cases, this random number is big enough that `leftmost_digit` is 0 because DIV_ROUND_UP() overflows, aborting with an assertion. Fixes: c91cf7d7 ("gallium: implement a heads-up display module") Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!12181> (cherry picked from commit 10541d1f)
-
Fixes: d26bcc0f ("radv: always select the first active CU when profiling with SQTT") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!12167> (cherry picked from commit ebea075f)
-
This fixes a hang in the following piglit test when GCM moves a UBO load outside of the loop. tests/shaders/ssa/fs-if-def-else-break.shader_test The end NIR ends up looking like this: vec2 32 ssa_3 = intrinsic load_ubo (ssa_2, ssa_0) (0, 1073741824, 0, 0, 8) vec1 32 ssa_4 = mov ssa_3.x vec1 32 ssa_5 = inot ssa_3.y /* succs: block_1 */ loop { ... if ssa_5 { } } Fixes: 1edf67fc ("intel/fs: Generate if instructions with inverted conditions") Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!12064> (cherry picked from commit a654e39f)
-
- Aug 04, 2021
-
-
Fixes: f1432fd3 ("zink: generate extension infrastructure using a python script") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!12137> (cherry picked from commit 86250c72)
-
The existing code handled the case where the new definition of the same field was larger than the old one. This commit adds a check to handle the reverse case: the new def is smaller than the old one (= so writing using the merged macro would affect the next fields). The affected fields are: * LGKM_CNT (in SQ_WAVE_IB_STS) * DONUT_SPLIT (in VGT_TESS_DISTRIBUTION) * HEAD_QUEUE (in GDS_GWS_RESOURCE) DONUT_SPLIT is the only one used by radeonsi/radv. Fixes: e6184b08 ("amd/registers: scripts for processing register descriptions in JSON") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12063> (cherry picked from commit 3914bd45)
-
Add 1 to the key index otherwise we hit the following assert in hash_table_insert: assert(!key_pointer_is_reserved(ht, key)); Cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12105> (cherry picked from commit 2ea88d7c)
-
Fixes crash in dEQP-GLES2.functional.uniform_api.random.79 Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12093> (cherry picked from commit c8783001)
-
Failure to create a buffer for scanout should not be fatal when importing a buffer. Buffers allocated from a render-only device may not be able to scanned out directly but can still be used for other rendering purposes (e.g. as a texture). Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Reviewed-by: Simon Ser <contact@emersion.fr> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Cc: mesa-stable Part-of: <mesa/mesa!12081> (cherry picked from commit 7bcb2236)
-
Hand typed. We could generate this from the XML to avoid the repititon but I think the cure is worse than the disease. This fixes instruction encoding faults seen in conformance tests. Only a single shader-db affected, and it was likely already broken... quadwords HURT: shaders/glmark/22-1.shader_test MESA_SHADER_FRAGMENT: 133 -> 135 (1.50%) Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!12114> (cherry picked from commit 2cdf9570)
-
The previous logic was returning a handle valid for the render-only device if rsc->scanout was NULL. However the caller doesn't expect this: the caller will use the handle with the KMS device. Instead of returning a handle for the wrong device, fail if we don't have one. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com> Cc: mesa-stable Part-of: <!12074> (cherry picked from commit 47f000c1)
-