Changes on tests may break --list-subtests, if they, for instance,
someone adds a code outside igt_subtests that depends on igt_fixture
to run, causing:

        Received signal SIGABRT.
        Stack trace:
         #0 [fatal_sig_handler+0x17b]
         #1 [__sigaction+0x50]
         #2 [__pthread_kill_implementation+0x10c]
         #3 [gsignal+0x16]
         #4 [abort+0xd7]
         #5 [__assert_fail_base.cold+0xf]
         #6 [__assert_fail+0x46]
         #7 [internal_assert+0xe5]
         #8 [igt_fail+0xea]
         #9 [__igt_fail_assert+0x10e]
         #10 [xe_number_hw_engines+0x6b]
         #11 [__igt_unique____real_main1528+0x1ac0]
         #12 [main+0x23]
         #13 [__libc_start_call_main+0x80]
         #14 [__libc_start_main+0x89]
         #15 [_start+0x25]
        Aborted (core dumped)

IGT runner currently prints the message, but don't ignore the
error. That prevents scripts to rely on the IGT testlist
output, as the list will miss subtests.

So, instead, return an error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Let's start with something simple that runs very quickly and is
currently passing reliably.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Philippe Lecluse <philippe.lecluse@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Add xe_reg tool which allows to manipulate Xe registers.

Sample use:

./xe_reg read --ring rcs0 --all
./xe_reg read --ring rcs0 EXECLIST_STATUS

At this moment rings rcs0 and bcs0 are supported.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Collaborative change of IGT Xe tests.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Philippe Lecluse <philippe.lecluse@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Rodrigo Vivi authored 2 years ago and Zbigniew Kempczyński committed 2 years ago

It will be useful so the tests can assert the expected
usage counter movement depending on the operation.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Xe, is a new driver for Intel GPUs that supports both integrated
and discrete platforms starting with Tiger Lake (first Intel Xe
Architecture).

Series was split to allow easier review. Library, drm uapi, tests,
tools and other were squashed according to code subject.

This patch introduces library used for Xe tests. As there's not
too trivial to calculate credits for squashed subjects full series
credits are:

Co-developed-by: Matthew Brost
[commits: 90 / lines changed: 12574]
Co-developed-by: Mauro Carvalho Chehab
[commits: 28 / lines changed: 1873]
Co-developed-by: Rodrigo Vivi
[commits: 15 / lines changed: 1317]
Co-developed-by: Jason Ekstrand
[commits: 14 / lines changed: 1418]
Co-developed-by: Francois Dugast
[commits: 8 / lines changed: 1082]
Co-developed-by: Philippe Lecluse
[commits: 6 / lines changed: 560]
Co-developed-by: Zbigniew Kempczyński
[commits: 4 / lines changed: 1091]
Co-developed-by: Matthew Auld
[commits: 3 / lines changed: 35]
Co-developed-by: Niranjana Vishwanathapura
[commits: 2 / lines changed: 66]
Co-developed-by: Maarten Lankhorst
[commits: 2 / lines changed: 774]
Co-developed-by: Ryszard Knop
[commits: 1 / lines changed: 12]
Co-developed-by: Thomas Hellström
[commits: 1 / lines changed: 12]
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Introduce uAPI contract for Xe IGT.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Philippe Lecluse <philippe.lecluse@intel.com>
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Test settings for pixel formats which are not supposing to be accepted.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

When results generation fails exit with code 3, it will help
to differentiate from failed exection at resume runs. Added
also some debug messages at different error points.

Cc: Petri Latvala <adrinael@adrinael.net>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Petri Latvala <adrinael@adrinael.net>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Zbigniew Kempczyński authored 2 years ago and Kamil Konieczny committed 2 years ago

Introducing intel_gpu_commands.h requires removing all conflicting
macros definitions with altering the code (mostly command length).

For all commands used in IGT but not in the kernel (yet) add
intel_gpu_commands_staging.h which will keep all commands used
here only. Next import of command macros might finish verbatim
copy + removing from staging in one commit to compile cleanly.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <adrinael@adrinael.net>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Zbigniew Kempczyński authored 2 years ago and Kamil Konieczny committed 2 years ago

Adding intel_gpu_commands.h requires to solve some name clashes.
Rename MFX_WAIT to HUC_MFX_WAIT to be consistent with other macros
in the huc code.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Zbigniew Kempczyński authored 2 years ago and Kamil Konieczny committed 2 years ago

i915 has nicely collected command macros in one file. We want to use
this pattern (file) and remove duplicated definitions. Unfortunately
command file uses includes which don't exists in userspace, so we
need to import minimal set of kernel includes to ensure we will have
verbatim copy in the future.

v2: Add comment about origin of linux/bitops.h file (Kamil)
    Provide local _AC() macro to avoid other const.h include (Kamil)

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <adrinael@adrinael.net>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Karolina Stolarek authored 2 years ago and Kamil Konieczny committed 2 years ago

Hangs in this test are undesirable, so don't allow them.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

hersen wu authored 2 years ago and Kamil Konieczny committed 2 years ago

amd_dp_dsc tests are skipped when output max value (n_outputs)
is fewer than pipe max value (n_pipes) because a pipe may not
be enabled, i.e. display->pipes[i].enable == false. As a result,
n_outputs should be used instead.

Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>

In full resolve mode of operation, source and destination have
to use the same tiling format. block-copy-inplace attempts to
decompress and detile in the same step, which is not possible.
Remove the subtest that tries to change the tiling format in-flight.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

Dump i915_pm_runtime_status in case of i915 device failed to runtime
suspend, it will dump the rpm wakeref tracking information which
will useful to debug the runtime pm issues.

v2:
- Use wait_for_suspended(). [Ashutosh]

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

i915 specific test is added to validate max source size. This
test is expected to return -EINVAL for platforms where we have
max source width 4096 whereas it will pass on platforms having
max source width 5120. We have created fb of size 5120x4320
(=size of source) and downscaled to 3840x2160(=size of dest).

On MTL(disp_ver=14), in dmesg we can see

[drm:skl_update_scaler [i915]] scaler_user index 0.0: src
5120x4320 dst 3840x2160 size is out of scaler range.

since max source width supported is 4096 whereas same test
will pass on ADLP(display_ver=13) since max source width
supported is 5120.

v2: -updated comment (JP)
    -not declare list of tests (JP)
    -fixed indentation (JP)
    -added i915_max_source_size_test() inside
     igt_subtest_group() (JP)
v3: -added restriction to run this test only when HDISPLAY=3840
v4: -remove inner loop (JP)
    -test for HDISPLAY >= 3840 (JP)
v5: -override mode with lowest vrefresh to avoid cdclk lim (JP)
v6: -add VDISPLAY check (JP)
    -add description for find_mode() (JP)
v7: -pipe does not need to be set twice for output in same commit
     (JP)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Minor fixes are done in the existing test.

v2: -indentation (JP)
    -added invalid_parameter_tests() inside igt_subtest_group
     macro (JP)
v3: -moved 2x-scaler-multi-pipe test in the end

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

struct can be reused to add more test cases.

v2: -don't declare list of lists[JP]

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Alan Previn Teres Alexi authored 2 years ago and Ashutosh Dixit committed 2 years ago

Subtest 'test_pxp_stale_buf_optout_execution' when run on its own,
could be executing without the PXP Arb session being alive. This
would result in the termination trigger to fail (when writing to
the pxp termination debugfs).

Create a background protected context to start the Arb session so
the simulated termination will succeed.

   v2: - use create_ctx_with_params instead of prepare_exec_assets
         for the background pxp context (Daniele)

Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Dump the new stuff from the backlight block:
- brightness_level
- brightness_min_level
- brightness_precision_bits
- hdr_dpcd_refresh_timeout

Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Real world VBTs keep fuzzing our decoder, this time with a legacy child
devices block #11 that has child_dev_size 0, leading to division by
zero. Check for it, and bail out early, both for legacy and current
child device blocks.

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Make igt_pm_dmc_loaded() more robust against changes in the debugfs
file. Read the entire contents of the file, at least with the current
output. Preserve logged output even if something gets added in front of
the file, and don't depend on exact length of the first line.

Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Vikas Srivastava authored 2 years ago and Priyanka Dandamudi committed 2 years ago

MTL and other platforms which are gen12 must use softpinning
instead of relocations so adding no reloc supoprt for MTL target.

Signed-off-by: Vikas Srivastava <vikas.srivastava@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

created framebuffer was uselessly painted black which just wasted
time from ci.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

created framebuffers were uselessly painted black which just wasted
time from ci.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Shrink subtest can end up with oom killing it. Create subprocess
and run it from there so it will at least get reported like:

dynamic child 0 pid:70254 died with signal 9, Killed
Subtest shrink: FAIL (23.906s)

dmesg reports:

[103335.337309] Out of memory: Killed process 70254 (i915_suspend)

Cc: Riana Tauro <riana.tauro@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>

If any of *-without-i915 subtests fails or skips for any reason, it may
leave the i915 module unloaded while keeping our device list populated
with initially collected data.  In a follow up igt_fixture section we then
try to reopen the device.  If the test has been executed with a device
filter specified, an attempt to open the device finds a matching entry
that belongs to the no longer existing device in that initially collected
device list, fails to stat() it, concludes that's because of the device
having been already open, and returns an error.  While that error,
triggered after subtests completion, doesn't affect results of the
subtest, reported by CI togethger with those results it is confusing to
users reviewing those reports.

Fix this issue by refreshing the potentially outdated device list before
continuing with drm_open_driver() if we've been called with a device
filter specified.

While being at it, add a comment that explains why we call
igt_devices_scan() from __igt_device_card_match() but don't force device
rescan, and emit a debug message if we fail in _is_already_opened() on
unsuccessful device stat().

v2: don't free the device list -- we can't tell if it has been populated,
    and igt_devices_free() fails if it hasn't,
  - commit message updated, description improved.

Subtest basic-s3-without-i915: FAIL (9.572s)
(i915_suspend:9050) drmtest-WARNING: card maching filter 0 is already opened
(i915_suspend:9050) drmtest-CRITICAL: Test abort in function drm_open_driver, file ../lib/drmtest.c:639:
(i915_suspend:9050) drmtest-CRITICAL: abort condition: fd < 0
(i915_suspend:9050) drmtest-CRITICAL: Last errno: 2, No such file or directory
(i915_suspend:9050) drmtest-CRITICAL: No known gpu found for chipset flags 0x1 (intel)
Test i915_suspend failed.
**** DEBUG ****
(i915_suspend:9050) drmtest-DEBUG: Looking for devices to open using filter 0: pci:vendor=intel,device=dg2
(i915_suspend:9050) drmtest-DEBUG: Filter matched /dev/dri/card0 | /dev/dri/renderD128
(i915_suspend:9050) drmtest-WARNING: card maching filter 0 is already opened
(i915_suspend:9050) drmtest-CRITICAL: Test abort in function drm_open_driver, file ../lib/drmtest.c:639:
(i915_suspend:9050) drmtest-CRITICAL: abort condition: fd < 0
(i915_suspend:9050) drmtest-CRITICAL: Last errno: 2, No such file or directory
(i915_suspend:9050) drmtest-CRITICAL: No known gpu found for chipset flags 0x1 (intel)
(i915_suspend:9050) igt_core-INFO: Stack trace:
(i915_suspend:9050) igt_core-INFO:   #0 ../lib/igt_core.c:2066 __igt_abort()
(i915_suspend:9050) igt_core-INFO:   #1 ../lib/drmtest.c:573 drm_open_driver()
(i915_suspend:9050) igt_core-INFO:   #2 ../tests/i915/i915_suspend.c:258 __igt_unique____real_main245()
(i915_suspend:9050) igt_core-INFO:   #3 ../tests/i915/i915_suspend.c:245 main()
(i915_suspend:9050) igt_core-INFO:   #4 ../sysdeps/nptl/libc_start_call_main.h:58 __libc_start_call_main()
(i915_suspend:9050) igt_core-INFO:   #5 ../csu/libc-start.c:128 __libc_start_main@@GLIBC_2.34()
(i915_suspend:9050) igt_core-INFO:   #6 [_start+0x2a]
****  END  ****

Fixes: f7aff600 ("tests/i915/i915_suspend: Disable d3cold_allowed for basic-s2idle-without-i915")
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Link: https://patchwork.freedesktop.org/patch/522501/


Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Remove local 64-bit hash and use common one defined in igt_map.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reduce code duplication by using common hash helpers from igt_map.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Creating igt_map requires hashing and comparing function. Common case
is using 32-bit (like fd, etc.) or 64-bit keys (offsets) so adding
such helpers reduces code duplication.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

For separate execution there is no risk we may reserve offset which is
still in use by some job. But for running bunch of allocator tests
which may be still on gpu such risk exists. To avoid failures on
grouped execution ensure for 'nopin' subtests gpu is idle first.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

This reverts commit e6bb684a.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>

After introducing the dynamic subtests, tests are getting timedout
on CI. This patch will partially reverts dynamic subtests to avoid
such timeouts.

Fixes: c02f0d48 (tests/kms_cursor_legacy: Convert tests to dynamic)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>

Negative test is added to ensure HDR is not enabled on
a non-HDR panel. Commit/modeset won't fail. However, in dmesg
we can find

[drm:drm_hdmi_infoframe_set_hdr_metadata [drm_display_helper]]
EOTF Not Supported

v2: -fixed nitpicks (Kamil)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Negative test is added in which HDR output metadata prop is
set with invalid sizes.

v2: -Fixed nitpicks (Kamil)
    -Add cleanup (Kamil)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

This test can work not only on render engines, as its current code
suggests, but also on compute class engines.  Add them to the set of
engine classes supported by the test, in case a future platform has only
those and no RCS available.

Suggested-by: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

This also adds coverage for codepaths related to reading back the
devcore file from sysfs, to help catch issues like
drm/msm#20



Signed-off-by: Rob Clark <robdclark@chromium.org>

Adds a test to various subtests to stress shrinker/eviction.  Various
subtests also add mmap and dma-buf mmap into the mix (the latter because
it uncovered a memory corruption bug due to page mappings not being
correctly shot down).

Signed-off-by: Rob Clark <robdclark@chromium.org>

Get rid of some copy/pasta and open coding of a common pattern, waiting
for GPU commands to complete.

Signed-off-by: Rob Clark <robdclark@chromium.org>