- Dec 16, 2020
-
-
Dylan Baker authored
-
Dylan Baker authored
-
The small DCE of the spiller only removes the original instructions of rematerialized variables in case they are unused. If a variable has been renamed, it cannot match any original instruction anymore. Thus, the lookup is then unnecessary and can be omitted. No fossil-db changes. Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!8055> (cherry picked from commit ef4101d6)
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
- Dec 15, 2020
-
-
same as gfx8-10 Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7055> (cherry picked from commit 205f1d79)
-
For GPUs using the radeon kernel driver, num_se was never getting initialised. Closes: mesa/mesa#3939 Fixes: f2977a16 ("ac: fix min/max_good_num_cu_per_sa on gfx10.3 with disabled SEs") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7954> (cherry picked from commit 7c075bae)
-
The DRM_RDWR flag is needed for mmap with PROT_WRITE to work. Cc: mesa-stable Signed-off-by: Robin Ole Heinemann <robin.ole.heinemann@gmail.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!8075> (cherry picked from commit df76963a)
-
Dylan Baker authored
-
- Dec 14, 2020
-
-
We can't write to an individual component in a function_temp vector, so we have to use vtn_variable_store() which does a load+insert+store. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Closes: mesa/mesa#3484 Cc: mesa-stable Part-of: <mesa/mesa!6231>
-
Fixes: 9538b9a6 - radeonsi: add support for Sienna Cichlid Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7542>
-
strstr returns a pointer to the needle sub-string within the haystack string if the latter contains the former, or NULL otherwise. So this essentially always set info->is_pro_graphics = true, since probably no marketing name ever contains all of these sub-strings. Fixes: b635dff2 "ac: fix detection of Pro graphics" Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7675>
-
Fixes: bfb92875 "ac: add radeon_info::is_pro_graphics" Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7542>
-
Fixes: 3da91b33 - radeonsi/ngg: add VGT_FLUSH when enabling fast launch Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7542>
-
Otherwise FMASK metadata segfaults and on import we disable it ... CC: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!7358>
-
If we don't have a non-visible VRAM heap, we should be counting our non-visible VRAM allocations to the visible-VRAM heap. CC: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6827>
-
When I enable "Above 4G decoding" in my BIOS I still get 16 MiB of non-visible VRAM on my 8G VRAM GPU ... CC: mesa-stable Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6827>
-
After we lowered `return` into `break` - the control flow is changed and the block with this change has a new successor, which means that in this new successor phis should have additional source. Since the instructions that use phis in the successor are predicated - it's ok for a new phi source to be undef. If `return` is lowered in a nested loop, `break` is inserted in the outer loops, so all new blocks with break require the same changes to phis described above. Examples of NIR before lowering: block block_0: loop { block block_1: if ssa_2 { block block_2: return // succs: block_6 } else { block block_2: break; // succs: block_5 } block block_4: } block block_5: // preds: block_3 vec1 32 ssa_4 = phi block_3: ssa_1 // succs: block_6 block block_6: Here converting return to break should add block_2 to the phis of block_5. block block_0: loop { block block_1: loop { block block_2: if ssa_2 { block block_3: return // succs: block_8 } else { block block_4: break; // succs: block_6 } block block_5: } block block_6: break; // succs: block_7 } block block_7: // preds: block_6 vec1 32 ssa_4 = phi block_6: ssa_1 // succs: block_8 block block_8: Here converting return to break will insert conditional break in the outer loop, changing block_6 predcessors. Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#3322 Closes: mesa/mesa#3498 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6186>
-
Like GFX10.3 which is currently broken. Cc: 20.2 20.3 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7786> (cherry picked from commit b589df98)
-
Using more blend targets than specified by maxFragmentDualSrcAttachments is invalid per the Vulkan spec. I'm usually not a fan to workaround game bugs inside the driver but it's really easy for us to ignore MRT1+ in the driver and that prevents wrong behaviour. Cc: 20.2, 20.3 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7684> (cherry picked from commit bc7f442d)
-
No fossils-db changes. Cc: 20.2, 20.3 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!7657> (cherry picked from commit 0fcd3791)
-
Ported from RadeonSI. To get optimal LDS usage since the previous change. Cc: 20.2 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7566> (cherry picked from commit f777d00a)
-
Ported from RadeonSI. The restriction was applied too late. Cc: 20.2 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7566> (cherry picked from commit c5e8f670)
-
Ported from RadeonSI. Cc: 20.2 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7566> (cherry picked from commit 0790105f)
-
From the Vulkan spec 1.2.157: "VK_DYNAMIC_STATE_STENCIL_TEST_ENABLE_EXT specifies that the stencilTestEnable state in VkPipelineDepthStencilStateCreateInfo will be ignored and must be set dynamically with vkCmdSetStencilTestEnableEXT before any draw call." So, stencilTestEnable should be ignored if dynamic. While we are at it, fix depthBoundsTestEnable too. Cc: 20.2 Closes: mesa/mesa#3633 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7112> (cherry picked from commit bb00a686)
-
The vertex attribute stride should be ignored, so make sure it's initialized to zero if dynamic to avoid computing a wrong offset. The fact that each element of pStrides must be greater than or equal to the maximum extent of all vertex input attributes fetched saves us one user SGPR for the dynamic stride. Closes: mesa/mesa#3627 Cc: 20.2 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7101> (cherry picked from commit 48b988e3)
-
Otherwise, if a phi gets spilled, the operand might be considered unused. Fixes: d48d72e9 ('aco: Initial commit of independent AMD compiler') Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!8055> (cherry picked from commit 0bccfd86)
-
If the image tiling is set to VK_IMAGE_TILING_LINEAR, buffer_set_metadata will read an uninitialized radeon_bo_metadata. Signed-off-by: Simon Ser <contact@emersion.fr> Fixes: d5fd8cd4 ("radv: Allow non-dedicated linear images and buffer.") Cc: mesa-stable Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7898> (cherry picked from commit ad19b071)
-
the code here tries to be too smart and only use a geometry shader if there's actually multiple layers being uploaded, but the fragment shader also unconditionally reads gl_Layer as long as the pipe cap for gs is set, which means that in the case when the gs is dynamically disabled due to uploading a single-layer surface, the fs has no input to read for gl_Layer and everything breaks always using a gs isn't ideal, but it's considerably more work to manage multiple fs variants based on layer usage Fixes: c99f2fe7 ("st/mesa: implement PBO upload for multiple layers") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!8067> (cherry picked from commit 614c7777)
-
I got confused and: * used the vkformat instead of the pipe format for getting format description * incorrectly calculated bpp but this time it's definitely 100% fixed I promise Fixes: 456b5780 ("zink: fix direct image mapping offset") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!8074> (cherry picked from commit dfd0f042)
-
the x and y offsets here were improperly calculated without taking into account: * layer/level offset * x/y coord bpp Fixes: 8d46e35d ("zink: introduce opengl over vulkan") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!8058> (cherry picked from commit 456b5780)
-
Dylan Baker authored
-
- Dec 11, 2020
-
-
On GFX6/7, it might violate validation rules, otherwise. Fixes: 51f4b22f ('aco: don't allow unaligned subdword accesses on GFX6/7') Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!8047> (cherry picked from commit fd49ba59)
-
The scheduler doesn't take SGPR use into account, which can be a limiting factor on older GPUs. This patch fixes a CTS test crash on GFX6. CC: mesa-stable Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!8040> (cherry picked from commit 731f8fc9)
-
because 848e7b94 commit cause.it modify u_debug_stack_android.cpp location from src/gallium/auxiliary/util to src/util but Android.mk not modify Fixes: 848e7b94 ("Move stack debug functions to src/util") Signed-off-by: cheyang <cheyang@bytedance.com> Acked-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!7851> (cherry picked from commit 83d1e2ef)
-
Dylan Baker authored
-
- Dec 10, 2020
-
-
It uses the arm_build image, but didn't depend on the job which ensures it exists. So jobs using the template could run before the arm_build job had finished, and fail if the image didn't exist. Fixes: 6c8b9215 "ci: Build kernels and rootfs for x86 devices" Closes: mesa/mesa#3632 Reviewed-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!8003> (cherry picked from commit 5d073b5a)
-
VK spec got clarification about the pSizes parameter. Fixes set of new tests: dEQP-VK.pipeline.extended_dynamic_state*with_offset* v2: move offset subtract to be part of size calculation (Jason) CC: mesa-stable Closes: mesa/mesa#3871 Fixes: b9a05447 ("anv: dynamic vertex input binding stride and size support") Signed-off-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!7439> (cherry picked from commit 5998a654)
-