- Jun 12, 2020
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Jun 10, 2020
-
-
This allows communicating that it wasn't possible to determine whether the two file descriptors reference the same file description. When that's the case, log a warning in the amdgpu winsys. In turn, remove the corresponding debugging output from the fallback os_same_file_description implementation. It depends on the caller if false negatives are problematic or not. Reviewed-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Tested-by: Marge Bot <mesa/mesa!3879> Part-of: <mesa/mesa!3879> (cherry picked from commit f5a89589)
-
- Jun 09, 2020
-
-
We reuse DRM file descriptors internally. Therefore when we export a GEM handle we must do so in the file descriptor used externally. This change also fixes a file descriptor leak of the FD given at screen creation. v2: Don't bother checking fd equals, they're always different Fix dmabuf leak Fix GEM handle leaks by tracking exported handles v3: Check os_same_file_description error (Michel) Don't create multiple exports for a given GEM table v4: Add WARN_ONCE (Ken) Rename external_fd to winsys_fd v5: Remove export lock in favor of bufmgr's Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: mesa/mesa#2882 Fixes: 7557f160 ("iris: share buffer managers accross screens") Tested-by: Eric Engestrom <eric@engestrom.ch> Tested-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit aba3aed9)
-
To fix rendering issues with Metro Exodus, RE2 and 3 and probably more titles. It seems the default behaviour of DX12 anyways. Closes: mesa/mesa#3064 Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5262> (cherry picked from commit d3c937c0)
-
That fixes some rendering issues. Probably some unitialized data from the game. Closes: mesa/mesa#3064 Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5262> (cherry picked from commit fd5ffd3a)
-
The current "ds = state->bs" seems broken, and the "vs = state->bs" is unnecessary (already set above). Since it was added as part of a GS-related patch, I think this is what was intended. Note: tesselation disables GMEM rendering so we shouldn't have to worry about hs/ds + binning interaction. Fixes: 0eebedb6 ("freedreno/a6xx: Emit program state for GS") Signed-off-by: Jonathan Marek <jonathan@marek.ca> Part-of: <mesa/mesa!5370> (cherry picked from commit 6cc95abb)
-
glsl_to_nir doesn't expect non-vector/scalar return types in functions. Fixes: 7e60d5a5 Closes: mesa/mesa#3058 Closes: mesa/mesa#3060 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Tested-by: Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by: Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!5333> (cherry picked from commit 9f1cf0e4)
-
Make sure to propagate the NON_UNIFORM access for UBO loads, so that non-uniform loads are correctly lowered. Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!5311> (cherry picked from commit 86f21e4e)
-
See code comment for full description of the change. Fixes: 0a5018c1 ("mesa: add gl_constants::GLSLOptimizeConservatively") Closes: mesa/mesa#3034 Tested-by: Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5346> (cherry picked from commit e43ab7bb)
-
The script was failing for me (python 3.8), not sure if this is a recent python version break or not as I don't know how often people have been running this script: Processing ./gen9.xml... Traceback (most recent call last): File "./gen_sort_tags.py", line 177, in <module> main() File "./gen_sort_tags.py", line 170, in main genxml[:] = enums + sorted_structs.values() + instructions + registers TypeError: can only concatenate list (not "odict_values") to list Turning the odict into a list fixes it for me, and the resulting xml file are identical to before :) Fixes: 903e142f ("genxml: add a sorting script") Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!5352> (cherry picked from commit 981d07c7)
-
Cc: mesa-stable Closes: mesa/mesa#3086 Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Vinson Lee <vlee@freedesktop.org> Part-of: <mesa/mesa!5342> (cherry picked from commit 7a68045b)
-
For shaders where there's already a psiz-variable, we should rather reuse it than create a second one. This can happen if a shader writes gl_PointSize, but disables GL_PROGRAM_POINT_SIZE. Fixes: 878c9428 ("nir: add lowering-pass for point-size mov") Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!5328> (cherry picked from commit e61a9887)
-
We reuse DRM file descriptors internally. Therefore when we export a GEM handle we must do so in the file descriptor used externally. v2: Fix dmabuf leak Fix GEM handle leaks by tracking exported handles v3: Check os_same_file_description error (Michel) Don't create multiple exports for a given GEM table v4: Add WARN_ONCE (Ken) v5: Remove blank line (Ian) Remove unused field (Ian) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: mesa/mesa#2882 Fixes: 4094558e ("i965: share buffer managers across screens") Tested-by: Eric Engestrom <eric@engestrom.ch> Tested-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit 57e4d0aa)
-
We'll start using this field more for querying image properties. Without it we run into a crash. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit e41e8206)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Tested-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit 604a86e4)
-
Reported-by: Rafał Mikrut <mikrutrafal54@gmail.com> Fixes: a63b9071 ("mesa: also check for __NetBSD__") Closes: mesa/mesa#3015 Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!5191> (cherry picked from commit c3025bde)
-
Fix warning reported by Coverity Scan. Wrong sizeof argument (SIZEOF_MISMATCH) suspicious_sizeof: Passing argument 3544UL (sizeof (vlVdpPresentationQueue)) to function calloc that returns a pointer of type vlVdpPresentationQueueTarget * is suspicious because a multiple of sizeof (vlVdpPresentationQueueTarget) /*16*/ is expected. Fixes: 65fe0866 ("vl: implemented a few functions and made stubs to get mplayer running") Closes: mesa/mesa#3026 Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!5182> (cherry picked from commit 8b353524)
-
Dylan Baker authored
We don't want to copy the file into the build directory, we want to install it. That's what install_data is for. Closes: mesa/mesa#2924 Fixes: 56ccea58 ("vulkan/overlay: Add basic overlay control script.") Acked-by: Matt Turner <mattst88@gmail.com> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!4740> (cherry picked from commit fb62e642)
-
This fixes dEQP-GLES3.functional.shaders.texture_functions.textureprojlodoffset.sampler2dshadow_vertex. This is probably a dEQP bug. Fixes: d573d1d8 Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!5209> (cherry picked from commit fe394763)
-
bellagio/omx header files reference a global variable without the extern keyworkd. Now that gcc-10 enables the '-fno-common' by default the build fails. Since these are external headers we can't easily fix them, so for now build the omx module with the '-fcommon' flag to keep the previous behavior. See mesa/mesa#2385 Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <mesa/mesa!4058> (cherry picked from commit 283e8153) Closes: mesa/mesa#3019
-
Dylan Baker authored
-
- Jun 01, 2020
-
-
Yevhenii Kolesnikov authored
Knowing following: - CMP writes to flag register the result of applying cmod to the `src0 - src1`. After that it stores the same value to dst. Other instructions first store their result to dst, and then store cmod(dst) to the flag register. - inst is either CMP or MOV - inst->dst is null - inst->src[0] overlaps with scan_inst->dst - inst->src[1] is zero - scan_inst wrote to a flag register There can be three possible paths: - scan_inst is CMP: Considering that src0 is either 0x0 (false), or 0xffffffff (true), and src1 is 0x0: - If inst's cmod is NZ, we can always remove scan_inst: NZ is invariant for false and true. This holds even if src0 is NaN: .nz is the only cmod, that returns true for NaN. - .g is invariant if src0 has a UD type - .l is invariant if src0 has a D type - scan_inst and inst have the same cmod: If scan_inst is anything than CMP, it already wrote the appropriate value to the flag register. - else: We can change cmod of scan_inst to that of inst, and remove inst. It is valid as long as we make sure that no instruction uses the flag register between scan_inst and inst. Nine new cmod_propagation unit tests: - cmp_cmpnz - cmp_cmpg - plnnz_cmpnz - plnnz_cmpz (*) - plnnz_sel_cmpz - cmp_cmpg_D - cmp_cmpg_UD (*) - cmp_cmpl_D (*) - cmp_cmpl_UD (*) this would fail without changes to brw_fs_cmod_propagation. This fixes optimisation that used to be illegal (see issue #2154) = Before = 0: linterp.z.f0.0(8) vgrf0:F, g2:F, attr0<0>:F 1: cmp.nz.f0.0(8) null:F, vgrf0:F, 0f = After = 0: linterp.z.f0.0(8) vgrf0:F, g2:F, attr0<0>:F Now it is optimised as such (note change of cmod in line 0): = Before = 0: linterp.z.f0.0(8) vgrf0:F, g2:F, attr0<0>:F 1: cmp.nz.f0.0(8) null:F, vgrf0:F, 0f = After = 0: linterp.nz.f0.0(8) vgrf0:F, g2:F, attr0<0>:F No shaderdb changes Closes: mesa/mesa#2154 Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Reviewed-by: Matt Turner <mattst88@gmail.com> Tested-by: Marge Bot <mesa/mesa!3348> (cherry picked from commit 32b7ba66) Part-of: <mesa/mesa!5149>
-
They will stop working in the next GitLab release, so let's update them ASAP to make sure things are propagated to everyone by then. See: https://about.gitlab.com/releases/2020/05/06/gitlab-com-13-0-breaking-changes/#removal-of-deprecated-project-paths Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Eric Engestrom <eric@engestrom.ch> Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!5111> The backport on this was non-trival, git couldn't figure out what had actually changed and came up with thousands of whitespace changes. I reimplemented this commit using: git grep -l -P '/mesa/mesa/(?!-)' | xargs sed -r -i 's@/mesa/mesa/([a-zA-Z0-1])@/mesa/mesa/-/\1@g'
-
It was found that dual-source blending hangs with SIMD16 dispatch in some specific but unknown situation. Which in the wild happen when rgba anti-aliasing is enabled for fonts. Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2183 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!5037> (cherry picked from commit 296c04d7)
-
This extension only allows HLSL shader compilers to optionally embed unambiguous type information which can be safely ignored by the driver. This fixes a crash with the recent Vulkan backend of Path Of Exile (it uses the extension without checking if it's supported). Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Tested-by: Edmondo Tommasina <edmondo.tommasina@gmail.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!5237> (cherry picked from commit 10c4a7cf)
-
The default behaviour (0) is: "round-nearest-even to n.6 and drop fraction when point sampling" whereas the OpenGL spec simply wants us to floor it (1) "truncate when point sampling". See 8.14.2 in the OpenGL spec: https://www.khronos.org/registry/OpenGL/specs/gl/glspec46.core.pdf The Direct3D spec also mandates this (https://microsoft.github.io/DirectX-Specs/d3d/archive/D3D11_3_FunctionalSpec.htm#7.18.7%20Point%20Sample%20Addressing ) On WineD3D: This fixes some point-sampling texture precision issues in some Direct3D 9 titles such as Guild Wars 2 and htoL#NiQ: The Firefly Diary that are not present on other vendors. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!3953> (cherry picked from commit d573d1d8)
-
Only Stoney and Raven2 are affected. Cc: 20.0 20.1 <mesa-stable@lists.freedesktop.org> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5047> (cherry picked from commit f80d653d)
-
Dylan Baker authored
-
Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!4816> (cherry picked from commit 9e3c6a7b)
-
v2: remove the option to actually request normalization and its application in Intel < Gen6 (Jason) v3: Also don't lower for query operations (Jason) Fixes: 1ce8060c nir/lower_tex: support for lowering RECT textures Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!5105> (cherry picked from commit 682e14d3)
-
mesa/st is initializing pipe_shader_state for user define shaders. This patch intialized pipe_shader_state for all passthough and transform shaders. This fixes crashes for several opengl apps. Issue is found in vmware internal testing Fixes: f01c0565 ("draw: free the NIR IR.") Reviewed-by: Charmaine Lee <charmainel@vmware.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!5240> (cherry picked from commit 838666a4)
-
Fix warning reported by Coverity Scan. Missing argument to printf format specifier (PRINTF_ARGS) missing_argument: No argument for format specifier %s. Fixes: 04c1536b ("r300g: rasterizer debug logging") Fixes: 85efb2ff ("r300g: try to use color varyings for texcoords if max texcoord limit is exceeded") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5274> (cherry picked from commit d2f8105b)
-
This is needed to support the core's usage of coherent buffers for glVertex-style input. The reason why this was disallowed is that any mappings will be invalidated. Let the state tracker worry about that, and just reallocate when we're told. Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by: Karol Herbst <kherbst@redhat.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!5276> (cherry picked from commit 6e1c47b9)
-
We were inserting the right number of MOVs but, thanks to the way we advanced msg_end earlier in the function, were often writing the zeros past the end of where we actually read in the register file. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!5243> (cherry picked from commit 94aa7997)
-
We already do this in the FS back-end; we just weren't doing it in vec4 so RESINFO messages weren't returning the right data. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!5243> (cherry picked from commit a7c8811f)
-
If the ~/.cache dir already exists continue on without failing. Fixes: cd61f523 ("radv: Handle failing to create .cache dir.") Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5249> (cherry picked from commit e843303d)
-
Fix warning reported by Coverity. Dereference null return value (NULL_RETURNS) dereference: Dereferencing a pointer that might be NULL fp when calling fwrite. Fixes: 8d46e35d ("zink: introduce opengl over vulkan") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!5235> (cherry picked from commit a2ee2934)
-
Dylan Baker authored
-
- May 28, 2020
-
-
Totals from 11 (0.01% of 127638) affected shaders: Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler') Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!4880> (cherry picked from commit e1900ee2)
-