- May 02, 2022
-
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
Fixes #1194 Part-of: <gstreamer/gstreamer!2345>
-
- May 01, 2022
-
-
Only window created with CS_DBLCLKS style can receive those mouse double click events, so we need to use the style for internal/external windows can get double click events. Also, passthrough mouse events to parent window in the same message pumping threads instead of manually forwarding each mouse event. Fixes: gstreamer/gstreamer#1172 Part-of: <gstreamer/gstreamer!2286>
-
We were using ANSI version APIs implicitly because UNICODE is not defined by ourselves. But potentially it can be broken if user defines UNICODE. Part-of: <gstreamer/gstreamer!2286>
-
- Apr 30, 2022
-
-
Tim-Philipp Müller authored
These artefacts confuse the plugin scanner and may cause noisy warnings (and slow down things). Fixes gstreamer/gst-build#68 Part-of: <gstreamer/gstreamer!2338>
-
- Apr 29, 2022
-
-
Otherwise caps negotiation will fail in situations that are supposed to work, like: "video/x-raw,framerate=(fraction)60/1" ! interlace field-pattern=0 ! "video/x-raw,framerate=(fraction)30/1" Part-of: <gstreamer/gstreamer!2337>
-
Part-of: <gstreamer/gstreamer!2337>
-
- Apr 28, 2022
-
-
Some streams have 2 PMT sections in a single TS packet. The first one is "valid" but doesn't contain/define any streams. That causes an unrecoverable issue when we try to activate the 2nd (valid) PMT. Instead of doing that, pre-emptively refuse to process PMT without any streams present within. We still do post that section on the bus to inform applications. Fixes #1181 Part-of: <gstreamer/gstreamer!2327>
-
The stream lock is taken before handling gap events but was not released in all possible runtime situations. This issue was introduced in: gstreamer/gst-plugins-base!1274 Part-of: <gstreamer/gstreamer!2326>
-
If the html SAMI data is malformed, then retrieving the attribute name may fail. We then cannot retrieve the attribute value. Fixes: https://oss-fuzz.com/testcase-detail/4700130671984640 Part-of: <gstreamer/gstreamer!2325>
-
This should've included in the previous MR gstreamer/gstreamer!987 already, but missed. Part-of: <gstreamer/gstreamer!2324>
-
This actually respects the existing `expose-all-streams` property by exposing them and having them present in the stream collection (as streams of type unknown). Fixes #1179 Part-of: <gstreamer/gstreamer!2323>
-
In push mode (streaming), if the received chunk buffer size from _chain is bigger than output buffer size, the flags of the divided-buffers are propagated to the DISCONT flag from first received chunk buffer. This unexpected buffers contained DISCONT flags are abnormally transformed when changing the sampling rate by audioresample element. So unset unnecessary DISCONT flag before pad_push(). Part-of: <gstreamer/gstreamer!2322>
-
The decision to store the input buffer depends on whether extensions are to be added to the output buffer, I assume as an optimization. This creates an issue for subclasses that call negotiate(), where header_exts is actually populated, from their handle_buffer() implementation: at chain time, no header extension has been negotiated yet, which means that we don't add extensions to the first batch of buffers that comes out. Keep track of whether negotiate has been called (this is different from the negotiated field) and always store the input buffer until then. This fixes the issue while largely preserving the optimization. Part-of: <gstreamer/gstreamer!2321>
-
Fixing this pipeline: gst-launch-1.0 filesrc location=sample.png ! pngdec ! videorate ! fakesink - videorate receives a single buffer with pts = 0, duration = invalid; - then it receives eos triggering this buffer to be pushed downstream; - the pushing code was assuming that a duration was set, which is impossible as we received a single buffer and no output framerate was set either. So the best we can do is to push the buffer without duration. Fix #1177 Part-of: <!2320>
-
- Apr 26, 2022
-
-
Part-of: <gstreamer/gstreamer!2301>
-
Part-of: <gstreamer/gstreamer!2301>
-
The va pool is used for GPU side surface/image, its alignment should not be changed arbitrarily by others. So we decide not to expose the GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT flag anymore. Instead, user can call gst_buffer_pool_config_set_va_alignment() to set its surface/image alignment. Part-of: <gstreamer/gstreamer!2301>
-
We want to use gst_buffer_pool_config_set_va_alignment() to replace gst_buffer_pool_config_get_video_alignment(). The later one is specific for GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT option. Part-of: <gstreamer/gstreamer!2301>
-
Also delete the useless "have_cinfo" judgement. Part-of: <gstreamer/gstreamer!2297>
-
According to spec: color range equal to 0 shall be referred to as the studio swing representation and color range equal to 1 shall be referred to as the full swing representation. The current status is just the opposite. Part-of: <gstreamer/gstreamer!2297>
-
- Apr 23, 2022
-
-
This reverts commit 75b4809e. See gstreamer/gstreamer!2186 Part-of: <gstreamer/gstreamer!2255>
-
This reverts commit a76f38b2. See gstreamer/gstreamer!2186 Part-of: <gstreamer/gstreamer!2255>
-
This reverts commit 6f7922b4. See gstreamer/gstreamer!2186 Part-of: <gstreamer/gstreamer!2255>
-
This reverts commit 24fd8034. See gstreamer/gstreamer!2186 Part-of: <gstreamer/gstreamer!2255>
-
This reverts commit 98f2a84a. See gstreamer/gstreamer!2186 Part-of: <gstreamer/gstreamer!2255>
-
Turn it into a FIXME, and only log once Part-of: <gstreamer/gstreamer!2281>
-
Part-of: <gstreamer/gstreamer!2280>
-
- Apr 22, 2022
-
-
Part-of: <gstreamer/gstreamer!2278>
-
- Apr 21, 2022
-
-
This is to avoid transcoding negotiation fail between v4l2h265dec and v4l2h264enc caused by colorimetry mismatch. Part-of: <gstreamer/gstreamer!2220>
-
Part-of: <gstreamer/gstreamer!2258>
-
Tim-Philipp Müller authored
Follow-up to !2243 Part-of: <gstreamer/gstreamer!2260>
-
- Apr 20, 2022
- Apr 19, 2022
-
-
Found via an analyzed build for Clang. Specifically we had: gstav1parse.c[1850,11] in gst_av1_parse_detect_stream_format: Logic error: The left operand of '==' is a garbage value gstav1parse.c[1606,11] in gst_av1_parse_handle_to_small_and_equal_align: Logic error: The left operand of '==' is a garbage value Also a couple of false-positives: gstav1parse.c[1398,24] in gst_av1_parse_handle_one_obu: Logic error: Branch condition evaluates to a garbage value gstav1parse.c[1440,37] in gst_av1_parse_handle_one_obu: Logic error: The left operand of '-' is a garbage value Part-of: <gstreamer/gstreamer!2240>
-
We made the gstreamer installation prefix relocatable by picking up plugins relative to the location of libgstreamer-1.0.dylib, similar to how it's done for Windows: gstreamer/gstreamer!1627 This had a lot of side-effects: gstreamer/gstreamer#1051 gstreamer/cerbero#363 gstreamer/cerbero#371 gstreamer/cerbero#362 A partial fix for the cerbero side of these was: gstreamer/cerbero!807 However, this relied on the consumers knowing that they need to add `LC_RPATH` entries to the libdir of the prefix. This is done automatically by build systems like Meson, but not by others, such as Autotools, CMake, Cargo, XCode, etc. For those, we need to add the RPATH entries to the gstreamer-1.0.pc file. This also has the side-effect of fixing the loading of gstreamer rust plugins on macOS: Fixes gstreamer/gstreamer#1159 Fixes gstreamer/gstreamer#1149 Part-of: <gstreamer/gstreamer!2237>
-
Remove now-unused get_stream_type_for_event() function. Part-of: <gstreamer/gstreamer!2236>
-
Take the playbin lock when accessing the combiner to add a new pad to link to. Fixes races against streams-selected messages triggering reconfiguration. Part-of: <gstreamer/gstreamer!2236>
-
Don't reconfigure outputs when the select-streams event is sent from the app, as the selection may not take effect for some time. Instead, wait for the pipeline to confirm the new set of selected streams when it sends the message. Part-of: <gstreamer/gstreamer!2236>
-