- Mar 02, 2022
-
-
Dylan Baker authored
-
Dylan Baker authored
Acked-by: Jesse Natalie <jenatali@microsoft.com>
-
Dylan Baker authored
-
Dylan Baker authored
We don't know why it passes, but we're not complaining. Acked-by: Dave Airlie <airlied@redhat.com>
-
- Mar 01, 2022
-
-
Dylan Baker authored
-
- Feb 25, 2022
-
-
This extension isn't wired up in Gallium, so there's just no way a Gallium driver like Panfrost exposes it. While there were support in i965 for this for the cancelled Broxton GPU, thre's no such support in the Iris driver. And since Broxton has been cancelled, it's unlikely to be wired up any time soon. Fixes: da23a317 ("docs/features: Update ASTC entries for Panfrost") Acked-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!15145> (cherry picked from commit 834db3aa)
-
When we shadow a resource, the backing BO is changed; as such, existing references to the resource become invalid. So batches accessing the resource need to be flushed (or otherwise have their references invalidated). The wrong behaviour change (not flushing) was introduced when we started tracking resources instead of BOs. The issue manifested as a severe performance regression in glmark2's -bbuffer test, particular the subdata subtest. The issue is magnified on slow CPUs; without the fix, the test becomes completely CPU bound Relevant glmark2 -bbuffer test from 43fps to 84fps. Apparently, this causes functional issues too -- this performance-minded change also fixes a few piglits. Fixes: cecb8894 ("panfrost: Do tracking of resources, not BOs") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reported-by: Chris Healy <cphealy@gmail.com> Part-of: <mesa/mesa!13502> (cherry picked from commit 988d5aae)
-
Fixes a NULL dereference in Piglit fp-fragment-position, getting the test to pass. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!13203> (cherry picked from commit 5536852d)
-
Fixes a NULL dereference in Piglit fp-fragment-position. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!13203> (cherry picked from commit 53ef20f0)
-
Roughly use the freedreno logic to handle all the extra things that will come up in our Piglit sooner than later. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!13203> (cherry picked from commit 30485142)
-
I had missed these when hooking up the original support. Fixes: 31eeb72e ("blorp: Add support for blorp_copy via XY_BLOCK_COPY_BLT") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!15157> (cherry picked from commit 97f18d29)
-
This check for geom shader needed to be expanded for tess support. dEQP-VK.transform_feedback.simple.depth_clip_control_tese with lvp Fixes: dacf8f5f ("draw: hook up final bits of tessellation") Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!15128> (cherry picked from commit b77ef4dd)
-
Suggested-by: Jason Ekstrand <jason.ekstrand@collabora.com> Fixes: c17e2216 ("anv: Align buffer VMA to 2MiB for XeHP") Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15054> (cherry picked from commit 0fffaa9f)
-
Fixes: c17e2216 ("anv: Align buffer VMA to 2MiB for XeHP") Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15054> (cherry picked from commit 5a28d248)
-
When handle->type is WINSYS_HANDLE_TYPE_FD, the caller wants a file descriptor for the BO backing the resource. We previously had two paths for this: 1. If rsrc->scanout is available, we prime the GEM handle from the KMS device (rsrc->scanout->handle) to a file descriptor via the KMS device. 2. If rsrc->scanout is not available, we prime the GEM handle from the GPU (bo->gem_handle) to a file descriptor via the GPU device. In both cases, the caller passes in a resource (with BO) and expects out a file descriptor. There are no direct GEM handles in the function signature; the caller doesn't care which GEM handle we prime to get the file descriptor. In principle, both paths produce the same file descriptor for the same BO, since both GEM handles represent the same underlying resource (viewed from different devices). On grounds of redundancy alone, it makes sense to remove the rsrc->scanout path. Why have a path that only works sometimes, when we have another path that works always? In fact, the issues with the rsrc->scanout path are deeper. rsrc->scanout is populated by renderonly_create_gpu_import_for_resource, which does the following: 1. Get a file descriptor for the resource by resource_get_handle with WINSYS_HANDLE_TYPE_FD 2. Prime the file descriptor to a GEM handle via the KMS device. Here comes strike number 2: in order to get a file descriptor via the KMS device, we had to /already/ get a file descriptor via the GPU device. If we go down the KMS device path, we effectively round trip: GPU handle -> fd -> KMS handle -> fd There is no good reason to do this; if everything works, the fd is the same in each case. If everything works. If. The lifetimes of the GPU handle and the KMS handle are not necessarily bound. In principle, a resource can be created with scanout (constructing a KMS handle). Then the KMS view can be destroyed (invalidating the GEM handle for the KMS device), even though the underlying resource is still valid. Notice the GPU handle is still valid; its lifetime is tied to the resource itself. Then a caller can ask for the FD for the resource; as the resource is still valid, this is sensible. Under the scanout path, we try to get the FD by priming the GEM handle on the KMS device... but that GEM handle is no longer valid, causing the PRIME ioctl to fail with ENOENT. On the other hand, if we primed the GPU GEM handle, everything works as expected. These edge cases are not theoretical; recent versions of Xwayland trigger this ENOENT, causing issue #5758 on all Panfrost devices. As far as I can tell, no other kmsro driver has this 'special' kmsro path; the only part of resource_get_handle that needs special handling for kmsro is getting a KMS handle. Let's remove the broken, useless path, fix Xwayland, bring us in line with other drivers, and delete some code. Thank you for coming to my ted talk. Closes: #5758 Fixes: 7da251fc ("panfrost: Check in sources for command stream") Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reported-and-tested-by: Jan Palus <jpalus@fastmail.com> Reviewed-by: Simon Ser <contact@emersion.fr> Reviewed-by: James Jones <jajones@nvidia.com> Acked-by: Daniel Stone <daniels@collabora.com> Tested-by: Dan Johansen <strit@manjaro.org> Part-of: <mesa/mesa!15120> (cherry picked from commit b5734cc1)
-
This commit will enable pass for searching readonly / writeonly access when it's missing. We don't support shaderStorageImageReadWithoutFormat and the optimization pass causes those shaders to take the write-only path which does support formatless. Following games are affected with positive result: - Wolfenstein: Youngblood - Wolfenstein II: The New Colossus mesa/mesa#3138 - Rage 2 mesa/mesa#5791 - The Surge 2 mesa/mesa#5805 - Metro Exodus mesa/mesa#4703 - DOOM Eternal mesa/mesa#4273 Cc: mesa-stable Closes: mesa/mesa#3138,https://gitlab.freedesktop.org/mesa/mesa/-/issues/5791,https://gitlab.freedesktop.org/mesa/mesa/-/issues/4273 Signed-off-by: Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!15082> (cherry picked from commit ded9cb90)
-
Otherwise a shader invocation would read the value which should have been set AFTER this shader invocation. Fixes tests: dEQP-VK.rasterization.rasterization_order_attachment_access.depth.samples_1.multi_draw_barriers dEQP-VK.rasterization.rasterization_order_attachment_access.stencil.samples_1.multi_draw_barriers Fixes: 71595a18 ("tu: Fix feedback loops in sysmem mode") Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!15106> (cherry picked from commit dab34bd5)
-
XeHP scratch space is handled differently. Commit ae18e1e7 implemented support for it, but handled it differently between render and compute shaders: it calculates scratch_addr differently and doesn't pin the buffer on compute. Make it work on compute shaders by calling pin_scratch_space() from iris_compute_walker(), which fixes both the address and the pinning. This commit can be verified by the two-year-old-but-still-unreviewed Piglit MR 234. You can also verify this by running a very simple compute shader with INTEL_DEBUG=spill_fs. References: mesa/piglit!234 Fixes: ae18e1e7 ("iris: Add support for scratch on XeHP") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!15070> (cherry picked from commit d10fd5b7)
-
Dylan Baker authored
-
Dylan Baker authored
-
- Feb 24, 2022
-
-
Commit 38800b38 changed nir_opcodes.py, but that doesn't seem to have triggered nir_opt_algebraic.py. The change in 75ef5991 depends on opt_algebraic lowering 16-bit versions of slt, but if opt_algebraic is not rebuilt, this may not happen. This resulted in some people seeing assertion failures in, for example, dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_3.step, due to the backend seeing nir_op_slt that it didn't know how to handle. v2: Add nir_opcodes.py to nir_algebraic_py so that all the per-driver algebraic passes pick up the dependency too. Rename it to nir_algebraic_depends. Suggested by Emma. Closes: #6047 Fixes: d1992255 ("meson: Add build Intel "anv" vulkan driver") Reviewed-by: Emma Anholt <emma@anholt.net> Acked-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15050> (cherry picked from commit a01b2629) Conflicts: src/gallium/drivers/r300/meson.build - Delete code from r300, which doesn't exist in the 22.0 branch
-
It's a bit more code, but it's needed to chew through control flow since we don't have a backend version of dead_cf. Results are really good, meaning I really screwed this up the first time around (hence the cc mesa-stable). total instructions in shared programs: 1963576 -> 1939513 (-1.23%) instructions in affected programs: 671053 -> 646990 (-3.59%) helped: 4436 HURT: 729 helped stats (abs) min: 1.0 max: 43.0 x̄: 5.75 x̃: 6 helped stats (rel) min: 0.21% max: 100.00% x̄: 6.47% x̃: 5.17% HURT stats (abs) min: 1.0 max: 22.0 x̄: 2.01 x̃: 1 HURT stats (rel) min: 0.50% max: 50.00% x̄: 10.45% x̃: 9.09% 95% mean confidence interval for instructions value: -4.77 -4.55 95% mean confidence interval for instructions %-change: -4.36% -3.80% Instructions are helped. total tuples in shared programs: 1533335 -> 1523194 (-0.66%) tuples in affected programs: 483167 -> 473026 (-2.10%) helped: 3414 HURT: 1288 helped stats (abs) min: 1.0 max: 20.0 x̄: 3.73 x̃: 2 helped stats (rel) min: 0.27% max: 100.00% x̄: 4.87% x̃: 3.03% HURT stats (abs) min: 1.0 max: 19.0 x̄: 2.02 x̃: 1 HURT stats (rel) min: 0.24% max: 38.10% x̄: 8.10% x̃: 5.88% 95% mean confidence interval for tuples value: -2.28 -2.03 95% mean confidence interval for tuples %-change: -1.62% -1.02% Tuples are helped. total clauses in shared programs: 351432 -> 329158 (-6.34%) clauses in affected programs: 142237 -> 119963 (-15.66%) helped: 5328 HURT: 3 helped stats (abs) min: 1.0 max: 43.0 x̄: 4.18 x̃: 4 helped stats (rel) min: 0.74% max: 100.00% x̄: 19.44% x̃: 17.24% HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 HURT stats (rel) min: 9.09% max: 12.50% x̄: 10.90% x̃: 11.11% 95% mean confidence interval for clauses value: -4.25 -4.11 95% mean confidence interval for clauses %-change: -19.72% -19.12% Clauses are helped. total cycles in shared programs: 202830.92 -> 172084.50 (-15.16%) cycles in affected programs: 117078.42 -> 86332 (-26.26%) helped: 5450 HURT: 1 helped stats (abs) min: 0.083333 max: 49.0 x̄: 5.64 x̃: 5 helped stats (rel) min: 1.42% max: 100.00% x̄: 27.94% x̃: 25.64% HURT stats (abs) min: 0.25 max: 0.25 x̄: 0.25 x̃: 0 HURT stats (rel) min: 2.46% max: 2.46% x̄: 2.46% x̃: 2.46% 95% mean confidence interval for cycles value: -5.74 -5.54 95% mean confidence interval for cycles %-change: -28.30% -27.58% Cycles are helped. total arith in shared programs: 57274.29 -> 57145.04 (-0.23%) arith in affected programs: 16418.33 -> 16289.08 (-0.79%) helped: 2442 HURT: 1784 helped stats (abs) min: 0.041665999999999315 max: 0.75 x̄: 0.14 x̃: 0 helped stats (rel) min: 0.23% max: 100.00% x̄: 5.51% x̃: 2.87% HURT stats (abs) min: 0.041665999999999315 max: 0.9166670000000003 x̄: 0.12 x̃: 0 HURT stats (rel) min: 0.00% max: 100.00% x̄: 25.13% x̃: 9.09% 95% mean confidence interval for arith value: -0.04 -0.03 95% mean confidence interval for arith %-change: 6.61% 8.24% Inconclusive result (value mean confidence interval and %-change mean confidence interval disagree). total texture in shared programs: 12857 -> 12857 (0.00%) texture in affected programs: 0 -> 0 helped: 0 HURT: 0 total vary in shared programs: 11157.75 -> 11157.75 (0.00%) vary in affected programs: 0 -> 0 helped: 0 HURT: 0 total ldst in shared programs: 177208 -> 146420 (-17.37%) ldst in affected programs: 117098 -> 86310 (-26.29%) helped: 5447 HURT: 0 helped stats (abs) min: 1.0 max: 49.0 x̄: 5.65 x̃: 5 helped stats (rel) min: 1.92% max: 100.00% x̄: 27.91% x̃: 25.64% 95% mean confidence interval for ldst value: -5.75 -5.55 95% mean confidence interval for ldst %-change: -28.27% -27.56% Ldst are helped. total quadwords in shared programs: 1436507 -> 1398329 (-2.66%) quadwords in affected programs: 515101 -> 476923 (-7.41%) helped: 5150 HURT: 111 helped stats (abs) min: 1.0 max: 39.0 x̄: 7.46 x̃: 6 helped stats (rel) min: 0.17% max: 100.00% x̄: 10.02% x̃: 8.24% HURT stats (abs) min: 1.0 max: 9.0 x̄: 2.01 x̃: 1 HURT stats (rel) min: 0.43% max: 21.62% x̄: 3.57% x̃: 1.94% 95% mean confidence interval for quadwords value: -7.41 -7.11 95% mean confidence interval for quadwords %-change: -9.98% -9.49% Quadwords are helped. total threads in shared programs: 35025 -> 35228 (0.58%) threads in affected programs: 218 -> 421 (93.12%) helped: 208 HURT: 5 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 100.00% max: 100.00% x̄: 100.00% x̃: 100.00% HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 HURT stats (rel) min: 50.00% max: 50.00% x̄: 50.00% x̃: 50.00% 95% mean confidence interval for threads value: 0.91 0.99 95% mean confidence interval for threads %-change: 93.40% 99.55% Threads are helped. total loops in shared programs: 128 -> 125 (-2.34%) loops in affected programs: 3 -> 0 helped: 3 HURT: 0 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 100.00% max: 100.00% x̄: 100.00% x̃: 100.00% total spills in shared programs: 158 -> 149 (-5.70%) spills in affected programs: 15 -> 6 (-60.00%) helped: 9 HURT: 0 total fills in shared programs: 1133 -> 966 (-14.74%) fills in affected programs: 197 -> 30 (-84.77%) helped: 9 HURT: 0 Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!15090> (cherry picked from commit e0e63c2a)
-
The important thing isn't the number of words pushed, it's that there are no UBOs required for us to upload. Check that instead. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!15090> (cherry picked from commit 3c1021cd)
-
Dylan Baker authored
-
This is counter-intuitive, but required for correct operation when CSEL.i32 takes a 1-bit (stored 16-bit) boolean argument. The impedance mismatch ultimately is between CSEL.b32 (nir's bcsel, nonexistant in the hardware) and the lowering CSEL.i32. However, a similar problem exists even with MUX.i32 which lacks a good way of zero/sign-extending booleans. Cherry-picked from my Valhall branch though the issue also affects Bifrost. Fixes piglit shaders@glsl-vs-if-bool on Bifrost. Unfortunately, shader-db is quite unhappy :-( The proper fix is to use lower_bool_to_bitsize, but that can't be backported to mesa-stable. total instructions in shared programs: 157539 -> 158953 (0.90%) instructions in affected programs: 55621 -> 57035 (2.54%) helped: 2 HURT: 259 helped stats (abs) min: 2.0 max: 2.0 x̄: 2.00 x̃: 2 helped stats (rel) min: 2.11% max: 2.67% x̄: 2.39% x̃: 2.39% HURT stats (abs) min: 1.0 max: 40.0 x̄: 5.47 x̃: 2 HURT stats (rel) min: 0.36% max: 16.13% x̄: 2.55% x̃: 1.59% 95% mean confidence interval for instructions value: 4.44 6.40 95% mean confidence interval for instructions %-change: 2.21% 2.82% Instructions are HURT. total tuples in shared programs: 132322 -> 132907 (0.44%) tuples in affected programs: 31806 -> 32391 (1.84%) helped: 5 HURT: 152 helped stats (abs) min: 1.0 max: 2.0 x̄: 1.40 x̃: 1 helped stats (rel) min: 0.39% max: 3.03% x̄: 1.70% x̃: 1.61% HURT stats (abs) min: 1.0 max: 42.0 x̄: 3.89 x̃: 2 HURT stats (rel) min: 0.29% max: 18.18% x̄: 2.50% x̃: 1.79% 95% mean confidence interval for tuples value: 2.88 4.58 95% mean confidence interval for tuples %-change: 1.87% 2.85% Tuples are HURT. total clauses in shared programs: 28672 -> 28698 (0.09%) clauses in affected programs: 869 -> 895 (2.99%) helped: 1 HURT: 24 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 5.88% max: 5.88% x̄: 5.88% x̃: 5.88% HURT stats (abs) min: 1.0 max: 2.0 x̄: 1.12 x̃: 1 HURT stats (rel) min: 0.49% max: 33.33% x̄: 8.46% x̃: 3.59% 95% mean confidence interval for clauses value: 0.82 1.26 95% mean confidence interval for clauses %-change: 3.84% 11.93% Clauses are HURT. total cycles in shared programs: 15119.04 -> 15137.88 (0.12%) cycles in affected programs: 922.87 -> 941.71 (2.04%) helped: 4 HURT: 79 helped stats (abs) min: 0.0416669999999999 max: 0.0833330000000001 x̄: 0.05 x̃: 0 helped stats (rel) min: 0.40% max: 3.17% x̄: 1.57% x̃: 1.35% HURT stats (abs) min: 0.041665999999999315 max: 1.75 x̄: 0.24 x̃: 0 HURT stats (rel) min: 0.30% max: 20.00% x̄: 2.83% x̃: 2.12% 95% mean confidence interval for cycles value: 0.17 0.29 95% mean confidence interval for cycles %-change: 1.86% 3.37% Cycles are HURT. total arith in shared programs: 4922.71 -> 4947.71 (0.51%) arith in affected programs: 1423.79 -> 1448.79 (1.76%) helped: 5 HURT: 177 helped stats (abs) min: 0.0416669999999999 max: 0.0833330000000001 x̄: 0.06 x̃: 0 helped stats (rel) min: 0.40% max: 3.17% x̄: 1.82% x̃: 1.67% HURT stats (abs) min: 0.041665999999999315 max: 1.75 x̄: 0.14 x̃: 0 HURT stats (rel) min: 0.30% max: 22.22% x̄: 2.50% x̃: 1.52% 95% mean confidence interval for arith value: 0.11 0.17 95% mean confidence interval for arith %-change: 1.86% 2.90% Arith are HURT. total quadwords in shared programs: 120605 -> 120956 (0.29%) quadwords in affected programs: 26535 -> 26886 (1.32%) helped: 6 HURT: 143 helped stats (abs) min: 1.0 max: 7.0 x̄: 2.83 x̃: 1 helped stats (rel) min: 0.93% max: 6.33% x̄: 2.29% x̃: 1.71% HURT stats (abs) min: 1.0 max: 21.0 x̄: 2.57 x̃: 2 HURT stats (rel) min: 0.34% max: 13.79% x̄: 2.02% x̃: 1.22% 95% mean confidence interval for quadwords value: 1.86 2.86 95% mean confidence interval for quadwords %-change: 1.45% 2.24% Quadwords are HURT. total threads in shared programs: 4670 -> 4669 (-0.02%) threads in affected programs: 2 -> 1 (-50.00%) helped: 0 HURT: 1 Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!14576> (cherry picked from commit 8bd4976d)
-
Obscure encoding restriction. Fixes crash (assertion fail when instruction packing) in asphalt9/2659.shader_test on Bifrost. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!15072> (cherry picked from commit 24d2bdb1)
-
This is a very obscure encoding restriction in the Bifrost ISA. Unknown if any real apps or tests hit this, but we still need to get it right sadly. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!15072> (cherry picked from commit 8e0eb592)
-
When NGG culling is enabled, make sure that the correct primitive ID is exported by each lane. Fixes: e97f0463 "ac/nir: Implement NGG deferred attribute culling in NIR." Closes: mesa/mesa#6050 Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!15055> (cherry picked from commit 3759a16d)
-
according to gfx10SwizzlePattern.h Fixes: 9fabbf21 - ac/surface: copy the HTILE equations to the surface Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!15098> (cherry picked from commit 79a7ab64)
-
Cc: mesa-stable@lists.freedesktop.org Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!15098> (cherry picked from commit 197467c2)
-
Fixes: 5406ad93 "radeonsi: set COMPUTE_DESTINATION_EN_SEn to spi_cu_en" Closes: mesa/mesa#5989 Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!15098> (cherry picked from commit 707a94f3)
-
glXMakeCurrent* may miss release pbuffer if pbuffer is created with refcount=0. This won't happen when pbuffer had different GLX id and X pixmap id. cc: mesa-stable Fixes: bc8a51a7 ("glx: no need to create extra pixmap for pbuffer") Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!14926> (cherry picked from commit bf09c08e)
-
Fixes: 814dc669 ("anv: Allocate surface states per-subpass") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!15081> (cherry picked from commit 037e98a1)
-
This causes the flushed_depth_texture is allocated without multi sample. So the blit will cause VM fault. cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!14990> (cherry picked from commit 80974a5f)
-
Noticed by Ilia. Fixes: f3630548 ("crocus: initial gallium driver for Intel gfx 4-7") Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <mesa/mesa!15100> (cherry picked from commit 0f989a84)
-
Bit is flipped compared to all the other packets. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 70539534 ("intel/fs: Add support for compiling bindless shaders with resume shaders") Fixes: c3ac9afc ("anv: Create and return ray-tracing pipeline SBT handles") Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com> Reviewed-by: Caio Oliveira <caio.oliveira@intel.com> Part-of: <mesa/mesa!15078> (cherry picked from commit 2763a8af)
-
memcpy is divided into chunks that are vec4 sized max. The problem here happens with a structure of 24 bytes : struct { float3 a; float3 b; } If you memcpy that struct, the lowering will emit 2 load/store, one of sized 8, next one sized 16. But both end up located at offset 0, so we effectively drop 2 floats. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: a3177cca ("nir: Add a lowering pass to lower memcpy") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15049> (cherry picked from commit 768930a7)
-
If a secondary command buffer is used and the client provides a framebuffer and that framebuffer has a stencil-only attchment, we would try to get the aux usage for the depth component of that attachment and crash. Check the aspects of the image before looking at aux usage. This fixes at least the following SkQP tests on my Tigerlake: - vk_circular-clips - vk_filterfastbounds - vk_innershapes_bw - vk_lineclosepath - vk_multipicturedraw_rrectclip_simple - vk_pathinvfill - vk_quadclosepath - vk_rrect_clip_bw - vk_windowrectangles Fixes: 0d8b9c52 ("anv: Allow PMA optimization to be enabled in secondary command buffers") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Tested-by: Matt Turner <mattst88@gmail.com> Part-of: <mesa/mesa!15048> (cherry picked from commit df0e2a15)
-
This way we don't run afoul of regioning restrictions around floating point types. Cc: 22.0 <mesa-stable> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15039> (cherry picked from commit 81f97905)
-
Cc: 22.0 <mesa-stable> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15039> (cherry picked from commit 11544435)
-