Skip to content
Snippets Groups Projects
  1. May 31, 2021
  2. May 29, 2021
    • Tim-Philipp Müller's avatar
      rtpjpegpay: fix image corruption when compiled with MSVC on Windows · aa4448cd
      Tim-Philipp Müller authored
      On Windows with MSVC, jpeg_header_size would end up 2 bytes larger
      than it should be. This then leads to the first 2 bytes of the
      actual jpeg image data to be dropped, because we think those
      belong to the header, which results in an undecodable image when
      reconstructed in the depayloader.
      
      What happens is that when the compiler evaluates
      
        jpeg_header_size = mem.offset + read_u16_and_inc_offset_by_2(&mem);
      
      it actually uses the mem.offset value after it has been increased
      by the function call on the right hand size of the equation.
      
      From section 6.5 of the C99 spec:
      
        3. The grouping of operators and operands is indicated by the syntax [74].
           Except as specified later (for the function-call (), &&, ||, ?:, and
           comma operators), the order of evaluation of subexpressions and the
           order in which side effects take place are both unspecified.
      
      Fixes gst-plugins-good#889
      
      Part-of: <gst-plugins-good!999>
      aa4448cd
  3. May 28, 2021
  4. May 27, 2021
  5. May 25, 2021
  6. May 23, 2021
  7. May 21, 2021
  8. May 20, 2021
  9. May 12, 2021
  10. May 11, 2021
  11. May 07, 2021
  12. May 06, 2021
  13. May 05, 2021
  14. Apr 29, 2021
    • Jan Schmidt's avatar
      qtmux: Make sure to write 64-bit STCO table when needed. · 7c5f2185
      Jan Schmidt authored
      qtmux attempts to choose between writing a 32-bit stco chunk offset table
      when it can, but switch to a 64-bit co64 table when file offsets go over
      4GB.
      
      This patch fixes a problem where the atom handling code was checking
      mdat-relative offsets instead of the final file offset (computed by
      adding the mdat position plus the mdat-relative offset) - leading to
      problems where files with a size between 4GB and 4GB+offset-of-the-mdat
      would write incorrect STCO tables with some samples having truncated
      32-bit offsets.
      
      Smaller files write STCO correctly, larger files would switch to
      co64 and also output correctly.
      
      Part-of: <gst-plugins-good!970>
      7c5f2185
  15. Apr 27, 2021
    • Qi Hou's avatar
      v4l2object: Add interlace-mode back to caps for camera · 5e932395
      Qi Hou authored and Nicolas Dufresne's avatar Nicolas Dufresne committed
      skip_try_fmt_probes is set to TRUE for v4l2src to skip interlace-mode and
      colorimetry when probe caps. gst_v4l2_object_set_format_full() will add
      colorimetry back to caps when iterating over the negotiated caps. There is
      one case that v4l2src is first in preview state then starts recording.
      v4l2src caps will change with an additional interlace-mode structure after
      renegotiation, then v4l2src needs to reset. But this camera driver can't
      orphan buffer pool, it causes require buffer failed as streaming is still
      in active state.
      
      To fix this, also need to add interlace-mode back to caps for camera to
      avoid reset.
      
      Part-of: <!961>
      5e932395
  16. Apr 26, 2021
  17. Apr 25, 2021
  18. Apr 24, 2021
    • Håvard Graff's avatar
      rtpjitterbuffer: clean up and improve missing packets handling · 1368b421
      Håvard Graff authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      * Try to make variable and function names more clear.
      * Add plenty of comments describing the logic step-by-step.
      * Improve the logging around this, making the logs easier to read and
        understand when debugging these issues.
      
      * Revise the logic of packets that are actually beyond saving in doing
        the following:
      1. Do an optimistic estimation of which packets can still arrive.
      2. Based on this, find which packets (and duration) are now hopelessly
         lost.
      3. Issue an immediate lost-event for the hopelessly lost and then add
         lost/rtx timers for the ones we still hope to save, meaning that if
         they are to arrive, they will not be discarded.
      
      * Revise the use of rtx-delay:
        Earlier the rtx-delay would vary, depending on the pts of the latest
        packet and the estimated pts of the packet it being issued a RTX for,
        but now that we aim to estimate the PTS of the missing packet accurately,
        the RTX delay should remain the same for all packets.
        Meaning: If the packet have a PTS of X, the delay in asked for a RTX
        for this packet is always a constant X + delay, not a variable one.
      
      * Finally ensure that the chaotic "check-for-stall" tests uses timestamps
        that starts from 0 to make them easier to debug.
      
      Part-of: <gst-plugins-good!952>
      1368b421
  19. Apr 23, 2021
Loading