- Nov 03, 2021
-
-
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch>
-
A few regs were added without changing the size of draw state. Fixes: 4e05338d ("turnip: Rast updates for a6xx gen4") Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <!13644> (cherry picked from commit 79fcd63b)
-
this also enables removing a stupid conditional cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!13631> (cherry picked from commit 675519f1)
-
cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13631> (cherry picked from commit aacdc6eb)
-
VVL already prints its messages using configurable settings. there's no reason for zink to unconditionally repeat them immediately after cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13633> (cherry picked from commit ac2af149)
-
Fixes: e532a47f ("util/hash_table: do not leak u64 struct key") Reviewed-by:
Emma Anholt <emma@anholt.net> Part-of: <!13390> (cherry picked from commit ffd4157b)
-
Lavapipe was hitting asserts in this area due to incorrect bits being specified. Set the handle type depending on the sw flag, and set a correct handle type for the memory host ptrs. v2: add image export struct to image creation (Jason) Fixes: 895d3399 ("lavapipe: add support for KHR_external_memory_fd") Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!13615> (cherry picked from commit a8725ec3)
-
With high likelihood we are forgetting to set the noncoherent bits somewhere but I don't have the HW to debug. To avoid user pain disable this optimization on these GPUs. Closes: #5505 Fixes: fd8210f2 ("radv: Try to do a better job of dealing with L2 coherent images.") Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!13620> (cherry picked from commit d66514aa)
-
Fixes dEQP-VK.reconvergence.*nesting* tests. There are cases when cmod is set to an instruction that cannot have conditional modifier. E.g. following: find_live_channel(32) vgrf166:UD, NoMask cmp.z.f0.0(32) null:D, vgrf166+0.0<0>:D, 0d is optimized to: find_live_channel.z.f0.0(32) vgrf166:UD, NoMask v2: - Add unit test to check cmod is not set to 'find_live_channel' (Matt Turner) - Update flag_subreg when conditonal_mod is updated (Ian Romanick) Signed-off-by:
Vadym Shovkoplias <vadym.shovkoplias@globallogic.com> Closes: #5431 Fixes: 32b7ba66 ("intel/compiler: fix cmod propagation optimisations") Reviewed-by:
Matt Turner <mattst88@gmail.com> Part-of: <!13268> (cherry picked from commit 2dbb6699)
-
vk_device_init already calls vk_error so this is redundant. Also, it makes vk_error grumpy to see a VK_ERROR_FEATURE_NOT_PRESENT on an instance rather than a physical device. Fixes: 47adb111 ("lavapipe: Switch to the new vk_error helpers") Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13619> (cherry picked from commit 79f57f68)
-
these aren't exact matches in spirv, so set the expected result type to float where necessary cc: mesa-stable fixes #5567 Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13562> (cherry picked from commit 73af6788)
-
these come from opcode results, which are not always 32bit cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13562> (cherry picked from commit c73f5a00)
-
this is needed when not creating 1.2 contexts cc: mesa-stable ref #5567 Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13562> (cherry picked from commit 69501ff4)
-
the max driver limit for these is irrelevant if there isn't enough memory to allocate a buffer of that size KHR-GL46.texture_buffer.texture_buffer_max_size cc: mesa-stable fixes #5568 Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13584> (cherry picked from commit ccfe36ff)
-
this is illegal and would fail anyway cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13584> (cherry picked from commit fd2b4728)
-
another thing that used to be needed but now isn't cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13586> (cherry picked from commit aa5e5446)
-
this was probably necessary for some other reason that has since been fixed, and instead now just creates validation spam cc: mesa-stable fixes #5566 Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13586> (cherry picked from commit 8d2280f5)
-
This has a requirement on the display extensions. VK-GL-CTS: dEQP-VK.info.instance_extensions Fixes: 1d574d48 ("lavapipe: remove display extension support") Acked-by:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!13616> (cherry picked from commit 75dc3023)
-
ensure the input attachment gets updated fixes running KHR-GL46.blend_equation_advanced.blend_all.GL_MULTIPLY_KHR_all_qualifier after KHR-GL46.blend_equation_advanced.BlendEquationSeparate cc: mesa-stable Reviewed-by:
Hoe Hao Cheng <haochengho12907@gmail.com> Part-of: <mesa/mesa!13598> (cherry picked from commit 6239adeb)
-
Round and round we go :) In the "drm/i915/adlp/fb: Remove CCS FB stride restrictions" series, https://lists.freedesktop.org/archives/intel-gfx/2021-October/281768.html , it now appears that kernel can allow these modifiers to work with adl-p. This reverts commit d4174f5f. Fixes: d4174f5f ("iris: Disable I915_FORMAT_MOD_Y_TILED_GEN12* on adl-p/display 13") Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Nanley Chery <nanley.g.chery@intel.com> Part-of: <mesa/mesa!13565> (cherry picked from commit 2d041d5f)
-
this is required by spec cc: mesa-stable Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!13585> (cherry picked from commit e8f18385)
-
there's other variants of implicit lod sampling, and none of them are valid outside fragment stage Fixes: 3ad06b69 ("zink: always use explicit lod for texture() when legal in non-fragment stages") Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!13585> (cherry picked from commit 87fbb0ea)
-
Cc: 21.2 21.3 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!13590> (cherry picked from commit 8bfa146b)
-
It was mistakenly disabled, decreasing performance a lot. Only valid for Mesa 21.3. Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Cc: 21.3 <mesa-stable@lists.freedesktop.org> Part-of: <mesa/mesa!13539> (cherry picked from commit 98f696c9)
-
sysctl is the correct way of getting the current executable's path. procfs is not mounted by default. Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Cc: mesa-stable Part-of: <mesa/mesa!1598> (cherry picked from commit 98dbd01a)
-
We were passing a MOCS of 0, which is uncached. Yikes. Fixes: c5b22441 ("iris: Fix buffer -> buffer copy_region") Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!13480> (cherry picked from commit d8cb7621)
-
Otherwise we could get invalid reg in get_reg() Would fix many dEQP-VK.ssbo.phys.layout.* Fixes: 0ffcb19b "ir3: Rewrite register allocation" Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!13546> (cherry picked from commit aa264ded)
-
implicit lod is something else entirely fixes #5566 cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13563> (cherry picked from commit 3ad06b69)
-
this is otherwise just garbage fixes #5569 cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13561> (cherry picked from commit 4d9fc17a)
-
avoid 32bit sint overflows fixes #5568 cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13560> (cherry picked from commit c4a513d9)
-
this check was illegal because the usage bits weren't yet populated, so add another check after usage bits are determined to figure out if CUBE_COMPATIBLE can be applied additionally, checking sample counts was never needed since the spec prohibits CUBE_COMPATIBLE use with multisampling zink DEBUG: ERR: 'Validation Error: [ VUID-vkGetPhysicalDeviceImageFormatProperties-usage-requiredbitmask ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x991b3105 | vkGetPhysicalDeviceImageFormatProperties: value of usage must not be 0. The Vulkan spec states: usage must not be 0 (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-vkGetPhysicalDeviceImageFormatProperties-usage-requiredbitmask) ' Fixes: 71494c48 ("zink: only mark resources as cube-compatible if supported") Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!12580> (cherry picked from commit 2de6beaa)
-
Eric Engestrom authored
-
- Oct 27, 2021
-
-
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch>
-
The original implementation in os_memory_fd.c always uses memfds. Replace this by using the already existing os_create_anonymous_file in order to support older systems or systems without memfd. Fixes: 1166ee9c ("gallium: add utility and interface for memory fd allocations") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!13331> (cherry picked from commit 4856586a)
-
We don't support multiple devices so this is a nop. However, Baldurs Gate 3 enables this and with the new more complete checks this causes device creation to fail. Fixes: 2e5718c9 ("vulkan: provide common functions to check device features") Gitlab: mesa/mesa#5509 Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!13482> (cherry picked from commit 1fe375e7)
-
"I think we want to lower them." -Jason "And I do know how the pass works" Ekstrand fixes #5540 cc: mesa-stable Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <!13489> (cherry picked from commit b0c40bc9)
-
the fs samplemask needs to be updated on framebuffer rebind and on fs bind to ensure that the key gets updated in time for the pipeline change fixes #5559 cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13531> (cherry picked from commit c9ce151f)
-
the uint[1] -> uint dance is only relevant on the first load, so move the variable type shuffling inside the create block to avoid breaking successive loads fixes #5543 cc: mesa-stable Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13488> (cherry picked from commit 8899f6a1)
-
adding the states requires that vertex attribs be bound, but it's illegal to bind 0 attribs cc: mesa-stable fixes #5558 Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13519> (cherry picked from commit 90228a80)
-
spirv doesn't support this fixes #5561 cc: mesa-stable Reviewed-by:
Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!13530> (cherry picked from commit c13da989)
-