Skip to content
Snippets Groups Projects
  1. May 31, 2021
  2. Apr 30, 2021
  3. Apr 24, 2021
  4. Apr 13, 2021
  5. Mar 16, 2021
  6. Mar 15, 2021
  7. Feb 17, 2021
    • Matthew Waters's avatar
      avviddec: take the maximum of the height/coded_height · 1d33d1c8
      Matthew Waters authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      Otherwise, some h.264 streams (particularly with cropping information)
      may cause memory corruption after a renegotiation to a smaller size when
      decoded and then ffmpeg writes past the end of the buffer.
      
      Fixes: gstreamer/gst-libav#80
      Part-of: <gstreamer/gst-libav!110>
      1d33d1c8
    • Matthew Waters's avatar
      viddec: don't configure and incorrect buffer pool when receiving a gap event · f166c9d2
      Matthew Waters authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      Scenario is this:
      1. libav receives enough data to want a buffer with get_buffer2()
         which wants a buffer pool with a certain format, say Y42B but does
         not negotiate and therefore GstVideoDecoder does not have any output
         state configured
      2. A gap event is received which GstVideoDecoder wants to forward.  It
         needs caps to forward the gap event so attempts to negotiate with some
         default information which chooses e.g. I420 and overwrites the
         previously configured bufferpool decided on by get_buffer2()
      3. There is a mismatch between what ensure_internal_pool() check for
         consistency and what decide_allocation() sets when overriding the
         internal pool with the downstream pool.
      4. FFMpeg then requests a Y42B buffer from an I420 pool and predictably
         crashes writing past the contents of the buffer
      
      This is fixed by keeping track of the internal pool states correctly.
      
      Part-of: <gstreamer/gst-libav!116>
      f166c9d2
  8. Feb 03, 2021
  9. Dec 29, 2020
  10. Dec 14, 2020
  11. Nov 04, 2020
  12. Oct 27, 2020
  13. Oct 07, 2020
  14. Oct 06, 2020
  15. Oct 01, 2020
  16. Sep 30, 2020
  17. Sep 15, 2020
  18. Sep 14, 2020
  19. Sep 09, 2020
  20. Sep 08, 2020
  21. Sep 07, 2020
  22. Aug 20, 2020
  23. Aug 04, 2020
  24. Jul 23, 2020
  25. Jul 08, 2020
  26. Jul 06, 2020
  27. Jul 03, 2020
  28. Jul 02, 2020
  29. Jun 30, 2020
Loading