Style updates to include layout structure, side navigation, hidden menu, consolidation of formatting, button effects, and color shift

Oliver Gutierrez authored 4 years ago and Frediano Ziglio committed 4 years ago

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 5 years ago and Frediano Ziglio committed 4 years ago

Browsers have stopped allowing auto play videos.  The documented solution
is to mute your video.  This patch mutes our videos and also attempts to
start playing if the auto play does not fire.

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 5 years ago and Frediano Ziglio committed 4 years ago

If a video covers up a substantial portion of the screen,
you can no longer interact with it.

This change allows pointer events to flow through to our canvas.

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 8 years ago and Frediano Ziglio committed 4 years ago

This does not appear to matter, but let's just be safe.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 8 years ago and Frediano Ziglio committed 4 years ago

This involved a review of the Firefox parsing code along
with the official specifcation, and setting these fields
to the specified default values.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Joel Purra authored 6 years ago and Jeremy White committed 5 years ago

- It seems `SpiceDisplayConn` does not always have the array `this.o.sc.streams` set.
- It also seems (stream?) images can be loaded before `streams` is set.
- Without `streams`, or the specific stream matching `this.o.id`, `this.o.sc.streams[this.o.id].frames_loading` cannot be accessed.
- The check for the specific stream woth `this.o.id` is already in place, this patch adds a check for `this.o.sc.streams` in `handle_draw_jpeg_onload`.
- There might be a better place to ensure that `this.o.sc.streams` is initialized; this quick fix saved my bacon today though.

Might be related to, and perhaps fix:

- https://bugs.freedesktop.org/show_bug.cgi?id=94776
- https://bugzilla.redhat.com/show_bug.cgi?id=1323144



Signed-off-by: Joel Purra <mig@joelpurra.se>

Add the sc object to sendCtrlAltDel because it is otherwise undefined and issues a JS error

See merge request !2

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Uri Lublin <uril@redhat.com>

Jeremy White authored 5 years ago and Frediano Ziglio committed 5 years ago

The previous implementation worked strictly due to a bug which would
luckily generate roughly the right scan codes, although we would send
more codes than required.

For example, the old implementation would send 0xdf48e0 for 'up key down'
and '0xdfc8e0' for 'up key up'.  The prepended 0xdf is incorrect; the
correct values should be 0x48e0 and 0xc8e0.  Essentially, it stored
the bytes in reverse order and had a bug while flipping them.

This code stores them in the order we transmit them which simplifies
the code.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 5 years ago and Frediano Ziglio committed 5 years ago

The common scan codes were disjointed and logically belong together.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 5 years ago and Frediano Ziglio committed 5 years ago

The keypad minus key at 109 is common between at least Chrome and Firefox.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jeremy White authored 5 years ago and Frediano Ziglio committed 5 years ago

Correct a typo from the upstream atKeynames.js at the same time.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

Depending on the structure of the page, the computed mouse position was
not correct. Typically the case happend when there is no offset between
the canvas and the view area, but an offset on the view area.

The MouseEvent.offsetX and offsetY functions are now widely enough spread
to use them and avoid complex computations.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

If we round up, we may end up with a display slightly bigger than what
the window can have, thus adding scroll bars. When rounding down we
avoid this problems.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

The resize_handler need to check for the existence of the message box
before computing it's size.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

In case the user didn't provide any password, we want to prompt him for
it. Try once and if we get an permission denied error, then ask the
password and retry to connect.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

The disconnect() function were not checking the existence of the file
transfer area element, leading to stop the disconnect() before its end.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

To add some more order to the folder, move the JS files into their own
src folder.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

Add package.json needed to publish on npmjs.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

We don't want the users to rely on anything else than main.js. All the
helper functions from the other files are thus imported in main and
exported there too.

This way all the user needs to import is:

    import * as SpiceHtml5 from './main.js';

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

Avoid cluttering the global namespace. Use ES6 modules in order to
to this.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Cédric Bosdonnat authored 6 years ago and Jeremy White committed 6 years ago

When forcing the background of the input fields, this makes them
unreadable for dark themed browsers.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>

spice-html5 does not support multiple display channels, and will only
use the first one offered by spice-server, and ignore the others. This
can cause issues when using a VM with a configured but unused
org.spice-space.stream.0 spice port as this will create a 'fake' display
channel which is offered by spice-server before the usual qxl display
channel.
This commit favours the display channel with id 0 rather than picking
the first one.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Christophe Fergeau authored 6 years ago and Frediano Ziglio committed 6 years ago

log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currently does not deal properly with such bitmaps.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Acked-by: Jeremy White <jwhite@codeweavers.com>

This allows show or hide debug console under spice screen.

Tomáš Bohdálek authored 7 years ago and Jeremy White committed 7 years ago

Make sure to show both screen and console.

Vincent Desprez authored 8 years ago and Jeremy White committed 8 years ago

Signed-off-by: Vincent Desprez <vincent.desprez@apwise.com>