- Jul 22, 2021
-
-
Dylan Baker authored
-
- Jul 21, 2021
-
-
With this pass enabled in Intel drivers, running shader-db on shaders/unity/38.shader_test resulted in Program received signal SIGSEGV, Segmentation fault. gcm_schedule_early_src (src=0x555555d45348, void_state=0x7fffffffba40) at ../../SOURCE/master/src/compiler/nir/nir_opt_gcm.c:297 297 if (info->early_block->index < src_info->early_block->index) (gdb) print src_info->early_block $1 = (nir_block *) 0x0 I tracked this down to an early exit from gcm_schedule_early_instr on the parent instruction because instr->pass_flags was 0x1c. That should be an impossible value for this pass, so I inferred that pass_flags must have dirt left from some previous pass. Fixes: 8dfe6f67 ("nir/GCM: Use pass_flags instead of bitsets for tracking visited/pinned") Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!597> (cherry picked from commit 43666887)
-
It's needed for ptrdiff. Fixes: 59fdaa19 ('aco: reorder and cleanup #includes') Closes: #5076 Reviewed-by:
Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!11947> (cherry picked from commit 1d8e9430)
-
According to the EGL spec, it is entirely valid for an EGLSurface to outlive the native_window it was created from, provided that SwapBuffers and MakeCurrent return EGL_BAD_NATIVE_WINDOW. We don't have any facility to error on MakeCurrent, so just make sure we can bundle on safely through rendering for now, then return EGL_BAD_NATIVE_WINDOW from SwapBuffers. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Simon Ser <contact@emersion.fr> Closes: mesa/mesa#2251 Closes: mesa/mesa#4902 Cc: mesa-stable Part-of: <mesa/mesa!11979> (cherry picked from commit 6455ab6e)
-
We unconditionally require a wl_egl_window to be passed as the native window type, and do not permit a default window. The spec requires us to return EGL_BAD_NATIVE_WINDOW when doing this, rather than crashing. Further, if an EGLSurface has already been created for an existing native window, we are required to return EGL_BAD_ALLOC. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Simon Ser <contact@emersion.fr> Closes: mesa/mesa#2251 Closes: mesa/mesa#4902 Cc: mesa-stable Part-of: <mesa/mesa!11979> (cherry picked from commit 0e2464d2)
-
Make sure that the host is using llvmpipe while the guest is using virgl as driver. Note that the neverball/neverball.trace trace actually regressed in a way that the foreground is missing. Fixes: f1b952fa ("ci: Run tests inside Crosvm") Signed-off-by:
Corentin Noël <corentin.noel@collabora.com> Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!11986> (cherry picked from commit 18fa8205) Conflicts: src/gallium/drivers/virgl/ci/traces-virgl.yml
-
This should fix some texturing problems seen on gen4/5, I reproduced it with a minecraft.trace file Fixes: f3630548 ("crocus: initial gallium driver for Intel gfx 4-7") Part-of: <mesa/mesa!11993> (cherry picked from commit 8c6196e7)
-
Fixes: 9b40fc48 Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!11920> (cherry picked from commit 4c36224f)
-
Like in the case of emitting a block, process pending TMU operations before a jump is executed. Fixes dEQP-VK.graphicsfuzz.stable-binarysearch-tree-nested-if-and-conditional. Fixes: 197090a3 ("broadcom/compiler: implement pipelining for general TMU operations") Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!11971> (cherry picked from commit dc401578)
-
This fixes CPU read performance. Closes: mesa/mesa#5091 Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!11974> (cherry picked from commit 54e1ec01)
-
The function radeonsi_screen_create_impl() tries to create the aux_context but doesn't actually check for the returned value from si_create_context(). Then, on si_destroy_screen() the aux_context is used without actually checking whether it's a thing or not. As a result, if for any reason si_create_context() failed, we shall crash in si_destroy_screen() with a NULL pointer dereference trying to access ((struct si_context *)sscreen->aux_context)->log. Simply check for aux_context not being NULL to avoid that crash. Cc: mesa-stable Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!11948> (cherry picked from commit 5bfd1a7e)
-
According to the comment below some extra magic is needed for bindless samplers, so don't do an early return in this case. Fixes: 736f1f70 ("mesa: skip redundant uniform updates for glUniform") Closes: mesa/mesa#4806 Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!11930> (cherry picked from commit 8be61e8a)
-
Packed constants with non-zero values in the high half might have been propagated as 16 bit, dropping the high half. Cc: mesa-stable Closes: #5070 Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!11954> (cherry picked from commit 9b1a2961)
-
To enable dual 4k displays on mutter or gnome-shell under X11 we need to expose the non-MSAA texture limit as we did for Xorg at 60a64f02 ("v3d: Use driconf to expose non-MSAA texture limits for Xorg.") https://gitlab.gnome.org/GNOME/mutter/-/issues/1874 Cc: 21.1 21.2 mesa-stable Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!11926> (cherry picked from commit fd5fa73e)
-
Originally I fixed the case where the nir itself has a shared mem size of 0, but the frontend (e.g. clover) set it to some other value. But st/mesa sets the shared mem size on the state object as well and we end up actually doubling the value in the driver as we set smemSize to the value from the state object before calling into the compiler. So just max the value instead. Fixes the compute_shader.shared-max CTS test. Fixes: dc667b1f ("nv50/ir/nir: fix smem size") Signed-off-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!11047> (cherry picked from commit ff55412f)
-
I've read the papers on EWA filters and it seems like the calculate DDQ = 2 * A after the scaling of A happens. This seems to make things less blurry and more like real aniso. Fixes: 2135aba8 ("softpipe: Constify variables") Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!11917> (cherry picked from commit 57dcfb4e)
-
This replaces some new/delete uses with malloc/free. This is more consistent with most of the other glsl IR code but more importantly it allows the game "Battle Block Theater" to start working on some mesa drivers. The game overrides new and ends up throwing an assert and crashing when it sees this function calling new [0]. Note: The game still crashes with radeonsi due to similar conflicts with LLVM. CC: mesa-stable Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!11907> (cherry picked from commit 74925139)
-
Fixes: 4566383a ("gallium: move pipe_draw_info::index_bias to pipe_draw_start_count_bias") Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!11939> (cherry picked from commit ed57666a)
-
Fixes: eca6bb95 ("util/fossilize_db: add basic fossilize db util to read/write shader caches") Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!11931> (cherry picked from commit 2850db0a)
-
Fixes: 790ff1ce ("anv: fixup physical device properties of fragment shading rate") Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!11897> (cherry picked from commit d27f7fa1)
-
Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!11900> (cherry picked from commit 86ff5b7d)
-
Dylan Baker authored
-
Fixes: 78c8a8af "freedreno: Generate device-info tables at build time" Closes: mesa/mesa#5060 Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!11928> (cherry picked from commit 53d4485a)
-
Error handling with DRM_IOCTL_I915_QUERY is tricky and we got it wrong in one of the two calls here. Use the common helper instead. This also fixes a theoretical bug where calloc() fails. While we're here, inline iris_bufmgr_update_meminfo because we're not really benefiting from having it separate anymore. Fixes: e60114b2 "iris/bufmgr: Query memory region info." Reviewed-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!11770> (cherry picked from commit 3fa6b8d0)
-
Error handling with DRM_IOCTL_I915_QUERY is tricky and we got it wrong in one of the two calls here. Use the common helper instead. This also fixes a theoretical bug where calloc() fails. While we're here, inline anv_track_meminfo because we're not really benefiting from having it separate anymore. Fixes: 65e8d72b "anv: Query memory region info" Reviewed-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!11770> (cherry picked from commit 35ec1d97)
-
We also add a helper which contains the standard query+alloc+query pattern used by anv_gem_get_engine_info(). The caller is required to free the pointer. These are declared static inline not because we care about the performance of these helpers but because we're going to use them in the intel_device_info code and we don't want a link dependency. Reviewed-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!11770> (cherry picked from commit ffdf4d76)
-
- Jul 16, 2021
-
-
DRM_IOCTL_I915_QUERY is a multi-query. The most egregious errors are returned via the usual ioctl error mechanism but there are also per-query errors that are indicated by item.length < 0. We need to handle those as well. While we're at it, scrape errno so we can return a proper integer error. Fixes: c0d07c83 "anv: Support i915 query (DRM_IOCTL_I915_QUERY)..." Reviewed-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!11770> (cherry picked from commit b664481b)
-
NGG culling is not compiled into shaders that can use multiple viewports, so it's not necessary to check it here. Fixes: 9a95f548 Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!11910> (cherry picked from commit d07e5bde)
-
We don't support NGG culling with multiple viewports yet. Fixes: f30e4351 Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!11910> (cherry picked from commit aa247403)
-
It implicitly contains the number of threads via the CURBE allocation size field. Fixes: 33c61eb2 "iris: Implement ARB_compute_variable_group_size" Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!10640> (cherry picked from commit e56d5db3)
-
The Vulkan spec has been updated few months ago again and pNext is always honored if present. Found this with vkd3d-proton which implemented separate depth/stencil layouts recently. Cc: 21.2 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!11903> (cherry picked from commit 0b637919)
-
On APUs, we fake heaps to simulate a dGPU setup because it seems to have the maximum compatibility. Though, some applications like RDR2 still only looks at GTT if the driver reports an iGPU which means it will only use 1/3rd of total memory available. This is currently behind a drirc option because it might have implications for other apps but we might want to extend this later if everything is fine. Cc: 21.2 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!11891> (cherry picked from commit cadf2d63)
-
GFX6 and GFX10+ have similar logic. This fixes test_zero_vertex_stride from vkd3d-proton on Pitcairn (GFX6) and on Bonaire (GFX7). Cc: 21.2 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!11904> (cherry picked from commit 7a1cc56e)
-
We don't explicitly calloc the wsi_wl_image to zero; anything that's expected to be valid needs to be explicitly initialised. Closes: mesa/mesa#5063 Fixes: 6b36f357 ("vulkan/wsi/wl: add wl_shm support for lavapipe.") Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
Dave Airlie <airlied@redhat.com> Tested-by:
Jan Beich <jbeich@freebsd.org> Part-of: <mesa/mesa!11909> (cherry picked from commit 49a7c927)
-
If we have a multi draw then the draw_id needs to get reset between each instance. Fixes the rest of the VK CTS multidraw tests Fixes: ce0b1f23 ("aux/draw: track increment_draw_id value from draw info") Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!11899> (cherry picked from commit b3d2642c)
-
Dylan Baker authored
-
- Jul 15, 2021
-
-
Fix defect reported by Coverity Scan. Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking so suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Fixes: dcd2d8ca ("asahi: Track more Gallium state") Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Part-of: <mesa/mesa!11898> (cherry picked from commit f5c8761e)
-
We forgot to remove the v3dvx code for the clearing code fallbacks we removed after we implemented layered clears. Fixes: 5ba7f64b ('v3dv: remove fallback path for vkCmdClearAttachments') Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!11902> (cherry picked from commit 18642987)
-
With separate depth/stencil layouts, if the depth aspect is first initialized and then cleared, the ZRANGE_PRECISION metadata might be different than 0. Initializing it again for the stencil aspect will overwrite the value. Fixes rendering glitches with Scarlet Nexus on GFX8-9. Closes: mesa/mesa#5052 Cc: 21.1 21.2 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!11883> (cherry picked from commit 1ea156f4)
-
12128fb1 marked fp16 vertex formats supported, but they aren't actually handled by lima_pipe_format_to_attrib_type(). Fix it by handling it there. FP16 seems to be the only missing index which is 0x3. Fixes: 12128fb1 ("lima: add natively supported vertex buffer formats") Cc: 21.1 mesa-stable Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Signed-off-by:
Vasily Khoruzhick <anarsoul@gmail.com> Part-of: <mesa/mesa!11872> (cherry picked from commit 4a3269df)
-