Youness Alaoui authored 10 years ago and Olivier Crête committed 10 years ago

When using optimal path where recv message has only one buffer, the
buffer length was set to the size of the buffer, not its length, which was
causing the wrong message length to be returned causing the agent to
discard STUN messages because their size doesn't match received data
length.

This introduces no functional changes, but consolidates and documents
the code a bit more.

Use a NULL check to determine if upnp_mapping is an empty list (rather
than counting every element). Use g_slist_free_full() where appropriate.

This introduces no functional changes.

It’s in milliseconds.

The test for fe80::/10 always returned FALSE.

But keep the turn connection that's currently being used if it is
the selected candidate. Also clear the TURN candidate refresh.

Instead of just blindling assuming that all of the pointers are valid
until the end.

Change the SocketSource handling to make it possible
to remove a source, not only to add one.

It can now take it from the agent.

Skips one iterator over g_slist_foreach() + g_slist_free(). It is also easier
to read.

It is never used outside of this file.

Youness Alaoui authored 10 years ago and Olivier Crête committed 10 years ago

If doing a recv on UDP-TURN, the 'from' address was kept set to
the turn server which causes connchecks to fail with "mismatched address"
error. This fixes it

Nice to make debug logs more friendly to read.

Philip Withnall authored 10 years ago and Olivier Crête committed 10 years ago

If an incoming ACK acknowledges part of a pending SSegment, correctly
increment the base offset of that SSegment before attempting to transmit
it. Otherwise, the wrong data will be transmitted and the offset passed
to packet() will be incorrect.

Philip Withnall authored 10 years ago and Olivier Crête committed 10 years ago

If a packet has an invalid tsecr field, invalid (e.g. negative) RTTs may
be calculated from it. If so, discard the packet as invalid.