- Aug 10, 2022
-
-
Dylan Baker authored
-
Dylan Baker authored
This reverts commit bc9e9c39. Buggy script created a buggy patch. Sorry for the commotion
-
Dylan Baker authored
-
Closes #6968 Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Suggested-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Tested-by: Prodea Alexandru-Liviu <liviuprodea@yahoo.com> Part-of: <mesa/mesa!17889> (cherry picked from commit b6fb2da6)
-
And don't enable nir_opt_if_optimize_phi_true_false on radeonsi with LLVM 14 because it crashes Blender. Closes: mesa/mesa#6976 Cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Acked-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!17949> (cherry picked from commit 70891edd)
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: 897561b7 ("aco: add aco_postprocess_shader() helper") Part-of: <mesa/mesa!17954> (cherry picked from commit bd40e1b0)
-
Without this, we might end up trying to use VK_FORMAT_D32_SFLOAT_S8_UINT even when it's not supported... Cc: mesa-stable Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17953> (cherry picked from commit 3340dea1)
-
This will be reused in the following commit. Cc: mesa-stable Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17953> (cherry picked from commit 71c1ca3c)
-
Trivial. Fixes: ed77ac1e ("svga: add a helper function for common shader creation") Part-of: <mesa/mesa!17971> (cherry picked from commit aa5d4062)
-
With the switch to common dynamic state tracking, something got lost that made the scissors not always be emitted when they are not dynamic and the pipeline is marked dirty. Since both viewport and scissors make use of each other to calculate their values, just stick the scissor emit in the same if block as viewport for now. I'd rather have them decoupled, and at least the Vulkan CTS didn't complain when I tried it, but I don't know what other effects that may have, especially when it comes to the guardband. Fixes a bunch of tests under dEQP-VK.pipeline.*.multisample.misc.* Fixes: 7d25c042 ("anv: Switch to using common dynamic state tracking") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17964> (cherry picked from commit fbd41337)
-
For external image imports, we'd lose the mutable image format list, causing turnip to get angry that we try to do UBWC despite not having a UBWC-compatible format list. Cc: mesa-stable Fixes: 28ee911a ("zink: handle mutable swapchain images with dmabuf") Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17900> (cherry picked from commit 8dda0a01)
-
Dylan Baker authored
-
Otherwise OpenCLon12 ICD can't load it Ref: https://github.com/microsoft/OpenCLOn12/search?q=clon12compiler Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Yonggang Luo <luoyonggang@gmail.com> (cherry picked from commit 25e2c4d7) Part-of: <mesa/mesa!17886>
-
- Aug 09, 2022
-
-
The driver should still gather XFB info even if all XFB outputs are dead, otherwise the pipeline can't find the streamout shader. RADV should use vk_spirv_to_nir() at some point to reduce code duplication during SPIRV->NIR compilation. This fixes new dEQP-VK.transform_feedback.simple.*. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17939> (cherry picked from commit e95531e1)
-
Fixes: 90b98c06 ("amd/tmz: move uses_secure_bos to radeon_winsys") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <!11449> (cherry picked from commit a693fbf6)
-
Dylan Baker authored
-
- Aug 08, 2022
-
-
Fixes: 6897266c ("docs: import virgl docs") Acked-by: Chia-I Wu <olvaffe@gmail.com> Part-of: <mesa/mesa!17881> (cherry picked from commit 1a3b086b)
-
We can't invalidate CCU if there is any dirty data that hasn't been flushed yet. In the case where we clear depth, we know that the depth attachment itself isn't dirty but there may be dirty data from other renderpasses. Therefore we need to flush before invalidating depth. Fixes: 487aa807 ("tu: Rewrite flushing to use barriers") Closes: #6987 Part-of: <mesa/mesa!17940> (cherry picked from commit a7e64ab6)
-
For example, "DS -> branch -> VMEM -> branch -> DS". fossil-db (navi10): Totals from 639 (0.40% of 161220) affected shaders: Instrs: 629090 -> 628254 (-0.13%); split: -0.19%, +0.06% CodeSize: 3410164 -> 3406748 (-0.10%); split: -0.14%, +0.04% Latency: 7834755 -> 7821011 (-0.18%); split: -0.70%, +0.52% InvThroughput: 1369698 -> 1374495 (+0.35%); split: -0.12%, +0.47% A lot of the fossil-db changes are noise. threekingdoms.8db138826c386a62.1.foz/0b222ed175eebad0 is an example of a shader that actually has this issue. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Fixes: c037ba1b ("aco/gfx10: Mitigate LdsBranchVmemWARHazard.") Part-of: <mesa/mesa!17697> (cherry picked from commit b17e59a0)
-
This might break out-of-order rasterization on GFX8-GFX9 because it relies on the stencil write mask which can be dynamic. Found by inspection. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!17673> (cherry picked from commit 20122460)
-
This reverts commit 96fa23bc. The correct fix to the problem was a1bc1523, making this change obsolete as the pass skips any vars marked with always_active_io. There was no real advantage to allowing these vars to be split because they can't be removed anyway. Also there is no way to split varying arrays gracefully here due to the xfb layout rules, and this change didn't handle arrays at all. Removing this obsolete code also fixes an assert in the new CTS test KHR-Single-GL45.enhanced_layouts.xfb_all_stages. The test was legally adding xfb offsets to all vertex stages but since we only mark the varyings in the final vertex stage with the always_active_io flag the other stages were correctly lowering to scalars but when an array with an offset hit this code it asserted since it couldn't handle it. Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Fixes: a1bc1523 ("spirv: mark variables decorated with XfbBuffer as always active") Closes: mesa/mesa#6928 Part-of: <mesa/mesa!17878> (cherry picked from commit 8bffd601)
-
Typo in the handwritten packing code, oof! Fixes incorrectly repeated shadows in Neverball (among many other bugs, I assume). Huge thanks to Lina for the idea that this was the bug -- fixing it was a breeze from there :-) Fixes: 9f555388 ("agx: Pack texture ops") Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Suggested-by: Asahi Lina <lina@asahilina.net> Part-of: <mesa/mesa!17198> (cherry picked from commit 47a3f122)
-
Cc: mesa-stable Closes: mesa/mesa#5740 Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!14208> (cherry picked from commit abc4eda8)
-
OpenGL API calls like glClearBufferData() result in mapping/unmapping of a given buffer by Mesa and unmapping of a host blob fails in virglrenderer because VirGL driver uses command that is intended for unmapping of a guest buffer. In particular this causes problem for the "Total War: Warhammer" game that gets GL_OUT_OF_MEMORY error due to the failed unmapping command. Fix this by setting the mapping usage flag in accordance to the resource flags, allowing virgl_buffer_transfer_unmap() to differentiate host buffer from guest. Fixes: 3b54e583 ("virgl: support PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT") Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Part-of: <mesa/mesa!17914> (cherry picked from commit 46396e97)
-
Fix typo in calculation of position of start of a row of tiles. This could otherwise cause an out-of-bounds access in the next patch. Fixes: 81d85be9 freedreno/gmem: Reverse order of alternative tile rows Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!17888> (cherry picked from commit 2497741a)
-
Keep the list head valid (empty) after allocation from bo cache. Avoids a potential later crash in lookup_bo in the following sequence: 1. alloc, bo cache hit 2. export 3. re-import Cc: mesa-stable Fixes: f3cc0d27 ("freedreno: import libdrm_freedreno + redesign submit") Closes: mesa/mesa#6988 Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!17888> (cherry picked from commit 8b3f2a9e)
-
Dylan Baker authored
-
This extension introduces a new layout which allows applications to both render and sample from the same image inside the same draw (aka. feedback loops). Previously, the GENERAL layout was used and this introduced some rendering artifacts because the hw can't read&write DCC/HTILE for the same image, and we try to keep it compressed on GFX10+. This helps fixing corruption with D3D9 and RPCS3 games which are candidate for feedback loops. Closes: mesa/mesa#4411 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!17883>
-
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!17883>
-
Mike Blumenkrantz authored
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17883>
-
- Aug 05, 2022
-
-
Just got into a midnight discussion with a hw guy. TC_ACTION_ENA apparently doesn't invalidate L1, so don't clear the INV_VCACHE flag. Fixes: 4056e953 - radeonsi: move emit_cache_flush functions into si_gfx_cs.c Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17902> (cherry picked from commit 279315fd)
-
We're missing a condition that is currently papered over by having ANV_PIPE_HDC_PIPELINE_FLUSH_BIT in the invalidate bits. v2: rework with simplication (Caio) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Caio Oliveira <caio.oliveira@intel.com> Part-of: <mesa/mesa!16905> (cherry picked from commit 5e21f474)
-
Otherwise VC4_DEBUG does not work. Fixes: c3f5d276 ("vc4/v3d: restore calling debug_get_option_vc4/v3d_debug") Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Reviewed-by: Eric Engestrom <eric@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!17882> (cherry picked from commit 644daa97)
-
These shouldn't be accessed, and shows up as an uninit access in valgrind with piglit rasterpos Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!10641> (cherry picked from commit 5449e6d1)
-
this is broken, and these will never need to be fixed Fixes: 3a475766 ("zink: add a compiler pass to match up tex op dest types") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit 32446f51)
-
adding LINEAR before was a good starter step, but LINEAR might not actually be supported (e.g., nvidia) cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit 247b8f29)
-
cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit 5e8ec87b)
-
cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit c824a53f)
-
this is effectively the same as LINEAR, and it still allows dmabuf creation cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit b59eb9c8)
-
this has a return code, and if it return false, this is probably an exit condition cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit 188721d6)
-