Revert "nir: Preserve offsets in lower_io_to_scalar_early"
This reverts commit 96fa23bc. The correct fix to the problem was a1bc1523, making this change obsolete as the pass skips any vars marked with always_active_io. There was no real advantage to allowing these vars to be split because they can't be removed anyway. Also there is no way to split varying arrays gracefully here due to the xfb layout rules, and this change didn't handle arrays at all. Removing this obsolete code also fixes an assert in the new CTS test KHR-Single-GL45.enhanced_layouts.xfb_all_stages. The test was legally adding xfb offsets to all vertex stages but since we only mark the varyings in the final vertex stage with the always_active_io flag the other stages were correctly lowering to scalars but when an array with an offset hit this code it asserted since it couldn't handle it. Acked-by:Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Fixes: a1bc1523 ("spirv: mark variables decorated with XfbBuffer as always active") Closes: mesa/mesa#6928 Part-of: <mesa/mesa!17878>
- src/compiler/nir/nir_lower_io_to_scalar.c 0 additions, 8 deletionssrc/compiler/nir/nir_lower_io_to_scalar.c
- src/gallium/drivers/llvmpipe/ci/llvmpipe-fails.txt 0 additions, 3 deletionssrc/gallium/drivers/llvmpipe/ci/llvmpipe-fails.txt
- src/intel/ci/iris-amly-fails.txt 0 additions, 3 deletionssrc/intel/ci/iris-amly-fails.txt
- src/intel/ci/iris-apl-fails.txt 0 additions, 3 deletionssrc/intel/ci/iris-apl-fails.txt
- src/intel/ci/iris-cml-fails.txt 0 additions, 3 deletionssrc/intel/ci/iris-cml-fails.txt
- src/intel/ci/iris-glk-fails.txt 0 additions, 3 deletionssrc/intel/ci/iris-glk-fails.txt
- src/intel/ci/iris-kbl-fails.txt 0 additions, 3 deletionssrc/intel/ci/iris-kbl-fails.txt
- src/intel/ci/iris-whl-fails.txt 0 additions, 3 deletionssrc/intel/ci/iris-whl-fails.txt