- Aug 17, 2022
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Aug 16, 2022
-
-
When primitive is points, EndPrimitive can't be used to count primitive. Need to use vertex count instead. And it's also not needed to do vertex per primitive count and overwrite incomplete primitive work for points. Fixes: 2be99012 ("nir: Add ability to count emitted GS primitives.") Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!17805> (cherry picked from commit 84956286)
-
The validation layers complained: > Validation Error: [ VUID-VkPhysicalDeviceGroupProperties-sType-sType ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xc9edee8b | vkEnumeratePhysicalDeviceGroups: parameter pPhysicalDeviceGroupProperties[0].sType must be VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_GROUP_PROPERTIES The Vulkan spec states: sType must be VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_GROUP_PROPERTIES (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkPhysicalDeviceGroupProperties-sType-sType ) Signed-off-by: Eric Engestrom <eric@igalia.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Fixes: c196ffac ("vk-device-select: add device group support") Part-of: <mesa/mesa!18037> (cherry picked from commit 45884538)
-
TEX instrutions can't write xyz and w to separate registers so we need to create variables from them first, otherwise we can create two variables from ALU writing the same register xyz and w in other branch (this usually works when TEX is not present as the xyz and w can read/write from different registers). This fixes regalloc because the variables are later used as a graph nodes. The variable order should not matter but it slightly does (leading to approx 0.3% shader-db temps increase as compared to previous state), so just sort the variables list afterwards to be as close to the previous behavior as possible and prevent the regression. CC: mesa-stable Closes: mesa/mesa#6936 Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Filip Gawin <filip@gawin.net> Part-of: <mesa/mesa!17987> (cherry picked from commit 88fd397c)
-
For post-transformed vertices, w = 0 is similar to w = 1. Replace the value to fix rcp(w). It is common for apps to pass w = 0 for position_t. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit b5df2056)
-
Due to the driver live shader cache, it's possible two different d3d9 shaders get the same cso. As it's disallowed to destroy a shader cso being bound, nine checks for this scenario. However it was not taking into account the cso might be from a different shader. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit 93da6e9f)
-
Invalidating all state groups is not sufficient, as some states check for actual changes. The correct way is to invalidate the commit mask. Found with a wine test. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit 4c65ccab)
-
The previous code was incorrectly checking the previous value of alphatestenable. In addition, remove an optimization that cannot hit (as we filter out redundant state settings). cc: mesa-stable Fixes: 1272640d ("st/nine: Fix alpha to coverage states") Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit 4f953ad5)
-
Fixes a crash in a ffxi trace, which draws out of bounds. This was previously resulting in trying to fill a buffer resource not big enough. cc: mesa-stable Fixes: 380c2bf8 ("st/nine: Optimize dynamic systemmem buffers") Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit e5124e83)
-
Without this it may crash running wine tests. According to the test themselves, the correct behaviour is a bit more complicated, but that's a first step. cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Acked-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!18021> (cherry picked from commit b74febff)
-
Dylan Baker authored
-
just like clover Closes: #5666 Fixes: 1506ea2e ("Move a bunch of the CLC stuff from src/microsoft to common code") Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <!17682> (cherry picked from commit b5b85514)
-
Dylan Baker authored
-
- Aug 12, 2022
-
-
Currently the sb.MOCS is being reset to zero after struct init. Signed-off-by: sjfricke <spencerfricke@gmail.com> Fixes: c27fcb1d ("isl: Fill in MOCS for NULL depth, stencil, and HiZ buffers.") Reviewed-by: Nanley Chery <nanley.g.chery@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <!17985> (cherry picked from commit 861167f4)
-
Deleted buffers were not unbound in glthread. Fixes: 4fa24747 - glthread: call _mesa_glthread_BindBuffer unconditionally Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!17976> (cherry picked from commit 28e35167)
-
Tests: dEQP-GLES2.functional.lifetime.delete_bound.framebuffer dEQP-GLES2.functional.state_query.integers.framebuffer_binding_getinteger Fixes: e48f6768 - glthread: don't sync for more glGetIntegerv enums for glretrace Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!17976> (cherry picked from commit eb4036ea)
-
The nir shader memory is freed in nir_to_tgsi(), but the already freed shader info is referenced later when create compute state. To avoid referencing the freed memory, copy the shader info first before calling nir_to_tgsi. Fixes vmx crash running aztec on SVGA driver. Fixes: 580f1ac4 ("nir: Extract shader_info->cs.shared_size out of union") Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!17999> (cherry picked from commit 4393be82)
-
Dylan Baker authored
-
- Aug 11, 2022
-
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: mesa/mesa#7013 Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17945> (cherry picked from commit 56bb29cb)
-
Fixes: 3415bf02 ("egl: Add a basic Windows driver") Suggested-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Daniel Stone <daniels@collabora.com> Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Sidney Just <justsid@x-plane.com> Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!12964> (cherry picked from commit 17eda68d)
-
Fixes: 3415bf02 ("egl: Add a basic Windows driver") Suggested-by: Yonggang Luo <luoyonggang@gmail.com> Acked-by: Daniel Stone <daniels@collabora.com> Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Sidney Just <justsid@x-plane.com> Acked-by: Jason Ekstrand <jason.ekstrand@collabora.com> Tested-by: Yonggang Luo <luoyonggang@gmail.com> Part-of: <mesa/mesa!12964> (cherry picked from commit efd2ae6c)
-
this is the "default" size that's expected cc: mesa-stable Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!17874> (cherry picked from commit b7eda568)
-
Dylan Baker authored
-
Without this, we might end up trying to use VK_FORMAT_D32_SFLOAT_S8_UINT even when it's not supported... Cc: mesa-stable Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17953> (cherry picked from commit 3340dea1)
-
This will be reused in the following commit. Cc: mesa-stable Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17953> (cherry picked from commit 71c1ca3c)
-
For external image imports, we'd lose the mutable image format list, causing turnip to get angry that we try to do UBWC despite not having a UBWC-compatible format list. Cc: mesa-stable Fixes: 28ee911a ("zink: handle mutable swapchain images with dmabuf") Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!17900> (cherry picked from commit 8dda0a01)
-
Fixes: 90b98c06 ("amd/tmz: move uses_secure_bos to radeon_winsys") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!11449> (cherry picked from commit a693fbf6)
-
Fixes: 6897266c ("docs: import virgl docs") Acked-by: Chia-I Wu <olvaffe@gmail.com> Part-of: <mesa/mesa!17881> (cherry picked from commit 1a3b086b)
-
We can't invalidate CCU if there is any dirty data that hasn't been flushed yet. In the case where we clear depth, we know that the depth attachment itself isn't dirty but there may be dirty data from other renderpasses. Therefore we need to flush before invalidating depth. Fixes: 487aa807 ("tu: Rewrite flushing to use barriers") Closes: #6987 Part-of: <mesa/mesa!17940> (cherry picked from commit a7e64ab6)
-
For example, "DS -> branch -> VMEM -> branch -> DS". fossil-db (navi10): Totals from 639 (0.40% of 161220) affected shaders: Instrs: 629090 -> 628254 (-0.13%); split: -0.19%, +0.06% CodeSize: 3410164 -> 3406748 (-0.10%); split: -0.14%, +0.04% Latency: 7834755 -> 7821011 (-0.18%); split: -0.70%, +0.52% InvThroughput: 1369698 -> 1374495 (+0.35%); split: -0.12%, +0.47% A lot of the fossil-db changes are noise. threekingdoms.8db138826c386a62.1.foz/0b222ed175eebad0 is an example of a shader that actually has this issue. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Fixes: c037ba1b ("aco/gfx10: Mitigate LdsBranchVmemWARHazard.") Part-of: <mesa/mesa!17697> (cherry picked from commit b17e59a0)
-
Typo in the handwritten packing code, oof! Fixes incorrectly repeated shadows in Neverball (among many other bugs, I assume). Huge thanks to Lina for the idea that this was the bug -- fixing it was a breeze from there :-) Fixes: 9f555388 ("agx: Pack texture ops") Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Suggested-by: Asahi Lina <lina@asahilina.net> Part-of: <mesa/mesa!17198> (cherry picked from commit 47a3f122)
-
OpenGL API calls like glClearBufferData() result in mapping/unmapping of a given buffer by Mesa and unmapping of a host blob fails in virglrenderer because VirGL driver uses command that is intended for unmapping of a guest buffer. In particular this causes problem for the "Total War: Warhammer" game that gets GL_OUT_OF_MEMORY error due to the failed unmapping command. Fix this by setting the mapping usage flag in accordance to the resource flags, allowing virgl_buffer_transfer_unmap() to differentiate host buffer from guest. Fixes: 3b54e583 ("virgl: support PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT") Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Part-of: <mesa/mesa!17914> (cherry picked from commit 46396e97)
-
Keep the list head valid (empty) after allocation from bo cache. Avoids a potential later crash in lookup_bo in the following sequence: 1. alloc, bo cache hit 2. export 3. re-import Cc: mesa-stable Fixes: f3cc0d27 ("freedreno: import libdrm_freedreno + redesign submit") Closes: mesa/mesa#6988 Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!17888> (cherry picked from commit 8b3f2a9e)
-
Just got into a midnight discussion with a hw guy. TC_ACTION_ENA apparently doesn't invalidate L1, so don't clear the INV_VCACHE flag. Fixes: 4056e953 - radeonsi: move emit_cache_flush functions into si_gfx_cs.c Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17902> (cherry picked from commit 279315fd)
-
We're missing a condition that is currently papered over by having ANV_PIPE_HDC_PIPELINE_FLUSH_BIT in the invalidate bits. v2: rework with simplication (Caio) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Caio Oliveira <caio.oliveira@intel.com> Part-of: <mesa/mesa!16905> (cherry picked from commit 5e21f474)
-
These shouldn't be accessed, and shows up as an uninit access in valgrind with piglit rasterpos Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!10641> (cherry picked from commit 5449e6d1)
-
adding LINEAR before was a good starter step, but LINEAR might not actually be supported (e.g., nvidia) cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit 247b8f29)
-
cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit 5e8ec87b)
-
cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!17775> (cherry picked from commit c824a53f)
-