- Jun 10, 2020
-
-
Eric Engestrom authored
-
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch>
-
This is needed otherwise it can cause bad rendering of UYVY files. The align(..., 256 / surf->bpe) constraint comes from addrlib. Fixes: 69aadc49 ("radeonsi: fix surf_pitch for subsampled surface") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!5314> (cherry picked from commit 8275dc1e)
-
Fixes: ba10fb3f ("radeonsi: preserve the scanout flag for shared resources on gfx9 and gfx10") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5314> (cherry picked from commit e9826a1b)
-
In case shader contains two equal macro defines, first one with trailing spaces and the second one without. `#define A 1 ` `#define A 1` The parser crashes Fixes: 0346ad37 ("glsl: ignore trailing whitespace when define redefined") Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Signed-off-by:
Andrii Simiklit <andrii.simiklit@globallogic.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5312> (cherry picked from commit 2c711beb)
-
Unreal Engine 4 has a bug in usage of glDrawRangeElements, causing it to be called with a number of vertices in place of "end" parameter (which specifies the maximum array index contained in indices). Since there is unknown amount of games affected and we could not identify that a game is built with UE4 - we are forced to make a blanket workaround, disregarding max_index in range calculations. Fortunately all such calls look like: glDrawRangeElements(GL_TRIANGLES, 0, 3, 3, ...); So we are able to narrow down this workaround. This was uncovered after b684030c broke a bunch of UE4 games. Cc: 20.1 <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2917 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!5203> (cherry picked from commit a7510512)
-
Using a util_hash_table_create_ptr_keys to store bo->va address doesn't work on 32 bits. This commit makes radeon_drm_winsys::bo_vas a hash_table_u64 instead. Tested by Miklós Máté. CC: 20.1 <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#3056 Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5380> (cherry picked from commit db57624c)
-
The current "ds = state->bs" seems broken, and the "vs = state->bs" is unnecessary (already set above). Since it was added as part of a GS-related patch, I think this is what was intended. Note: tesselation disables GMEM rendering so we shouldn't have to worry about hs/ds + binning interaction. Fixes: 0eebedb6 ("freedreno/a6xx: Emit program state for GS") Signed-off-by:
Jonathan Marek <jonathan@marek.ca> Part-of: <mesa/mesa!5370> (cherry picked from commit 6cc95abb)
-
glsl_to_nir doesn't expect non-vector/scalar return types in functions. Fixes: 7e60d5a5 Closes: mesa/mesa#3058 Closes: mesa/mesa#3060 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Tested-by:
Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by:
Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!5333> (cherry picked from commit 9f1cf0e4)
-
Make sure to propagate the NON_UNIFORM access for UBO loads, so that non-uniform loads are correctly lowered. Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <!5311> (cherry picked from commit 86f21e4e)
-
Tessellation shader in llvmpipe depends on llvm coroutines support. So do not advertise tessellation shader support in llvmpipe if GALLIVM_HAVE_CORO is FALSE. This fixes assertion in LLVMTokenTypeInContext() running tessellation shader tests with llvm version < 6. Fixes: eb522717 "llvmpipe: add support for tessellation shaders" Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Neha Bhende <bhenden@vmware.com> Part-of: <mesa/mesa!5366> (cherry picked from commit dd81f485)
-
the virgl CI code was using the noopt path and crashing with a wierd can't select llvm.coro.subfn.addr error, turns out we have to call the cleanup pass no matter what. This enable a lot more virgl gles31 passes, but we have to disable tessellation shaders as now they executed, they crash due to missing OES_gpu_shader5, I should try and reenable them when llvmpipe is further along Fixes: d32690b4 ("gallivm: add coroutine pass manager support") Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Acked-by:
Elie Tournier <elie.tournier@collabora.com> Part-of: <!5320> (cherry picked from commit c8c7450f)
-
Fixes: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘time_t’ {aka ‘long long int’} Signed-off-by:
Peter Seiderer <ps.report@gmx.net> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <mesa/mesa!4279> (cherry picked from commit b3beb620)
-
Fixes: ../src/gallium/drivers/panfrost/pan_bo.h:93:9: error: unknown type name ‘time_t’ Signed-off-by:
Peter Seiderer <ps.report@gmx.net> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!4279> (cherry picked from commit d512028d)
-
Fixes: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘time_t’ {aka ‘long long int’} Signed-off-by:
Peter Seiderer <ps.report@gmx.net> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <mesa/mesa!4279> (cherry picked from commit 07ba5e47)
-
See code comment for full description of the change. Fixes: 0a5018c1 ("mesa: add gl_constants::GLSLOptimizeConservatively") Closes: mesa/mesa#3034 Tested-by:
Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5346> (cherry picked from commit e43ab7bb)
-
The xml.etree.cElementTree module will be removed in Python 3.9. Since Python 3.3 the xml.etree.cElementTree module has been deprecated, the xml.etree.ElementTree module uses a fast implementation whenever available. Builds using Python 2.7 can still work but with the slower implementation. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Acked-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <!5349> (cherry picked from commit faa339e6)
-
xml.etree.ElementTree getchildren was deprecated since Python 2.7 and will be removed in Python 3.9. Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!5348> (cherry picked from commit 6a841dbf)
-
Eric Engestrom authored
The script was failing for me (python 3.8), not sure if this is a recent python version break or not as I don't know how often people have been running this script: Processing ./gen9.xml... Traceback (most recent call last): File "./gen_sort_tags.py", line 177, in <module> main() File "./gen_sort_tags.py", line 170, in main genxml[:] = enums + sorted_structs.values() + instructions + registers TypeError: can only concatenate list (not "odict_values") to list Turning the odict into a list fixes it for me, and the resulting xml file are identical to before :) Fixes: 903e142f ("genxml: add a sorting script") Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!5352> (cherry picked from commit 981d07c7)
-
Fixes: ``` ../mesa-freedreno-20.2.0_pre/src/freedreno/computerator/ir3_asm.c:25:10: fatal error: 'ir3/ir3_parser.h' file not found #include "ir3/ir3_parser.h" ^~~~~~~~~~~~~~~~~~ 1 error generated. ``` Fixes: da467817 ("freedreno/ir3: Move ir3 assembler to backend compiler") Signed-off-by:
Rob Clark <robdclark@chromium.org> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!5340> (cherry picked from commit ef5b8bbc)
-
Eric Engestrom authored
Cc: mesa-stable Closes: mesa/mesa#3086 Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Vinson Lee <vlee@freedesktop.org> Part-of: <mesa/mesa!5342> (cherry picked from commit 7a68045b)
-
DOOM Eternal expects this type, but RADV doesn't expose it when the VRAM is entirely host-visible, in my case on Fiji. Matches AMDVLK behavior. Closes: mesa/mesa#3054 Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!5308> (cherry picked from commit 20225256)
-
For shaders where there's already a psiz-variable, we should rather reuse it than create a second one. This can happen if a shader writes gl_PointSize, but disables GL_PROGRAM_POINT_SIZE. Fixes: 878c9428 ("nir: add lowering-pass for point-size mov") Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5328> (cherry picked from commit e61a9887)
-
We reuse DRM file descriptors internally. Therefore when we export a GEM handle we must do so in the file descriptor used externally. This change also fixes a file descriptor leak of the FD given at screen creation. v2: Don't bother checking fd equals, they're always different Fix dmabuf leak Fix GEM handle leaks by tracking exported handles v3: Check os_same_file_description error (Michel) Don't create multiple exports for a given GEM table v4: Add WARN_ONCE (Ken) Rename external_fd to winsys_fd v5: Remove export lock in favor of bufmgr's Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: mesa/mesa#2882 Fixes: 7557f160 ("iris: share buffer managers accross screens") Tested-by:
Eric Engestrom <eric@engestrom.ch> Tested-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit aba3aed9)
-
We reuse DRM file descriptors internally. Therefore when we export a GEM handle we must do so in the file descriptor used externally. v2: Fix dmabuf leak Fix GEM handle leaks by tracking exported handles v3: Check os_same_file_description error (Michel) Don't create multiple exports for a given GEM table v4: Add WARN_ONCE (Ken) v5: Remove blank line (Ian) Remove unused field (Ian) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: mesa/mesa#2882 Fixes: 4094558e ("i965: share buffer managers across screens") Tested-by:
Eric Engestrom <eric@engestrom.ch> Tested-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit 57e4d0aa)
-
We'll start using this field more for querying image properties. Without it we run into a crash. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit e41e8206)
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Tested-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4861> (cherry picked from commit 604a86e4)
-
Reported-by:
Rafał Mikrut <mikrutrafal54@gmail.com> Fixes: a63b9071 ("mesa: also check for __NetBSD__") Closes: #3015 Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <!5191> (cherry picked from commit c3025bde)
-
Fix warning reported by Coverity Scan. Wrong sizeof argument (SIZEOF_MISMATCH) suspicious_sizeof: Passing argument 3544UL (sizeof (vlVdpPresentationQueue)) to function calloc that returns a pointer of type vlVdpPresentationQueueTarget * is suspicious because a multiple of sizeof (vlVdpPresentationQueueTarget) /*16*/ is expected. Fixes: 65fe0866 ("vl: implemented a few functions and made stubs to get mplayer running") Closes: #3026 Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <!5182> (cherry picked from commit 8b353524)
-
We don't have "lrp(int, int, int)" and validation of ir_triop_lrp fails down the road. Fixes: 8d37e991 Closes: mesa/mesa#3059 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Tested-by:
Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5257> (cherry picked from commit 9f3956fe)
-
To fix rendering issues with Metro Exodus, RE2 and 3 and probably more titles. It seems the default behaviour of DX12 anyways. Closes: mesa/mesa#3064 Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5262> (cherry picked from commit d3c937c0)
-
That fixes some rendering issues. Probably some unitialized data from the game. Closes: mesa/mesa#3064 Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5262> (cherry picked from commit fd5ffd3a)
-
I cleaned up the other similar call-sites, but somehow missed this one. There's nothing different with this, so let's also fix this. Fixes: 16339646 ("zink/spirv: rename functions a bit") Reviewed-by:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!5250> (cherry picked from commit a2196683)
-
This fixes dEQP-GLES3.functional.shaders.texture_functions.textureprojlodoffset.sampler2dshadow_vertex. This is probably a dEQP bug. Fixes: d573d1d8 Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!5209> (cherry picked from commit fe394763)
-
We don't want to copy the file into the build directory, we want to install it. That's what install_data is for. Closes: #2924 Fixes: 56ccea58 ("vulkan/overlay: Add basic overlay control script.") Acked-by:
Matt Turner <mattst88@gmail.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <!4740> (cherry picked from commit fb62e642)
-
We should be passing _gt instead of 1 to GEN12_FEATURES or else all TGL SKUs will be considered as gt1 only. Fixes: 54996ad4 ("intel/dev: Split .num_subslices out of GEN12_FEATURES macro") Signed-off-by:
Satyeshwar Singh <satyeshwar.singh@intel.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Jordan Justen <jordan.l.justen@intel.com> Part-of: <!5261> (cherry picked from commit aaec065f)
-
Fix warning reported by Coverity Scan. Missing argument to printf format specifier (PRINTF_ARGS) missing_argument: No argument for format specifier %s. Fixes: 04c1536b ("r300g: rasterizer debug logging") Fixes: 85efb2ff ("r300g: try to use color varyings for texcoords if max texcoord limit is exceeded") Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5274> (cherry picked from commit d2f8105b)
-
This is needed to support the core's usage of coherent buffers for glVertex-style input. The reason why this was disallowed is that any mappings will be invalidated. Let the state tracker worry about that, and just reallocate when we're told. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!5276> (cherry picked from commit 6e1c47b9)
-
We were inserting the right number of MOVs but, thanks to the way we advanced msg_end earlier in the function, were often writing the zeros past the end of where we actually read in the register file. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!5243> (cherry picked from commit 94aa7997)
-
We already do this in the FS back-end; we just weren't doing it in vec4 so RESINFO messages weren't returning the right data. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <!5243> (cherry picked from commit a7c8811f)
-