- Dec 22, 2018
-
-
The duration field being a uint64, is stored in 8 bytes, not 4. So the offset of the following field, language code, needs to be updated accordingly so that the parsed language code is not garbage.
-
- Dec 21, 2018
-
-
Juan Navarro authored
The documentation of "port-range" implies that passing NULL should be valid, but currently it is not. Without this check, the sscanf() call will crash.
-
- Dec 20, 2018
-
-
This reverts commit dcd3ce97. This functionality was implemented for gstopenwebrtc, but it turned out this was not actually needed for webrtc bundling support, as shown in webrtcbin. It also doesn't correspond to any standards. This is an API break, but nothing should actually depend on this, at least not for its initial purpose. Changes in rtpbin.c were reverted manually, to preserve some refactoring that had occurred in the original commit. Fixes #537
-
- Dec 19, 2018
-
-
Nicolas Dufresne authored
We can't assume a buffer that has been pushed in the adapter is still valid. This fixes a use after free detect when running test on jenkins.
-
Bus message handler of tags checking unit test uses gst_message_parse_error() in case of GST_MESSAGE_ERROR and GST_MESAGE_WARNING. If gst_message_parse_error() is called in case of GST_MESSAGE_WARNING, assert occurs. So modified to use gst_message_parse_warning() in case of GST_MESSAGE_WARNING.
-
Nicolas Dufresne authored
-
- Dec 18, 2018
-
-
Nicolas Dufresne authored
This copy and port all the relevant tests from rtph264.
-
Nicolas Dufresne authored
-
Nicolas Dufresne authored
In AU mode, the depayloader may have accumulated NALs, test that these NALs are drained and not dropped.
-
Nicolas Dufresne authored
Test that marker bit is transferred when input buffer has the marker flag set but also that it's set whenever the payloader receives complete AU.
-
Nicolas Dufresne authored
This test make sure that timestamps are properly transfered to each NALU.
-
Nicolas Dufresne authored
-
Nicolas Dufresne authored
This is the same as what was done on rtph264pay in the patch d5d28055
-
Nicolas Dufresne authored
-
Nicolas Dufresne authored
This will be needed to implement draining on EOS.
-
Nicolas Dufresne authored
-
Nicolas Dufresne authored
This will be needed to implement draining on EOS.
-
Nicolas Dufresne authored
This macro is not longer used. It was secretly checking if that nal was a slice, and confusingly name to that one may think it was checking if the nal is an AUD.
-
Nicolas Dufresne authored
The code was reading the timestamp from the adapter before pushing the new buffer into it. As a side effect, if the adapter was empty, we'd end up using an older timestamp. In alignment=au, it means that all timestamp was likely one frame in the past, while in alignment=nal, with multiple slices per frame, the first slice would have the timestamp of the previous one.
-
Nicolas Dufresne authored
We have a buffer flag to represent the marker bit (when present). Forward this bit by setting the buffer flag accordingly.
-
Nicolas Dufresne authored
The marker bit is used for efficient decoding. The assumption that it should be set on the AUD is wrong, since the AUD is conceptually starts the frame, while the marker is to indicate the end. So properly set the marker bit as soon as we know we are ending an AU and also whenever upstream have set the GST_BUFFER_FLAG_MARKER flag.
-
Nicolas Dufresne authored
The code was reading the timestamp from the adapter before pushing the new buffer into it. As a side effect, if the adapter was empty, we'd end up using an older timestamp. In alignment=au, it means that all timestamp was likely one frame in the past, while in alignment=nal, with multiple slices per frame, the first slice would have the timestamp of the previous one.
-
Nicolas Dufresne authored
The marker bit is used for efficient decoding. The assumption that it should be set on the AUD is wrong, since the AUD is conceptually starts the frame, while the marker is to indicate the end. So properly set the marker bit as soon as we know we are ending an AU and also whenever upstream have set the GST_BUFFER_FLAG_MARKER flag.
-
Nicolas Dufresne authored
We have a buffer flag to represent the marker bit (when present). Forward this bit by setting the buffer flag accordingly.
-
Nicolas Dufresne authored
Don't allow external encoder to use one of the reserved NAL type implicated in NAL aggreation. These out-of-spec NAL types, if passed from the outside world will lead to an invalid RTP payload being created.
-
Seungha Yang authored
Allow run some unit tests on Windows. * Remove hardcoded path separator in whitelist env for Meson to choose OS-specific separator automatically (i.e., ';' for windows and ':' for *nix) * Add dependency explicitly for some test cases, otherwise plugins couldn't be loaded on uninstalled environment of Windows.
-
Seungha Yang authored
... to avoid mixing '/' and '\' in a path string on Windows.
-
gstreamer!55 makes some changes to how the `error-after` counter works which breaks this test. This change makes the test not rely on the ability to alter `error-after` at runtime and explicitly stops and starts the harness before pushing data. An alternative would be to add another argument to `harness_rtpulpfecdec` to set `error-after` on construction but that's slightly more long-winded. so I went for this approach instead. Fixes #532, even though that's already closed.
-
The initial mission statement for this test was: * demonstrate usage of the request-aux-* signals in rtpbin * test the rtx elements We have examples that serve the first use case, and better (harnessed) tests for the second use case. This test is slow and racy, it served its purpose but can now be removed. Fixes #533
-
- Dec 17, 2018
-
-
Nicola Murino authored
If the pipeline consumes the data slower than the available network speed, for example because sync=true, is useless to increase the blocksize and reading in too big blocksizes can cause the connection to time out Closes #463
-
The function gst_v4l2_object_add_interlace_mode() has repeating code so it's best use a loop instead. That will make it easy and simple to add additional interlace modes in a following patch.
-
Instead of a custom map to translate the interlace modes to strings, let's make use of the base API provided.
-
Nicola Murino authored
kAudioFormatFlagIsSignedInteger is a format flags Closes #394
-
In 2018 khronos changed the gl header guards. If we don't detect this properly we would end up with plenty of symbol redifinition (since we would be importing twice the "same" header). Instead detect if the "newer" header was already included and if so define the "old" define to avoid this situation Fixes #523
-
- Dec 15, 2018
-
-
For the demuxer we have to select line offset 0 for the time being as this information is not passed over MOV.
-
- Dec 14, 2018
-
-
-
When the EOS event is received, run all timers immediately and avoid pushing the EOS downstream before this has been run. This ensures that the lost packet statistics are accurate.
-
The teardown of the pads checks the refcount, but there are timers inside the jitterbuffer that can push things, so if we're not lucky, things could be pushed while the pads are being shut down. Putting the jitterbuffer to NULL first avoids this.
-
After EOS is received, it is pointless to wait for further events, specially waiting on timers. This patches fixes two cases where we could wait instead of returning GST_FLOW_EOS and trigger a spin of the loop function when EOS is queued, regardless if this EOS is the queue head or not.
-
-