- Nov 10, 2021
-
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
-
We reference the scratch BO using a bindless index in the command streamer instructions, but we forgot to add them to the BO list. v2: Make use of pipeline reloc list (Jason) v3: Don't add NULL BOs to the reloc list (Lionel) v4: Don't add BOs twice to reloc list when dealing with addresses (Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: eeeea5cb ("anv: Add support for scratch on XeHP") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!13544> (cherry picked from commit 46c37c86)
-
S_008D20_FINISH_DONE is a mask of queues and 1 means "wait on the gfx queue until the value is not 0" which can never happen when the driver captures from compute. Instead, use the full mask of possible queues. Cc: 21.3 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13694> (cherry picked from commit 379fab74)
-
this is used for pipeline comparisons, so it has to always be accurate cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13727> (cherry picked from commit 4dfb5818)
-
this was a little spaghetti-ish: the module hash was sometimes being applied during module update, sometimes in draw during program create, and then also it was removed when a shader unbind would cause the program to no longer be reachable now things are more consistent: * keep removing module hash when program becomes unreachable * only apply module hash in draw during updates there cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13727> (cherry picked from commit bfa81c1e)
-
Closes: mesa/mesa#4616 Fixes: e3101c96 ("anv/image: Disable multi-layer CCS_E on TGL+") Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!13680> (cherry picked from commit e6147895)
-
Looks like the __attribute__ version doesn't work for C++ in the Android build. Only found now because we don't enable -Wimplicit-fallthrough by default project wide for C++. Only ACO enables it. Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!13164> (cherry picked from commit aad80e47)
-
Fixes a crash in some desktop GL testcases in piglit. Cc: mesa-stable Part-of: <mesa/mesa!13635> (cherry picked from commit 7b578c12)
-
-static-libstdc++ doesn't exist on the Android NDK, casuing all later has_argument calls to return false even though the compiler supports that argument. Fixes: 3aee4627 "meson: add windows compiler checks and libraries" Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <!13164> (cherry picked from commit 22673a98)
-
The Vulkan spec got clarified recently and it's invalid (hw can support it though). Fixes new CTS dEQP-VK.api.buffer.invalid_buffer_features.*. Cc: 21.3 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!13701> (cherry picked from commit ca7c748f)
-
zero is for success, nonzero is failure. Fixes: 0b60d6a2 ("d3d12: Support Linux eventfds for fences") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12268> (cherry picked from commit accd8326)
-
When the client calls vkMapMemory(), we have to align the requested offset down to the nearest page or else the map will fail. On platforms where we have DRM_IOCTL_I915_GEM_MMAP_OFFSET, we always map the whole buffer. In either case, the original map may start before the requested offset and we need to take that into account when we clflush. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <mesa/mesa!13610> (cherry picked from commit 90ac06e5)
-
We have to mark the root as non-spillable in case the interval is the child of some other interval, but we can't know whether it's the child of some other interval until it's been inserted. Move the setting of cant_spill below the insertion. This prevents us from using a bogus parent value. Fixes: 613eaac7 ("ir3: Initial support for spilling non-shared registers") Part-of: <mesa/mesa!13650> (cherry picked from commit db566904)
-
Eric Engestrom authored
This is already done on lines 475-480, resulting in them appearing twice in the summary. Fixes: 47946855 ("meson: allow egl_native_platform to be specified") Signed-off-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!13278> (cherry picked from commit 9ad375bd)
-
shader_stages_mask and others expect MESA_SHADER_* based values, not PIPE_SHADER_*... Without this the fragment shader wouldn't appear in the "Pipelines" pane of RGP. Fixes: c276bde3 ("radeonsi/sqtt: export shader code to RGP") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!13696> (cherry picked from commit 3de072aa)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: d399c3e8 ("intel/dev: Add device info for ADL-S") Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <mesa/mesa!13476> (cherry picked from commit 3b1a5b8f)
-
Cc: 21.2 21.3 <mesa-stable@lists.freedesktop.org> Part-of: <mesa/mesa!13472> (cherry picked from commit 10ee261c)
-
Fixes: e8cad57a ("gallium/trace: add pipe_vertex_state support") Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <mesa/mesa!13582> (cherry picked from commit f5794010)
-
Closes: mesa/mesa#5586 Fixes: cefaa739 Signed-off-by: Kostiantyn Lazukin <kostiantyn.lazukin@globallogic.com> Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!13643> (cherry picked from commit 78b613db)
-
A bit difficult to find what commit introduced the issue because of all the renaming, but it was my bug :) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <mesa/mesa!10015> (cherry picked from commit 349bfb72)
-
v2: Fix comment change (Marcin) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <mesa/mesa!10015> (cherry picked from commit 67619d81)
-
When a device has its first slice/subslice fused off, we can't use the number of slices/subslices to iterate the mask array. v2: Fix spelling (Marcin) Use size_t for iterator (Marcin) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reported-by: Matt Roper <matthew.d.roper@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Closes: mesa/mesa#5601 Part-of: <mesa/mesa!10015> (cherry picked from commit a543a944)
-
Rather than having 2 paths to set the slice/subslice/eu masks, reuse the other internal functions. This simplifies finding bugs within this code : * If we have i915 query topology support, update_from_topology() is called. * If we don't have query topology support but we have getparam for slice/subslice/EU, we generate a topology data and call update_from_topology() * If we have no kernel support to query any kind of topology, we generate the values return by the kernel for slice/subslice/EU and call update_from_masks() which in turns calls update_from_topology() v2: Fixup typo (Adam) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <mesa/mesa!10015> (cherry picked from commit e10c641f)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <mesa/mesa!10015> (cherry picked from commit d7c6a90c)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <mesa/mesa!10015> (cherry picked from commit d1db5d56)
-
10c75ae4 moved handling of this state to the functions that depend on ctx->_ImageTransferState. So we can't depend on _NEW_PIXEL being set to call this function, since it'll be always clear earlier by _mesa_update_state_locked. Example sequence that would trigger the issue: glPixelTransferi(...) glClear(...) glTexSubImage2D(...) <-- won't use the new value set by glPixelTransferi because glClear caused _NEW_PIXEL to be cleared. _NEW_PIXEL itself is kept because st_update_pixel_transfer depends on it. Fixes: 10c75ae4 ("mesa: move _mesa_update_pixel out of _mesa_update_state") Closes: mesa/mesa#5273 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!13596> (cherry picked from commit 1ee3fbd7)
-
../mesa-9999/src/gallium/drivers/llvmpipe/lp_texture.c:55:10: fatal error: git_sha1.h: No such file or directory Fixes: 1608a815 ("llvmpipe: add support for EXT_memory_object(_fd)") Reviewed-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Dylan Baker <dylan@pnwbakers.com> Signed-off-by: orbea <orbea@riseup.net> Part-of: <mesa/mesa!13665> (cherry picked from commit 0a6f079a)
-
this ended up being a little trickier than I thought; lazy descriptors don't use dynamic ubo types for the push set, which means drivers that (correctly) assert dynamic offset existence explode because the descriptor template will never work with the push set the better, though slightly more annoying, option here is to use the lazy manager's faster descriptor allocation and lesser complexity to quickly grab a push set, then tweak the existing cached codepath slightly in order to update a raw vkdescriptorset Fixes: 417477f6 ("zink: always use lazy (non-push) updating for fbfetch descriptors") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!13677> (cherry picked from commit 8c37cd88)
-
This looks like just a typo, we allow up to == 0xf in the lowering pass. Cc: mesa-stable Part-of: <mesa/mesa!13668> (cherry picked from commit 34739cb6)
-
Since we're casting to unorm, the linear filtering will give bad results. Cc: mesa-stable Part-of: <mesa/mesa!13666> (cherry picked from commit 0e4fcda7)
-
We have to set 8c01 to say "leave these channels alone" when clearing/storing just Z or S of z24s8. Fixes the bypass path for KHR-GLES3.packed_depth_stencil.verify_read_pixels.depth24_stencil8. Cc: mesa-stable Fixes: #5592 Part-of: <mesa/mesa!13659> (cherry picked from commit f0f5b8d4)
-
The gmem store stores both depth and stencil for z24s8. So, if we're doing a write (clear or draw) to one or the other of the channels, we need the other one restored as well. Cc: mesa-stable Part-of: <mesa/mesa!13649> (cherry picked from commit 29093bc4)
-
At that point we didn't call all the v3dv lowerings. So the reference nir shader used to call the v3d compiler could be different. Note that at that point the nir shader is only available for internal shaders (like gs multiview). This specifically affected multiview tests that wrote gl_PointSize, as the nir shader for the geometry shader were wrongly exposing per_vertex_point_size as false, as we were basing our check on the nir_shader_info, and that was gathered calling nir_shader_gather_info at pipeline_lower_nir. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <mesa/mesa!13325> (cherry picked from commit 19894bec)
-
OpenGL 3.0 requires the driver can draw to 8 simultaneous render targets. Similarly, OpenGL ES 3.0 requires the driver can draw to 4 simultaneous render targets. Fix the version computation logic to take this into account. On Mali T720, we support ~all features of OpenGL ES 3.1 except we only support a single render target. Mali T720 should advertise OpenGL 2.1 and OpenGL ES 2.0 only. With the previous logic, it incorrectly advertised OpenGL ES 3.1. v2: Lie about the minimum for GL 3.0 to make freedreno a3xx happy. Add Emma's reviewed-by. v3: Update the Mali T720 CI expectations. There are tests that pass on GLES3 but not GLES2. Unclear if these are dEQP bugs or Mesa bugs, lima hits the same issues. Add them to the known fails Note to mesa-stable maintainers: this downgrades the OpenGL version advertised on Mali T720. As such, this patch should apply to the unreleased 21.3 (Eric) but should NOT be backported to any released Mesa versions (21.2 or older should NOT have this patch). This is a bit of a compromise; Emma agreed with this plan on IRC. Reported-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> [v2] Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> [v2] Cc: 21.3 mesa-stable Part-of: <mesa/mesa!13455> (cherry picked from commit 861a35b3)
-
So far only LAVA jobs make use of it, but I guess baremetal could be extended to have these timeouts as well. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!13441> (cherry picked from commit 83a0bb00)
-
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!13441> (cherry picked from commit dedc1493)
-
* Update Kconfig for x86_64 and ARM64. Follow the dependency tree of the kernel modules to make sure that the intended configurations are being set. Check scripts/merge_config.sh output as well to see if there is a requested Kconfig not being considered. For a630 devices: * Use kernel version with a6xx workaround for frequency scaling * Enable CONFIG_QCOM_LMH targeting a630 slowness on new kernel ---- Out of tree patches used ---- For a360 device: * Revert a commit which remove slpi_region from msm8996: 8b0031f8bda2 ("Revert "arm64: msm8996: fix memory region overlap"") Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!13089> (cherry picked from commit 7fea3c6f)
-
We've noticed issues with these tests when uprevving Mesa in Chrome OS. This CI catches some existing failures, and some debug-build assertion failures as well. To do this, uprev deqp-runner for its new gtest-runner command. This runner is not as efficient as I would hope, due to some expensive code in gtest. I've reported the issue to gtest and it should be easily fixable, but for now it at least means we get to use the same baseline/skip/flake handling we have from deqp and piglit runners. I also fixed build-libdrm for our rootfses to not throw away libdrm's share directory, which was causing a bunch of test-time spam from radeon's libdrm when trying to look up its marketing name tables (not that big of a deal for deqp-runner, but really noisy for piglit and libva-utils which make gallium screens approximatly per-test). Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!13419> (cherry picked from commit 8fb85065)
-
The test names are definitely unique (deqp has specific prefixes, piglit uses '@' as a separator instead of '.'), so we can just have a single file regardless of test type. Merges the two groups of xfails together so you can't mix up which file to edit (I certainly have), and so that we don't need to introduce yet another set of files when we add gtest for libva. Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Daniel Stone <daniels@collabora.com> Part-of: <mesa/mesa!13517> (cherry picked from commit bfbc41a9)
-
We have two testsuites with the same format for fails/flakes/skips files, and test names that are definitely unique. As I'm about to add a third testsuite (gtest for libva-utils), so let's have just one file each for fails/flakes/skips instead of one per type of testsuite. This starts the move with just the bulk rename of deqp. Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Acked-by: Daniel Stone <daniels@collabora.com> Part-of: <mesa/mesa!13517> (cherry picked from commit 38dff02b)
-