- Sep 08, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
- Sep 07, 2021
-
-
Fixes: 665d75cc ("glsl: Fix scoping bug in if statements.") Closes: mesa/mesa#5247 Reviewed-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <mesa/mesa!12435> (cherry picked from commit 02b39402)
-
We want the kernel to ban our context immediately instead of foolhardily attempting to recover. Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!12476> (cherry picked from commit a6a44983)
-
Prior to this commit, the stride, offset and modifier were fetched via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query succeed if the buffer couldn't be imported to the KMS device. Instead, implement the resource_get_param hook to allow users to fetch this information without WINSYS_HANDLE_TYPE_KMS. A tiny helper function is introduced to compute the modifier of a resource. Signed-off-by:
Simon Ser <contact@emersion.fr> Fixes: 7bcb2236 ("v3d, vc4: Fix dmabuf import for non-scanout buffers") Reported-by:
Roman Stratiienko <r.stratiienko@gmail.com> Reviewed-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Jose Maria Casanova Crespo <jmcasanova@igalia.com> Part-of: <mesa/mesa!12370> (cherry picked from commit 8de086e1)
-
Prior to this commit, the stride, offset and modifier were fetched via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query succeed if the buffer couldn't be imported to the KMS device. Instead, implement the resource_get_param hook to allow users to fetch this information without WINSYS_HANDLE_TYPE_KMS. A tiny helper function is introduced to compute the modifier of a resource. Signed-off-by:
Simon Ser <contact@emersion.fr> Fixes: 7bcb2236 ("v3d, vc4: Fix dmabuf import for non-scanout buffers") Reported-by:
Roman Stratiienko <r.stratiienko@gmail.com> Reviewed-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Jose Maria Casanova Crespo <jmcasanova@igalia.com> Part-of: <mesa/mesa!12370> (cherry picked from commit b1fbceac)
-
Prior to this commit, the stride, offset and modifier were fetched via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query succeed if the buffer couldn't be imported to the KMS device. Instead, implement the resource_get_param hook to allow users to fetch this information without WINSYS_HANDLE_TYPE_KMS. Signed-off-by:
Simon Ser <contact@emersion.fr> Fixes: 4c092947 ("panfrost: fail in get_handle(TYPE_KMS) without a scanout resource") Reported-by:
Roman Stratiienko <r.stratiienko@gmail.com> Reviewed-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!12370> (cherry picked from commit 99fc6f72)
-
Prior to this commit, the stride, offset and modifier were fetched via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query succeed if the buffer couldn't be imported to the KMS device. Instead, extend the resource_get_param hook to allow users to fetch this information without WINSYS_HANDLE_TYPE_KMS. Signed-off-by:
Simon Ser <contact@emersion.fr> Fixes: 9da901d2 ("etnaviv: fail in get_handle(TYPE_KMS) without a scanout resource") Reported-by:
Roman Stratiienko <r.stratiienko@gmail.com> Reviewed-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!12370> (cherry picked from commit b5919b0b)
-
When this was rewritten to support Vulkan, we stopped initializing file_max to -1 in the case of no inputs. This causes the draw module to go down a needlessly pessimistic case, printing an error while we're at it. Fixes: 42b5cfdb ("gallivm/nir: fix vulkan vertex inputs") Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!12440> (cherry picked from commit 63529782)
-
This was using mixed tabs and spaces, let's fix that before we start modifying the code. Fixes: 42b5cfdb ("gallivm/nir: fix vulkan vertex inputs") Reviewed-by:
default avatarDave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!12440> (cherry picked from commit 46746980)
-
There is nothing in the spec about this. BindFragDataLocation* is supposed to return an error, but not Get. Closes: mesa/mesa#5221 Fixes: 59012c31 ("mesa: Implement glGetFragDataLocation") Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12333> (cherry picked from commit bce19b3a)
-
this otherwise explodes when rewriting e.g., a single array component load to a vec4 Fixes: f5adf27f ("nir,radv: add and use nir_vectorize_tess_levels()") fixes zmike/mesa#94 Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!12419> (cherry picked from commit 649251ad)
-
Otherwise with some compilers/environments (Android) padding may contain garbage and memcmp of the key will fail. Cc: mesa-stable Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!12438> (cherry picked from commit fae1e99a)
-
Currently stride, offset, modifier is obtained by invoking lima_resource_get_handle() with WINSYS_HANDLE_TYPE_KMS. Before commit 47f000c1 this path was working. Obtained handle was simply ignored by DRI frontend and only requested data used. After commit 47f000c1 such requests started to fail when DRI is initialized using KMSRO and resource has no scanout data. When lima_resource_get_param() is implemented, it will be used in a first place to obtain resource data. Fixes: 47f000c1 ("lima: fail in get_handle(TYPE_KMS) without a scanout resource") Signed-off-by:
Roman Stratiienko <r.stratiienko@gmail.com> Reviewed-by:
Simon Ser <contact@emersion.fr> Reviewed-by:
Erico Nunes <nunes.erico@gmail.com> Part-of: <mesa/mesa!12362> (cherry picked from commit 5ec6b6e9)
-
When operators other than eq and ne are involved we can't really move operands around and negate them because such transformation may change the value of the whole expression. Some examples: For unsigned var: 0 >= 1u + var would eventually become 0xffffffff >= var, which would always evaluate to true, when original expression was true only for var == 0xffffffff. For signed var: 0 >= 1 + var would become -1 >= var, which would evaluate to false for var == 2147483647, when original expression evaluated to true (because signed overflow is defined to wrap around in glsl, 1 + 2147483647 == -2147483648, so 0 >= -2147483648). Closes: mesa/mesa#5226 Fixes: 34ec1a24 ("glsl: Optimize (x + y cmp 0) into (x cmp -y).") Signed-off-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!12359> (cherry picked from commit 89bc8ff4)
-
Eric Engestrom authored
Fixes: cf9ff082 ("isl: Bring back isl_format_layout::bpb") Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Part-of: <mesa/mesa!3674> (cherry picked from commit 773a70f9)
-
Eric Engestrom authored
This reverts commit ad363913. This code was added to be able to compare the output file while porting the script from python2 to python3, but this has long been finished and the extra complexity is not needed anymore. Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Part-of: <mesa/mesa!3674> (cherry picked from commit 93cb3aca)
-
mmap requires its offset is page aligned, but the current code only guarantees 4k alignment, causing drm-shim to break badly on kernels with >4k page sizes. This fixes drm-shim on my Apple M1, running bare metal Linux with 16k pages. It probably also fixes exotic PowerPC systems with 64k pages. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Zoltan Boszormenyi <zboszor@gmail.com> Reviewed-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
Emma Anholt <emma@anholt.net> Cc: mesa-stable Part-of: <mesa/mesa!12347> (cherry picked from commit 38f39cc1)
-
When creating an image out of a swapchain on Android, the android layer call will detect a VkBindImageMemorySwapchainInfoKHR in the pNext chain of the vkBindImageMemory2() call and add a VkNativeBufferANDROID in the chain. This is what we should use as backing memory for that image. v2: Fix a couple of obvious mistakes (Tapani) v3: Silence build warning (Lionel) Fix invalid object argument to vk_error() (Lionel) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: bc3c71b8 ("anv: don't try to access Android swapchains") Cc: mesa-stable Closes: mesa/mesa#5180 Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!12244> (cherry picked from commit 19b7bbba)
-
Fix defect reported by Coverity Scan. Uninitialized scalar variable (UNINIT) uninit_use: Using uninitialized value dst.x. Fixes: a1a2a8df ("nir: add AMD_gcn_shader extended instructions") Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12290> (cherry picked from commit 8d679f4f)
-
Fixes: d30ce03b ("meson: add build-summary") Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Part-of: <mesa/mesa!12296> (cherry picked from commit c0fc745b)
-
- Aug 25, 2021
-
-
Fixes: a62098ff ("nir: Add a helper for general instruction-modifying passes.") Signed-off-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12324> (cherry picked from commit e1b325f5)
-
- Aug 22, 2021
-
-
If we return inside a pan_pack() the descriptor packing doesn't happen. Cc: mesa-stable Fixes: 8ba2f9f6 ("panfrost: Create a blitter library to replace the existing preload helpers") Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Part-of: <mesa/mesa!12239> (cherry picked from commit 06fc6e46)
-
Eric Engestrom authored
-
- Aug 11, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
- Aug 10, 2021
-
-
Eric Engestrom authored
With our ff-only merge setup, the commit date ends up being when the commit actually landed (as opposed to when it was first written). Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Cc: mesa-stable Part-of: <!12289> (cherry picked from commit 4128acde)
-
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Cc: mesa-stable Part-of: <mesa/mesa!12289> (cherry picked from commit 7ec42b5e)
-
Eric Engestrom authored
Let's just make it not-optional instead. Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Cc: mesa-stable Part-of: <mesa/mesa!12289> (cherry picked from commit db14f2a9)
-
Fixes: fb29cef8 ("nir: add many passes that lower and optimize 16-bit input/outputs and samplers") Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!11732> (cherry picked from commit 9b57a818)
-
Otherwise drivers that don't use 16-bit slots for varyings will get confused and have their driver_locations scribbled over. This has caused multiple problems for both Panfrost and Asahi this week. Given the only other user of the pass for varyings is radeonsi, which needs both together, I think this is the least controversial fix. Fixes: fb29cef8 ("nir: add many passes that lower and optimize 16-bit input/outputs and samplers") Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!11732> (cherry picked from commit 03c18f7e)
-
v2: intialize test_val in constructor Closes: mesa/mesa#5185 Signed-off-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Cc: mesa-stable Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!12234> (cherry picked from commit bdae3c36)
-
By creating the KMS side handles we allow GBM to return the proper KMS side GEM handles for imported buffers. Always creating the KMS side handles adds a bit of overhead, as we don't need them on all imported resources, but seems like the most robust solution for now. Cc: mesa-stable Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Simon Ser <contact@emersion.fr> Reviewed-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!12018> (cherry picked from commit 826f9577)
-
There are a number of drivers which do a trial-and-error import of buffers into the KMS side via renderonly. Some of those imports are expected to fail, so we should not print a error message in this case. All callers do proper error handling themselves. Cc: mesa-stable Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Simon Ser <contact@emersion.fr> Reviewed-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!12018> (cherry picked from commit 1bc22a2e)
-
Eric Engestrom authored
-
- Aug 09, 2021
-
-
In the compute dispatch path we do not allocate a huge amount of space to cover everything so the individual functions have to allocate. This was missing here, causing a hang in Cyberpunk when accessing the system menu at some locations with thread tracing enabled. Fixes: bd118657 ("radv: add support for push constants inlining when possible") Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!12271> (cherry picked from commit 02b60159)
-
If "a" is a multiple of "b", then the result would have been "b" instead of 0. No fossil-db changes. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Fixes: 0ef5f355 ("nir: add strength reduction pattern for imod/irem with pow2 divisor.") Part-of: <mesa/mesa!12039> (cherry picked from commit ec4b425f)
-
If a shader has code like this: uniform float timestamp; ... if (timestamp > 0.0) do_something() And timestamp is modified each frame, we'll end up generating a new variant per frame. This commit introduces a hard limit on the number of variants we generate for a single shader. Closes: mesa/mesa#5121 Fixes: b7501184 ("radeonsi: implement inlinable uniforms") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12138> (cherry picked from commit 9fe8ae3f)
-
Eric Engestrom authored
-
Eric Engestrom authored
-