Ian Romanick authored Mar 02, 2022 and Matt Turner committed Dec 10, 2022

Discovered when an experiment resulted in a driver that only gave OpenGL
3.0 without GL_ARB_uniform_buffer_object.

All changes made with this script:

for ext in GL_ARB_shader_image_load_store \
           GL_ARB_shader_storage_buffer_object \
	   GL_ARB_shading_language_420pack \
	   GL_ARB_uniform_buffer_object \
	   GL_ARB_explicit_attrib_location
do
    egrep -lr "extension[[:space:]]+${ext}.*enable" . |\
        while read s; do
            # If the shader already has the requirement, skip
            if grep -A10 '[[]require]' $s | grep -q ^$ext ; then
                continue
            fi

            # If the shader has ifdefs for the extension, skip
            if egrep -q "#[[:space:]]*if.*${ext}" $s; then
                continue
            fi

            sed --in-place -e "s/\(^GLSL >.*$\)/\1\n${ext}/" $s
        done
done

These are OpenCL kernels compiled through clvk-0.0.1-r20 on ChromeOS, to
be used by Google Meet.

Filip Gawin authored Nov 14, 2022 and Lionel Landwerlin committed Nov 30, 2022

Acked-by: Alejandro Piñeiro <apinheiro@igalia.com>

M Henning authored Oct 30, 2022 and M Henning committed Nov 29, 2022

Obtained by clicking a bunch of buttons with the default cube open.

Acked-by: Alejandro Piñeiro <apinheiro@igalia.com>

'p' is an obsolete option so it needs to be removed from print_usage.
And there is no reason to print out "Unknown option:" error string since
it is actually done by getopt (e.g. "./run: invalid option -- 'p'").

Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Eric Engestrom authored Sep 13, 2022 and Eric Engestrom committed Oct 19, 2022

Signed-off-by: Eric Engestrom <eric@igalia.com>

Eric Engestrom authored Sep 13, 2022 and Eric Engestrom committed Oct 19, 2022

Signed-off-by: Eric Engestrom <eric@igalia.com>

Acked-by: Iago Toral Quiroga <itoral@igalia.com>

By default Sascha Willems demos uses for their demos using a graphics
pipeline the D32_SFLOAT_S8_UINT format. v3dv doesn't support it, but
the demos properly detect that, and use a supported format in any
case.

But as the fossils were recorded with a driver supporting that format,
it tries to use it, and we got a renderpass not supported warning, and
no shader compilation.

As fossils here are mostly used for the shading compiling statistics,
changing the format shouldn't affect to other drivers. Tested with anv
and there is no changes.

As we are here we also add some extra fossils.

Acked-by: Dylan Baker <dylan@pnwbakers.com>
Acked-by: Emma Anholt <emma@anholt.net>

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Matt Turner <mattst88@gmail.com>

Obtained by clicking around in many of the example projects from
https://github.com/godotengine/godot-demo-projects

 commit 2e40f67b1b
in godot v3.4.4

Acked-by: Emma Anholt <emma@anholt.net>

Captured from gtk4-widget-factory on gtk 4.6.0

Reviewed-by: Emma Anholt <emma@anholt.net>

This fixes a bug where the scheduler mode for every shader was detected
as "scheduled" instead of the actual mode name.

Code above this block was detecting "scheduled with mode X" and parsing
that as field = word 0 = "scheduled" and val = word 3 = "X".  Then this
code came along and did the default parsing of "N things" as value =
word 0 and field = word 1, and overrode that.  We should just put it
in the else case so each case happens independently.

Looks like this has been broken from the day it was commited. I
beleive this likely happened when Ken changed his original
patchset to stop looking for the extension and instead look for
this string.

Reviewed-by: Emma Anholt <emma@anholt.net>

MESA_GLSL_CACHE_DISABLE envvar was renamed to MESA_SHADER_CACHE_DISABLE.

v2:
 - Keep old envvar too (Marcin).

Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

imirkin wants the current format for shader-db for nouveau, but I
really want the current report.py script to work because it helps me
dig into which shaders are the problem.

i915 doesn't have loops at all, so just skip the check.

The performance of the binary really doesn't matter, it's Mesa that
does.  Found when my build was SIGILLing on my test system.

radv-report-fossil is more generic than anv-report-fossil, and has seen
more development work, so make it the "generic" report-fossil.py. Add
support for turnip by adding statistics and executable names generated
by turnip. Also fold in the driver detection logic from report-fossil
and call out to anv-report-fossil if the driver is detected to be anv.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>

Premature optimization is the root of all evil. :( Shaders that had
loops change to or from zero were not logged has having loops changed
and were not counted in the total.  Unfortunately, those are among the
most important (and most common) cases of the loops changing.

Fixes: 5a1df48b ("Add a script for comparing fossil results")

Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>

Vasily Khoruzhick authored Mar 13, 2021 and Matt Turner committed Aug 12, 2021

Otherwise shader compilation won't be triggered

Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Reviewed-by: Rob Clark <robdclark@chromium.org>

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>

Previously, this used a consistent column size, with the largest width
being used for all. If a column is much longer than others, this can
create an unreadable table.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Similar to commit d0167a28

 (report.py: fix crash on get_sched_mode),
the report.py script will fail if spills/fills are not available in the
shader-db results. freedreno doesn't provide such stats.

Reviewed-by: Eric Anholt <eric@anholt.net>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Eric Anholt <eric@anholt.net>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Eric Anholt <eric@anholt.net>

The shader requires it, but it wasn't listed in the [require] section,
leading to unnecessary errors with drivers not implementing this ext.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Eric Anholt <eric@anholt.net>

Current shader-db master report.py reports this for non-intel drivers:

Traceback (most recent call last):
  File "./report.py", line 384, in <module>
    main()
  File "./report.py", line 243, in main
    get_sched_mode(before[p], after[p]))
  File "./report.py", line 114, in get_sched_mode
    p = " (scheduled: " + b["scheduled"]
KeyError: 'scheduled'

Add a check so it avoids accessing the 'scheduled' key when it isn't
valid.

Fixes: 95e35b36

 report.py: Handle scheduler mode changes

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

needed for mesa!4264

Also make it python2 and python3 compatible

We would like to switch to a drm-shim stub much like they other
drivers [1]. Therefore we won't need any stubbing code in this
repository.

You should run shader_db like this (for TGL platform) :

   intel_stub_gpu -p tgl ./run shaders/chromeos/

[1] : mesa!4594



Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Acked-by: Ian Romanick <ian.d.romanick@intel.com>

Higher is better for the final analysis too.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>