- Apr 21, 2021
-
-
Eric Engestrom authored
-
we should probably trigger this any time a flush occurs just to avoid doing too much (unexpected) cmdstream rewriting both calls must be kept, however, as the one in the base flush hook will change the behavior of flushing if no other work is queued Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Part-of: <mesa/mesa!10358> (cherry picked from commit 04241e82)
-
there's no need to have an intermediate pointer here since that only complicates keeping scanout synchronized this also eliminates the pointer on the context since it isn't used anymore Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Reviewed-by: Adam Jackson <ajax@redhat.com> Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10358> (cherry picked from commit be6532ec)
-
having a resource pointer on batch states is now a requirement for keeping scanout objects in sync Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Reviewed-by: Adam Jackson <ajax@redhat.com> Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10358> (cherry picked from commit 7af40bb5)
-
this minimizes overhead of maintaining scanout objects Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Reviewed-by: Adam Jackson <ajax@redhat.com> Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10358> (cherry picked from commit 4dcd477d)
-
this is called from the non-deferred flush path, which means it should always be triggering work, which means it will always result in a queue submission instead of relying on the pipe_context::flush hook to be triggered, which is not a guarantee, do scanout sync during queue submission to ensure that scanout objects are always in sync Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Reviewed-by: Adam Jackson <ajax@redhat.com> Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10358> (cherry picked from commit dd8b15b2)
-
doesn't really matter, but technically an error Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!10213> (cherry picked from commit 7c2c0813)
-
EARLY_ZS_ALWAYS was introduced in Bifrost v7. Use ALWAYS (or INTERSECT depending on the situation) on v6. Fixes: 8ba2f9f6 ("panfrost: Create a blitter library to replace the existing preload helpers") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Tested-by: Icecream95 <ixn@keemail.me> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!10250> (cherry picked from commit 1de393fe)
-
Use panfrost_batch_reserve_tls() to reserve the TSD. Cc: mesa-stable Fixes: ff3eada7 ("panfrost: Use the generic preload and FB helpers in the gallium driver") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!10369> (cherry picked from commit 19849a65)
-
p_extract_vector copy-propagation can create byte sels for v2b operands. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Cc: mesa-stable Part-of: <mesa/mesa!10315> (cherry picked from commit 2d36232e)
-
It isn't intended to be accurate after RA, so num_waves can become zero, breaking the sgpr_limit calculation. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Cc: mesa-stable Part-of: <mesa/mesa!10315> (cherry picked from commit 655ba1e3)
-
This reverts commit cd12fcff. The terrain looks fine now that TRUNC_COORD=0 for textureGather(). Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!10036> (cherry picked from commit 9fb1f930)
-
Fixes black squares in Assassin's Creed: Valhalla and rendering of FidelityFX-CACAO demo. shader-db (sienna cichlid): Totals: SGPRS: 2977068 -> 2977220 (0.01 %) VGPRS: 1929624 -> 1929616 (-0.00 %) Spilled SGPRs: 5769 -> 5769 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 61423092 -> 61424672 (0.00 %) bytes Max Waves: 895765 -> 895766 (0.00 %) Totals from affected shaders: SGPRS: 9520 -> 9672 (1.60 %) VGPRS: 7464 -> 7456 (-0.11 %) Spilled SGPRs: 0 -> 0 (0.00 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 527432 -> 529012 (0.30 %) bytes Max Waves: 1819 -> 1820 (0.05 %) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Fixes: 58f25098 ("radv: Use TRUNC_COORD on samplers") Part-of: <mesa/mesa!10036> (cherry picked from commit 6a7b89c8)
-
Fixes black squares in Assassin's Creed: Valhalla and rendering of FidelityFX-CACAO demo. fossil-db (sienna cichlid): Totals from 3052 (2.09% of 146267) affected shaders: SpillSGPRs: 8437 -> 8646 (+2.48%) CodeSize: 30993832 -> 31116916 (+0.40%); split: -0.00%, +0.40% Instrs: 5869934 -> 5886783 (+0.29%); split: -0.00%, +0.29% Latency: 250330521 -> 250463770 (+0.05%); split: -0.00%, +0.05% InvThroughput: 59797617 -> 59814584 (+0.03%); split: -0.00%, +0.03% VClause: 92114 -> 92132 (+0.02%) SClause: 197373 -> 197338 (-0.02%); split: -0.02%, +0.01% Copies: 479482 -> 482394 (+0.61%); split: -0.01%, +0.61% Branches: 219629 -> 219635 (+0.00%) PreSGPRs: 248970 -> 249366 (+0.16%) fossil-db (polaris10): Totals from 3050 (2.06% of 147787) affected shaders: SGPRs: 282864 -> 282912 (+0.02%); split: -0.01%, +0.02% VGPRs: 242572 -> 242612 (+0.02%) SpillSGPRs: 10387 -> 10675 (+2.77%) CodeSize: 31872460 -> 31996128 (+0.39%) MaxWaves: 10924 -> 10925 (+0.01%) Instrs: 6222217 -> 6239072 (+0.27%) Latency: 317482545 -> 317773685 (+0.09%); split: -0.00%, +0.09% InvThroughput: 156149624 -> 156242072 (+0.06%); split: -0.00%, +0.06% VClause: 92295 -> 92254 (-0.04%); split: -0.05%, +0.01% SClause: 243342 -> 243321 (-0.01%); split: -0.01%, +0.00% Copies: 678902 -> 681700 (+0.41%); split: -0.00%, +0.41% Branches: 219698 -> 219703 (+0.00%) PreSGPRs: 244251 -> 244644 (+0.16%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Fixes: 58f25098 ("radv: Use TRUNC_COORD on samplers") Closes: mesa/mesa#3110 Part-of: <mesa/mesa!10036> (cherry picked from commit 3cbe9894)
-
Eric Engestrom authored
-
- Apr 20, 2021
-
-
These have shown up in CI runs since the deqp uprev. Also, link the bug report I made for one of the failing tests. Part-of: <mesa/mesa!10274> (cherry picked from commit afa965b7)
-
this is just for unit tests where the scanout object is redundant and the only time a flush occurs is from stalling on readback Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10239> (cherry picked from commit 87453575)
-
this eliminates any desync between scanout presentation and clears Fixes: 104603fa ("zink: create separate linear tiling image for scanout") Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10239> (cherry picked from commit 2138aef7)
-
Turns out both kernel v5.10 and v5.11 have the same amdgpu driver version and only one has modifiers ... In addition the version check is kinda annoying for backports. So lets use the cap. Since the cap is technically about ADDFB2 I tested that this works on rendernodes (and reading the code there is no distinction from what kind of node this is called). Fixes: 9a937330 ("radeonsi: Only set modifier creation function for GFX9+ & with kernel support.") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!10337> (cherry picked from commit 9da4590d)
-
If we don't do that the compute batch is left with an empty thread storage descriptor, and panfrost_batch_submit() tries to emit an FB descriptors using invalid FB information. Reported-by: Italo Nicola <italonicola@collabora.com> Fixes: ff3eada7 ("panfrost: Use the generic preload and FB helpers in the gallium driver") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Tested-by: Italo Nicola <italonicola@collabora.com> Reviewed-by: Italo Nicola <italonicola@collabora.com> Part-of: <mesa/mesa!10312> (cherry picked from commit 8d9b52f4)
-
If depth bias is enabled but zero values used, they were never emitted to the command buffer because they are equal to the default values. Previously, they were always emitted when the bound DS attachment changed. This should fix some sort of Z fighting with Dota2 on all GPUs. This also fixes a different issue (ie. some occlusion queries failures) on GFX6 because CLEAR_STATE is not used on that chip. Fixes: 8a47422d ("radv: do not scale the depth bias for D16_UNORM depth surfaces") Cc: 21.1 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!10310> (cherry picked from commit 1d354269)
-
DB isn't coherent with L2 on GFX6-8. This is needed when the clear HTILE mask path is selected. This fixes an issue with avatars in Heroes of The Storm. Closes: mesa/mesa#3362 Cc: 21.1 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!10277> (cherry picked from commit e4c0724d)
-
Fixes: dac8cb98 ("gallivm/nir: allow 8/16-bit conversion and comparison.") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!10185> (cherry picked from commit da5f346e)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 2b69dd68)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit b6781154)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 4a3f0444)
-
The warning is triggered when assigning into inputs_read, which is 64bit. Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 0e2566a8)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 67b5fba6)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 53786d2e)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit d641adca)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 1a0fbca1)
-
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-By: Bill Kristiansen <billkris@microsoft.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10331> (cherry picked from commit 09440ce3)
-
This field was introduced 2 months ago and it breaks virgl compatibility between guest/host. Switch the new added field to the end. We will still have compatibility issue but the "bug window" is much smaller. Fixes: e778acea ("virgl: update headers") Signed-off-by: Lepton Wu <lepton@chromium.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!10333> (cherry picked from commit 5322572c)
-
The code around it checks that it is found, so clearly it was meant to be optional, not arequired. Fixes: cd2832ee ("meson: add an optional OpenMP dependency for AMD tests") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Tested-by: Bernd Kuhls <bernd.kuhls@t-online.de> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!10286> (cherry picked from commit 5b9253c2)
-
Fixes piglit crashes doing glCopyTexSubImage from (for example) PIPE_FORMAT_Z24_UNORM_S8_UINT to PIPE_FORMAT_Z32_FLOAT_S8X24_UINT where, in addition to reading the source Z values incorrectly, we would try to dereference the missing separate stencil of the Z24S8 buffer. Cc: mesa-stable Part-of: <mesa/mesa!10328> (cherry picked from commit ed04fd44)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 7f223a23 ("spirv: Implement SpvOpConvertUToAccelerationStructureKHR") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!10324> (cherry picked from commit 856953b1)
-
Gotta track those sets too to free them. Alse changed the search on destroy to check for set instead of offset since offset is not necessarily unique anymore. Closes: #4652 CC: mesa-stable Reviewed-by: Joshua Ashton <joshua@froggi.es> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!10317> (cherry picked from commit a144fa60)
-
Fixes the following building errors: FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so ... ld.lld: error: undefined symbol: pan_emit_tls >>> referenced by pan_cmdstream.c:2279 (external/mesa/src/gallium/drivers/panfrost/pan_cmdstream.c:2279) ... ld.lld: error: undefined symbol: pan_emit_fbd >>> referenced by pan_cmdstream.c:2302 (external/mesa/src/gallium/drivers/panfrost/pan_cmdstream.c:2302) ... ld.lld: error: undefined symbol: pan_emit_fragment_job >>> referenced by pan_cmdstream.c:2382 (external/mesa/src/gallium/drivers/panfrost/pan_cmdstream.c:2382) ... ld.lld: error: undefined symbol: pan_emit_bifrost_tiler_heap >>> referenced by pan_job.c:718 (external/mesa/src/gallium/drivers/panfrost/pan_job.c:718) ... ld.lld: error: undefined symbol: pan_emit_bifrost_tiler >>> referenced by pan_job.c:723 (external/mesa/src/gallium/drivers/panfrost/pan_job.c:723) ... ld.lld: error: undefined symbol: pan_fbd_has_zs_crc_ext >>> referenced by pan_job.c:893 (external/mesa/src/gallium/drivers/panfrost/pan_job.c:893) ... clang-9: error: linker command failed with exit code 1 (use -v to see invocation) Cc: 21.1 <mesa-stable@lists.freedesktop.org> Fixes: 387f8c03 ("panfrost: Add various helpers to simplify FB desc emission") Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>.> Part-of: <mesa/mesa!10299> (cherry picked from commit 63c2dfe1)
-
mesa/mesa!6693 added NV12 lowering to PIPE_FORMAT_R8_G8B8_420_UNORM, which regressed some video decode use cases in radeonsi, for example CtsDecodeTestCases in android CTS. There are also discolored frames in video playback use cases (i.e. youtube). mesa/mesa!3632 previously fixed similar issues in radeonsi. This change takes that a step further to report any multi-plane format as unsupported. Fixes: 826a1025 ("st/mesa: Add NV12 lowering to PIPE_FORMAT_R8_G8B8_420_UNORM") Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Tested-by: Simon Ser <contact@emersion.fr> Part-of: <mesa/mesa!9490> (cherry picked from commit 9b781477)
-
Make sure to preserve signed zeroes. Fixes dEQP-VK.spirv_assembly.instruction.compute.opquantize.flush_to_zero on GFX6 (Pitcairn). Untested on GFX7. Fixes: 54a09545 ("aco: optimize a*0.0") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!10319> (cherry picked from commit 9434675d)
-