- Aug 25, 2018
-
-
Keith Packard authored
Allows constant strings to be passed to these functions without generating a compiler warning. Signed-off-by:Keith Packard <keithp@keithp.com>
-
- Apr 24, 2018
-
-
Adam Jackson authored
Reproducer: $ Xvfb -ac -noreset :1 & $ DISPLAY=:1 xinput create-master touch1 $ DISPLAY=:1 xinput remove-master "touch1 pointer" Bugzilla: https://bugs.freedesktop.org/105761 Signed-off-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- Apr 02, 2018
-
-
Install missing headers to the SDK directory to allow external modules to properly build against the SDK. After this commit, the list of files installed in the SDK include directory is the same as the list of files installed by the autotools-based build. Reviewed-by:
Thierry Reding <treding@nvidia.com>
-
- Feb 26, 2018
-
-
Adam Jackson authored
This plumbs the full width color for solid pictures through to fb, exa, and glamor. External drivers and acceleration code may wish to make a similar change for sufficiently new servers. v2: Don't break ABI (Michel Dänzer) v2.1: Use the (correct) full color in fb too (Michel Dänzer) Signed-off-by:
-
Adam Jackson authored
Make a solid-fill picture for this instead of a 1x1 pixmap. In principle the backend can accelerate this directly, and we also get to preserve all the bits of the fill color. Signed-off-by:
-
- Feb 23, 2018
-
-
Adam Jackson authored
Signed-off-by:
-
Adam Jackson authored
This can't happen anymore. Signed-off-by:
-
- Feb 14, 2018
-
-
Adam Jackson authored
Formerly spriteInfo->anim.pCursor would point to the animated cursor (or NULL if not animated). That value would also be available in spriteInfo->sprite->current, so instead lets use anim.pCursor to point to the current animation element. Signed-off-by:
-
- Jan 09, 2018
-
-
Adam Jackson authored
Signed-off-by:
Aaron Plattner <aplattner@nvidia.com> Tested-by:
-
Adam Jackson authored
We weren't cancelling the old timer when changing cursors, making things go all crashy. Logically we could always cancel the timer first, but then we'd have to call TimerSet to re-arm ourselves, and GetTimeInMillis is potentially expensive. Reported-by: https://devtalk.nvidia.com/default/topic/1028172/linux/titan-v-ubuntu-16-04lts-and-387-34-driver-crashes-badly/post/5230967/#5230967 Signed-off-by:
-
- Jan 08, 2018
-
-
Adam Jackson authored
Reviewed-by:
Robert Morell <rmorell@nvidia.com> Tested-by:
-
Adam Jackson authored
This is very slightly more efficient since the callback now doesn't need to walk every input device, instead we know exactly which device's cursor is being updated. AnimCurTimerNotify() gets outdented nicely as a result. A more important side effect is that we can stop using the TimerAbsolute mode and just pass in the relative delay. In AnimCurSetCursorPosition, we no longer need to rearm the timer with the new screen; it is enough to update the device's state. In AnimCurDisplayCursor we need to notice when we're switching from animated cursor to regular and cancel the existing timer. Reviewed-by:
-
Adam Jackson authored
If the return value is non-zero here, DoTimer() will automatically rearm the timer for the new (relative) delay. 'soonest' is in absolute time, so subtract off 'now' and return that. Reviewed-by:
-
Adam Jackson authored
Reviewed-by:
-
- Oct 30, 2017
-
-
Roundhouse kick replacing the various (sizeof(foo)/sizeof(foo[0])) with the ARRAY_SIZE macro from dix.h when possible. A semantic patch for coccinelle has been used first. Additionally, a few macros have been inlined as they had only one or two users. Signed-off-by:
Daniel Martin <consume.noise@gmail.com> Reviewed-by:
-
- Oct 10, 2017
-
-
v2: Add overflow check and remove unnecessary check (Julien Cristau) This addresses: CVE-2017-12184 in XINERAMA CVE-2017-12185 in MIT-SCREEN-SAVER CVE-2017-12186 in X-Resource CVE-2017-12187 in RENDER Reviewed-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com> Reviewed-by:
Julien Cristau <jcristau@debian.org> Signed-off-by:
Nathan Kidd <nkidd@opentext.com> Signed-off-by:
-
- Apr 26, 2017
-
-
Emma Anholt authored
This is a work in progress that builds Xvfb, Xephyr, Xwayland, Xnest, and Xdmx so far. The outline of Xquartz/Xwin support is in tree, but hasn't been built yet. The unit tests are also not done. The intent is to build this as a complete replacement for the autotools system, then eventually replace autotools. meson is faster to generate the build, faster to run the bulid, shorter to write the build files in, and less error-prone than autotools. v2: Fix indentation nits, move version declaration to project(), use existing meson_options for version-config.h's vendor name/web. Signed-off-by:Eric Anholt <eric@anholt.net> Acked-by:
-
- Mar 13, 2017
-
-
ProcRenderCreateRadialGradient and ProcRenderCreateConicalGradient must be protected against an integer overflow during length check. This is already included in ProcRenderCreateLinearGradient since the fix for CVE-2008-2362. This can only be successfully exploited on a 32 bit system for an out of boundary read later on. Validated by using ASAN. Reviewed-by:
-
- Mar 01, 2017
-
-
Adam Jackson authored
This touches everything that ends up in the Xorg binary; the big missing part is GLX since that's all generated code. Cuts about 14k from the binary on amd64. Signed-off-by:
-
- Jun 17, 2016
-
-
Maarten Lankhorst authored
Fixes freedesktop.org bug https://bugs.freedesktop.org/show_bug.cgi?id=67484 If t->bottom is close to MIN_INT, removing top can wraparound, so do the check properly. A similar fix should also be applied to pixman. Signed-off-by:
Maarten Lankhorst <maarten.lankhorst@canonical.com> Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
- May 11, 2016
-
-
Adam Jackson authored
Private storage is pre-zeroed by the private system itself. Signed-off-by:
-
- Mar 08, 2016
-
-
Probably pointless, if this fails you're not likely to get far... Reviewed-by:
Rémi Cardona <remi@gentoo.org> Signed-off-by:
-
- Dec 01, 2015
-
-
This replaces the block/wakeup handlers with an OsTimer. This also avoids problems with performing rendering during the wakeup handler. Reviewed-by:
-
- Oct 06, 2015
-
-
All the callers were already checking for failure, except that createSourcePicture() itself was failing to check whether it successfully allocated the Picture. [ajax: Rebase, fix line wrap of preceding line] Signed-off-by:
Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by:
-
- Sep 23, 2015
-
-
==11097== 2,048 (+1,640) bytes in 32 (+26) blocks are definitely lost in loss record 1,570 of 1,719 ==11097== at 0x4C2A2DB: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==11097== by 0x225EF3: SetPicturePictFilter (filter.c:339) ==11097== by 0x22DF4F: ProcRenderSetPictureFilter (render.c:1773) ==11097== by 0x15D25D: Dispatch (dispatch.c:432) ==11097== by 0x14C7B9: main (main.c:298) [ajax: Fixed whitespace] Reviewed-by:
-
The Render specification allows single-stop gradients and pixman 0.22 (X server requires >= 0.27.2 now) can rasterize them correctly. [ajax: update commit message] Signed-off-by:
Andrea Canciani <ranma42@gmail.com> Reviewed-by:
Soren Sandmann <ssp@redhat.com>
-
- Sep 21, 2015
-
-
Adam Jackson authored
Since ProcRenderScale throws BadImplementation anyway it's pointless to waste time carefully swapping the request. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- Jul 08, 2015
-
-
Adam Jackson authored
Acked-by:
-
- Apr 21, 2015
-
-
Alan Coopersmith authoredv2: remove now useless parentheses Signed-off-by:
Matt Turner <mattst88@gmail.com>
-
- Dec 09, 2014
-
-
Alan Coopersmith authored
Signed-off-by:
-
Otherwise we may be reading outside of the client request. Signed-off-by:
-
- Nov 30, 2014
-
-
ChangePicture takes wire XIDs, but didn't do any Xinerama translation, which meant setting a clip pixmap or a separate alpha picture would result in those elements pointing at the instance of the pixmap on screen 0. Which is, you know, bad. v2: This one actually builds. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49170 Signed-off-by:
-
- Nov 12, 2014
-
-
Peter Hutterer authored
sed -i "s/[ ]\+$//g" **/*.(c|h) happy reviewing... git diff -w is an empty diff. Signed-off-by:
-
- Oct 23, 2014
-
-
This does have one semantic change. FixesCreateRegionFromPicture used to throw BadImplementation if you tried to create a region from a picture with no client clip. I changed that to BadMatch here since that more honestly describes what's going on. Signed-off-by:
-
- Jul 29, 2014
-
-
Adam Jackson authored
Arguably this would be useful API, but it's never called, and a careful reading of the CPClipMask path reveals that callers would be fairly disappointed. Reviewed-by:
-
- Apr 22, 2014
-
-
Just throw BadPicture instead of crashing. It's not currently a meaningful thing to do anyway, RenderSetPictureRectangles would error if you tried (which this patch changes to BadPicture as well for consistency). The problem with trying to do it is if the clip is specified as a pixmap then we try to convert it to a region, and ->BitmapToRegion requires a ScreenPtr, and source-only pictures don't have one. I can imagine a use for client clip on source-only pictures, so if we really wanted to allow this, probably the way forward is to always store the clip as a region internally, and when setting the clip _from_ a pixmap, look up BitmapToRegion relative to the pixmap not the picture. But since clearly nobody can be relying on it working... Signed-off-by:
-
- Jan 12, 2014
-
-
Keith Packard authored
This lets us stop using the 'pointer' typedef in Xdefs.h as 'pointer' is used throughout the X server for other things, and having duplicate names generates compiler warnings. Signed-off-by:
-
- May 15, 2013
-
-
Peter Hutterer authored
Too many callers relied on the refcnt being handled correctly. Use a simple wrapper to handle that case. Signed-off-by:
-
- Jan 09, 2013
-
-
The loop above the previous call may end up triggering other handlers attaching to the same function slot, so unwrapping the handler after that could leave the just attached handler in a dangling but not unset state. This issue was most visible on the XO, where destroying a window with an animated cursor set and running would trigger this inconsistent state, never calling the miSpriteBlockHandler again after the animated cursor is unset. Signed-off-by:
Carlos Garnacho <carlosg@gnome.org> Reviewed-by:
-
- Nov 05, 2012
-
-
Yaakov Selkowitz authored
Signed-off-by:
Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Reviewed-by:
-
