- Jul 28, 2022
-
-
New version of uPEP will have a separate ACPI id, add that to the support list. Signed-off-by:
Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Reviewed-by:
Mario Limonciello <mario.limonciello@amd.com> Signed-off-by:
Rafael J. Wysocki <rafael.j.wysocki@intel.com> (cherry picked from commit ed470feb)
-
PMC driver can be supported on a new upcoming platform. Add this information to the support list. Signed-off-by:
Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Link: https://lore.kernel.org/r/20220630050324.3780654-2-Shyam-sundar.S-k@amd.com Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 530ef2a6e81c74c19f918713e519e85652e53a83)
-
New version of PMC controller will have a separate ACPI id, add that to the support list. Signed-off-by:
Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Link: https://lore.kernel.org/r/20220630050324.3780654-1-Shyam-sundar.S-k@amd.com Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 0f52752973e8a6daf88c485462ff765dd81492de)
-
Currently, AMD supported platform drivers are grouped under generic "x86" folder structure. Move the current drivers (amd-pmc and amd_hsmp) to a separate directory. This would also mean the newer driver submissions to pdx86 subsystem in the future will also land in AMD specific directory. Reviewed-by:
Naveen Krishna Chatradhi <NaveenKrishna.Chatradhi@amd.com> Tested-by:
Suma Hegde <suma.hegde@amd.com> Signed-off-by:
Shyam Sundar S K <Shyam-sundar.S-k@amd.com> Link: https://lore.kernel.org/r/20220608193212.2827257-1-Shyam-sundar.S-k@amd.com Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit ef233eaf)
-
If CONFIG_SUSPEND and CONFIG_DEBUG_FS are not set. compile error: drivers/platform/x86/amd-pmc.c:323:12: error: ‘get_metrics_table’ defined but not used [-Werror=unused-function] static int get_metrics_table(struct amd_pmc_dev *pdev, struct smu_metrics *table) ^~~~~~~~~~~~~~~~~ drivers/platform/x86/amd-pmc.c:298:12: error: ‘amd_pmc_idlemask_read’ defined but not used [-Werror=unused-function] static int amd_pmc_idlemask_read(struct amd_pmc_dev *pdev, struct device *dev, ^~~~~~~~~~~~~~~~~~~~~ drivers/platform/x86/amd-pmc.c:196:12: error: ‘amd_pmc_get_smu_version’ defined but not used [-Werror=unused-function] static int amd_pmc_get_smu_version(struct amd_pmc_dev *dev) ^~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors To fix building warning, wrap all related code with CONFIG_SUSPEND or CONFIG_DEBUG_FS. Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Ren Zhijie <renzhijie2@huawei.com> Link: https://lore.kernel.org/r/20220505121958.138905-1-renzhijie2@huawei.com Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 17faaaca)
-
When CONFIG_DEBUG_FS is disabled, amd_pmc_get_smu_version() is unused: drivers/platform/x86/amd-pmc.c:196:12: warning: unused function 'amd_pmc_get_smu_version' [-Wunused-function] static int amd_pmc_get_smu_version(struct amd_pmc_dev *dev) ^ 1 warning generated. Eliminate the warning by moving amd_pmc_get_smu_version() to the CONFIG_DEBUG_FS block where it is used. Fixes: b0c07116 ("platform/x86: amd-pmc: Avoid reading SMU version at probe time") Signed-off-by:
Nathan Chancellor <nathan@kernel.org> Reviewed-by:
Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20220418213800.21257-1-nathan@kernel.org Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit acd51562)
-
Currently the SMU version only used to determine whether the SMU supports reading the idle mask. To speed up startup, move it to the first time the idle mask is read. This decreases the startup time from ~28500us to 100us. Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20220411143820.13971-3-mario.limonciello@amd.com Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit b0c07116)
-
FCH address is accessed only when looking at s0ix stats. As this is unnecessary for initialization, move it ito the first time stats are accessed from sysfs. This descrease startup time by about 200us. Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20220411143820.13971-2-mario.limonciello@amd.com Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 63585d59)
-
SMU logging is setup when the device is probed currently. In analyzing boot performance it was observed that amd_pmc_probe is taking ~116800us on startup on an OEM platform. This is longer than expected, and is caused by enabling SMU logging at startup. As the SMU logging is only needed for debugging, initialize it only upon use. This decreases the time for amd_pmc_probe to ~28800us. Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20220411143820.13971-1-mario.limonciello@amd.com Signed-off-by:
Hans de Goede <hdegoede@redhat.com> (cherry picked from commit 0c211cec)
-
Add a KUnit test to check that buffer allocation works also for devices with no DP adapters. Signed-off-by:
Gil Fine <gil.fine@intel.com> Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit c7c99a09)
-
For the case of a device without DisplayPort adapters we calculate incorrectly the amount of buffers. Fix the calculation for this case. Signed-off-by:
Gil Fine <gil.fine@intel.com> Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 93bf344f)
-
The USB4 Inter-Domain Service specification defines a protocol that can be used to establish lane bonding between two USB4 domains (hosts). So far we have not implemented it because the host controller DMA was not fast enough to be able to go over 20 Gbits/s even if lanes were bonded. However, starting from Intel Alder Lake CPUs the DMA can go over 20 Gbits/s so now it makes more sense to add this support to the driver. Because both ends need to negotiate the bonding we add a simple state machine that tracks the connection state and does the necessary steps described by the USB4 Inter-Domain Service specification. We only establish lane bonding when both sides of the link support it. Otherwise we default to use the single lane. Also this is only done when software connection manager is used. On systems with firmware based connection manager, it handles the high-speed tunneling so bonding lanes is specific to the implementation (Intel firmware based connection manager does not support lane bonding). Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 8e1de704)
-
Sometimes when polling for the port after target link width is changed we get back port locked notification (because the link actually was reset and then re-trained). Instead of bailing out we can ignore these when polling for the width change as this is expected. Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 0a2e1667)
-
When bonding lanes over XDomain the host that has "higher" UUID triggers link re-train for bonding, and the host that has "lower" UUID just waits for this to happen. To support this split setting the link width and triggering the actual bonding a separate functions that can be called as needed. While there remove duplicated empty line in the kernel-doc comment of tb_port_lane_bonding_disable(). Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 0e14dd5e)
-
This should be before tb_wait_for_port() following how the functions in switch.c are organized. Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 94581b25)
-
Chengming Gui authored
Add PSP_V13 memory training support funcs. v2: replace DRM_{DEBUG/ERROR} with dev_{dbg/err}. (Hawking) Signed-off-by:
Chengming Gui <Jack.Gui@amd.com> Reviewed-by:
Hawking Zhang <Hawking.Zhang@amd.com> Change-Id: Ic59f31c95897cc983e1d73335d4b44e159373369
-
This is useful when debugging possible issues. Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 90f720d2)
-
Creating a symlink pointing to the correct USB Type-C connector for the on-board USB4 ports when they are created. The link will be created only if the firmware is able to describe the connection between the port and its connector. Signed-off-by:
Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by:
Won Chung <wonchung@google.com> Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 5dddb416)
-
This is useful when debugging possible issues during tunnel discovery. Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Tested-by:
Brad Campbell <lists2009@fnarfbargle.com> (cherry picked from commit 259e0c71)
-
This makes it consistent with the other logging functions. Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Tested-by:
Brad Campbell <lists2009@fnarfbargle.com> (cherry picked from commit ebe99c0f)
-
Should be 'in' instead of 'bin'. Fix it. Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Tested-by:
Brad Campbell <lists2009@fnarfbargle.com> (cherry picked from commit ca319f55)
-
Replace the NULL checks with the more specific and idiomatic NULL macros. Acked-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by:
Daniel Latypov <dlatypov@google.com> Signed-off-by:
Ricardo Ribalda <ribalda@chromium.org> Acked-by:
Brendan Higgins <brendanhiggins@google.com> Signed-off-by:
Shuah Khan <skhan@linuxfoundation.org> (cherry picked from commit 7aadf843)
-
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ Signed-off-by:
Jakob Koschel <jakobkoschel@gmail.com> Signed-off-by:
Mika Westerberg <mika.westerberg@linux.intel.com> (cherry picked from commit 03941ed9)
-
Update PCI revision id check for the new YC platform varaint. Signed-off-by:
Vijendar Mukunda <Vijendar.Mukunda@amd.com> Link: https://lore.kernel.org/r/20220411134119.1767646-1-Vijendar.Mukunda@amd.com Signed-off-by:
Mark Brown <broonie@kernel.org> (cherry picked from commit b1630fcb)
-
- Update defconfig for PCI_P2PDMA - Update defconfig for DMABUF_MOVE_NOTIFY - Update defconfig for HSA_AMD_P2P Signed-off-by:
Ramesh Errabolu <Ramesh.Errabolu@amd.com> Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com>
-
Also enable ACPI HMAT support, to fix boot crash or amdgpu init failure on ALDEBARAN. v2: - Use make savedefconfig to minimize the changes, skipping redundant configs that are implied by others or have same value as default. Signed-off-by:
Philip Yang <Philip.Yang@amd.com> Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com>
-
- Update debug config for Checkpoint-Restore (CR) support - Also include necessary options for CR with docker containers. Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Also build drm as module to make debugging easier. Signed-off-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Enable the Intel IOMMU driver in the rock-dbg_defconfig. This enables testing of DMA mappings on systems with an Intel IOMMU. Signed-off-by:
Felix Kuehling <Felix.Kuehling@amd.com> Acked-by:
Oak Zeng <Oak.Zeng@amd.com> Acked-by:
Ramesh Errabolu <Ramesh.Errabolu@amd.com>
-
Update rock-dbg_defconfig for the 5.11 kernel. Enable CONFIG_DEVICE_PRIVATE, which is needed by the new HMM-based SVM memory manager. Signed-off-by:
Felix Kuehling <Felix.Kuehling@amd.com>
-
Lang Yu authored
No need to reference the BO here, dmabuf framework will handle that. Signed-off-by:
Lang Yu <Lang.Yu@amd.com> Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com>
-
Shikai Guo authored
add get_gfx_off_status interface to yellow_carp_ppt_funcs structure. Signed-off-by:
Shikai Guo <shikai.guo@amd.com> Reviewed-by:
Aaron Liu <aaron.liu@amd.com> Reviewed-by:
Prike Liang <prike.liang@amd.com> Reviewed-by:
Evan quan <evan.quan@amd.com>
-
Yong Zhao authored
This file only turns on a substantial smaller set of kernel options, together with all AMD stuff, and supports most use cases on common HW configurations. As a result, building kernel with this config is super fast. Moreover, with this config, KFD folks can easily build the kernel with build_kernel.sh script and verify the change before we push the commit out for review on amd-gfx mailist. Signed-off-by:
Yong Zhao <Yong.Zhao@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Maíra Canal authored
All references to struct freesync_context were removed, so remove the struct freesync_context itself and its entry on struct dc_stream_state. Reviewed-by:
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Signed-off-by:
Maíra Canal <mairacanal@riseup.net>
-
xinhui pan authored
Need get the new fence when we replace the old one. Fixes: 047a1b87 ("dma-buf & drm/amdgpu: remove dma_resv workaround") Signed-off-by:
xinhui pan <xinhui.pan@amd.com> Reviewed-by:
Christian König <christian.koenig@amd.com>
-
Chengming Gui authored
Add three additional page fault settings. V2: move reg offset definition to header file. (Alex) V3: add all shift/mask definitions of used reg. (Hawking) Signed-off-by:
Chengming Gui <Jack.Gui@amd.com> Reviewed-by:
Hawking Zhang <Hawking.Zhang@amd.com> Change-Id: Ibab979853fd233a1c2017672f2534947fa1d637d
-
- Jul 27, 2022
-
-
Yang Li authored
Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon Reported-by:
Abaci Robot <abaci@linux.alibaba.com> Reviewed-by:
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Signed-off-by:
Yang Li <yang.lee@linux.alibaba.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Vijendar Mukunda authored
Fixed following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() error: buffer overflow 'i2s_pdata' 3 <= 3 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init() error: buffer overflow 'i2s_pdata' 3 <= 3 Fixes: 4c33e517 ("drm/amdgpu: create I2S platform devices for Jadeite platform") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Vijendar Mukunda <Vijendar.Mukunda@amd.com> Acked-by:
Alex Deucher <alexander.deucher@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Lang Yu authored
The kgd_mem memory allocated in amdgpu_amdkfd_gpuvm_import_dmabuf() is not freed properly. Explicitly free it in amdgpu_amdkfd_gpuvm_free_memory_of_gpu() under condition "mem->bo->kfd_bo != mem". Suggested-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Lang Yu <Lang.Yu@amd.com> Reviewed-by:
Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Alex Sierra authored
This keeps track of kfd system mem used and kfd ttm mem used. Signed-off-by:
Alex Sierra <alex.sierra@amd.com> Reviewed-by:
Philip Yang <Philip.Yang@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-