Skip to content
Snippets Groups Projects
  1. Mar 15, 2021
  2. Mar 10, 2021
    • Guillaume Desmottes's avatar
      audioaggregator: fix input_buffer ownership · 42b4ed92
      Guillaume Desmottes authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      The way pad->priv->input_buffer reference was managed was pretty
      spurious:
      - it was overridden without unrefing it, which could potentially lead to
        leaks.
      - we were unreffing it while keeping the pointer around, which could
        potentially lead to use-after-free or double-free.
      
      As priv->input_buffer is actually no longer used outside of the
      aggregate() method, remove it from pad->priv to simplify the code and
      prevent the issues desribed above.
      
      Fix a single buffer leak when shutting down the pipeline as the buffer
      returned from gst_aggregator_pad_drop_buffer() was never unreffed.
      
      Part-of: <gstreamer/gst-plugins-base!1062>
      42b4ed92
    • Guillaume Desmottes's avatar
      audioaggregator: fix input buffer when converting · 48416f80
      Guillaume Desmottes authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      This code path is meant to convert the current buffer to the new format
      on update. It was using priv->input_buffer as input which is either
      priv->buffer or a converted version of it.
      Use priv->buffer instead as priv->input_buffer may no longer be a valid
      reference.
      
      Part-of: <gstreamer/gst-plugins-base!1062>
      48416f80
  3. Feb 26, 2021
  4. Feb 25, 2021
  5. Feb 24, 2021
  6. Feb 19, 2021
  7. Feb 17, 2021
  8. Jan 30, 2021
  9. Jan 28, 2021
  10. Jan 14, 2021
  11. Jan 13, 2021
  12. Jan 12, 2021
  13. Jan 05, 2021
  14. Jan 04, 2021
  15. Jan 01, 2021
    • Mathieu Duponchelle's avatar
      compositor/blend: fix blending of subsampled components · 0fdc1ca8
      Mathieu Duponchelle authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      The correct way to determine the byte offset at a certain yoffset
      in a subsampled component is to shift the yoffset by the component's
      hsub
      
      This fixes out-of-bounds memory accesses and visible artefacts,
      example pipeline with the samples from #802:
      
      gst-launch-1.0 compositor name=vmixer sink_1::xpos=1910 sink_1::ypos=1080 ! \
          videoconvert ! videorate ! xvimagesink \
        filesrc location=VID_20200723_203606.mp4 ! decodebin name=demux1 ! \
          queue ! videoflip method=vertical-flip ! vmixer. \
        filesrc location=bridgeoverstubbledwater.mp4 ! decodebin name=demux2 ! \
          queue ! vmixer.
      
      Part-of: <gstreamer/gst-plugins-base!989>
      0fdc1ca8
  16. Dec 31, 2020
    • Mathieu Duponchelle's avatar
      appsrc: fix signal documentation · a85b149f
      Mathieu Duponchelle authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Part-of: <gstreamer/gst-plugins-base!993>
      a85b149f
    • Edward Hervey's avatar
      videoaggregator: Pop out old buffers on timeout · 8149de13
      Edward Hervey authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      This situation happens in the situation where an input stream has a framerate
      exceeding the timeout latency (Ex: 1fps with a latency of 500ms) and an input
      stream greater than output framerate (ex: 60fps in, 30 fps out).
      
      The problem that would happen is that we would timeout, but then buffers from
      the fast input stream would only be popped out one by one.... until a buffer
      reaches the low-framerate input stream at which point they would quickly be
      popped out/used. The resulting output would be "slow ... fast ... slow ... fast"
      of that input fast stream.
      
      In order to avoid this situation, whenever we detect a late buffer, check if
      there's a next one and re-check with that one.
      
      Part-of: <gstreamer/gst-plugins-base!991>
      8149de13
  17. Dec 15, 2020
  18. Dec 14, 2020
    • Jordan Petridіs's avatar
      libvisual: workaround clang warning · a26d82ba
      Jordan Petridіs authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      libvisual api expects a priv data pointer to be passed, though we know its
      going to be `GstDebugLevel`.
      
      ```
      ../subprojects/gst-plugins-base/ext/libvisual/plugin.c:33:39: error: cast to smaller integer type 'GstDebugLevel' from 'void *' [-Werror,-Wvoid-pointer-to-enum-cast]
       GST_CAT_LEVEL_LOG (libvisual_debug, (GstDebugLevel) (priv), NULL, "%s - %s",
      ```
      
      Part-of: <gstreamer/gst-plugins-base!976>
      a26d82ba
  19. Dec 11, 2020
  20. Dec 06, 2020
  21. Dec 05, 2020
  22. Dec 04, 2020
  23. Dec 02, 2020
Loading