- Jan 28, 2020
-
-
Dylan Baker authored
-
Dylan Baker authored
-
Marek Olšák authored
Decompress resources properly but don't do it inside launch_grid to prevent recursion. (cherry-picked from df34fa14) Reviewed-by:
Marek Olšák <marek.olsak@amd.com>
-
Marek Olšák authored
(cherry-picked from 58c929be) Reviewed-by:
Marek Olšák <marek.olsak@amd.com>
-
This is not always ->rgbBits, because there are cases where that could be 32 but we're (legally) bound to a depth-24 pixmap. The important thing to have match here is the actual server-side notion of depth. You can look this up (at modest expense) from the xlib visual info if the fbconfig has a visual. But it might not, so if not, fetch it (at slightly greater expense) from XGetGeometry. Do this at GLX drawable creation so you don't have to do it on the SwapBuffers path. Apparently this fixes glx/glx-swap-singlebuffer, which is unintentional but quite pleasant. Fixes: #2291 Fixes: 90d58286 ("drisw: Fix and simplify drawable setup") Reviewed-by:
Eric Anholt <eric@anholt.net> Tested-by: Marge Bot <!3305> Part-of: <!3305> (cherry picked from commit 2fc11e8a) Conflicts: .gitlab-ci/piglit/quick_gl.txt This testing doesn't exist in the 19.3 branch, so I've deleted the file. Dylan
-
The SOPP instruction shouldn't have a definition, and its block should be set to -1 in order to prevent it from being recognized as a branch. Also fix a typo in the readme. Fixes: d6dfce02 Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Tested-by: Marge Bot <mesa/mesa!3552> Part-of: <mesa/mesa!3552> (cherry picked from commit c787b8d2)
-
ALIGN() brilliantly uses uintptr_t, making it unsafe for use with 64-bit GPU addresses in 32-bit builds of the driver. Use align64() instead, which uses uint64_t. Fixes assertion failures when running any 32-bit program on Tigerlake. Fixes: 2e6a7ced ("iris/gen12: Write GFX_AUX_TABLE base address register") Fixes: 0d0290bb ("intel/common: Add surface to aux map translation table support") Reviewed-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Tested-by: Marge Bot <mesa/mesa!3507> Part-of: <mesa/mesa!3507> (cherry picked from commit 8dc0540a)
-
Cc: 19.3 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Tested-by: Marge Bot <!3231> Part-of: <!3231> (cherry picked from commit 2fd85105)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Closes: mesa/mesa#2394 Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler') Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Tested-by: Marge Bot <mesa/mesa!3511> Part-of: <mesa/mesa!3511> (cherry picked from commit 15a1cc00)
-
If the driver fails to allocate memory for some reasons, it shouldn't free the 'mem' object twice. Closes: mesa/mesa#2302 Fixes: 825ddfee ("radv: Handle device memory alloc failure with normal free.") Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Tested-by: Marge Bot <mesa/mesa!3508> Part-of: <mesa/mesa!3508> (cherry picked from commit bd51538d)
-
Problem with previous solution was that it did not take account that some applications may set a max count for buffers. Therefore we need to query both min and max and clamp our setting based on that. Closes: mesa/mesa#2373 Fixes: be08e6a4 ("egl/android: Restrict minimum triple buffering for android color_buffers") Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Tested-by: Marge Bot <mesa/mesa!3480> Part-of: <mesa/mesa!3480> (cherry picked from commit 39e7492d)
-
I strongly suspect it was supposed to be a typedef. However, used nowhere, we should remove it. Fixes: eaa56eab "radv: initial support for shared semaphores (v2)" Closes: mesa/mesa#2385 Reviewed-by:
Michel Dänzer <mdaenzer@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Tested-by: Marge Bot <mesa/mesa!3479> Part-of: <mesa/mesa!3479> (cherry picked from commit bd4380c6)
-
When VK_DESCRIPTOR_TYPE_SAMPLER is provided, it doesn't need to be counted as a buffer count. Otherwise it leads to mismatch of allocated buffer size, hitting VK_ERROR_OUT_OF_POOL_MEMORY finally. Fixes: c39afe68 Also fixes amber tests: ./tests/cases/address_modes_float.amber ./tests/cases/address_modes_int.amber ./tests/cases/magfilter_linear.amber ./tests/cases/magfilter_nearest.amber Reviewed-by:
Jonathan Marek <jonathan@marek.ca> (cherry picked from commit 26d93a74)
-
Jan Vesely authored
Fixes piglits that use ADMGCN inline assembly: program@execute@calls program@execute@amdgcn-mubuf-negative-vaddr CC: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Jan Vesely <jan.vesely@rutgers.edu> (cherry picked from commit 87e1f8ec)
-
Faith Ekstrand authored
Fixes: 16eb3908 "anv: add VK_EXT_display_control to anv driver [v5]" Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!3461> (cherry picked from commit f0519c9c)
-
Faith Ekstrand authored
Some formats, in particular YCbCr formats and ASTC have additional restrictions. We already whack ASTC formats to RGBA32_UINT because the hardware doesn't allow LINEAR with ASTC. However, we need to fix YCbCr formats as well because they come with alignment restrictions that we can't guarantee are satisfied. We're using blorp_copy to do the copies so we may as well just stomp formats for everything. Fixes: b24b93d5 "anv: enable VK_KHR_sampler_ycbcr_conversion" Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Tested-by: Marge Bot <mesa/mesa!3460> Part-of: <mesa/mesa!3460> (cherry picked from commit dd92179a)
-
Faith Ekstrand authored
The new names fit better with the Vulkan names and don't pretend to be an actual image extent. Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!3460> (cherry picked from commit 14c6e665)
-
Fixes: bc17ac58 "docs: add documentation for building with meson" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit b009a764)
-
The pre-tag right before is a block-level tag, which means it implicitly terminates the paragraph. So there's no paragraph to close after this. Instead, move the paragraph-closing before the pre-tag, to explicitly close the paragraph. Fixes: 41b3eb08 "docs: update meson docs for windows" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit b387f68f)
-
Similar to the previous two commits, it seems more appropriate to use code-tags here than pre-tag. Fixes: 9af6c38d "docs: Add use of Closes: tag for closing gitlab issues" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit a370cfd9)
-
Similar to the previous commit, code-tags seems more appropriate than pre-tags here. So let's change it. Fixes: ca0c1e69 "docs: update releasing process to use new scripts and gitlab" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit 1de361e5)
-
It's unlikely the author meant to use <pre>-here, as that starts a whole new block. Instead, the inline code-tag seems more appropriate here. Fixes: 41b3eb08 "docs: update meson docs for windows" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit 36e02752)
-
Fixes: 44c5e634 "docs: update meson docs for windows" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit f0677086)
-
Paragraphs are terminated by pre-tags, so the latter one closes a new, empty one. Let's split the paragraph in two around the pre-tag instead. Fixes: c0dfe8c6 "docs: do not use div for line-breaking" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit a0d25c4d)
-
Fixes: 5d11a828 "docs: update install docs for meson" Acked-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!3431> (cherry picked from commit 750d6642)
-
Pierre-Eric Pelloux-Prayer authored
Fixes the following valgrind error: Invalid read of size 16 at 0x28F458A1: si_set_sampler_view_desc (in radeonsi_drv_video.so) by 0x28F4657E: si_set_sampler_views (in radeonsi_drv_video.so) by 0x28D62BF5: util_compute_blit (in radeonsi_drv_video.so) by 0x28D3A944: vlVaHandleVAProcPipelineParameterBufferType (in radeonsi_drv_video.so) by 0x28D34EE1: vlVaRenderPicture (in radeonsi_drv_video.so) by 0x4B2582B: vaRenderPicture (in libva.so.2.500.0) Address 0x18142a10 is 0 bytes inside a block of size 48 free'd at 0x48369AB: free (vg_replace_malloc.c:540) by 0x28D62D51: util_compute_blit (in radeonsi_drv_video.so) by 0x28D3A944: vlVaHandleVAProcPipelineParameterBufferType (in radeonsi_drv_video.so) by 0x28D34EE1: vlVaRenderPicture (in radeonsi_drv_video.so) by 0x4B2582B: vaRenderPicture (in libva.so.2.500.0) Block was alloc'd at at 0x4837B65: calloc (vg_replace_malloc.c:762) by 0x28EFB2EC: si_create_sampler_state (in radeonsi_drv_video.so) by 0x28D62C30: util_compute_blit (in radeonsi_drv_video.so) by 0x28D3A944: vlVaHandleVAProcPipelineParameterBufferType (in radeonsi_drv_video.so) by 0x28D34EE1: vlVaRenderPicture (in radeonsi_drv_video.so) by 0x4B2582B: vaRenderPicture (in libva.so.2.500.0) Fixes: 69430d7e ("va: use a compute shader for the blit") Closes: mesa/mesa#2321 Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Tested-by: Marge Bot <mesa/mesa!3428> Part-of: <mesa/mesa!3428> (cherry picked from commit 5b1c4e1b)
-
Eric Engestrom authored
Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Tested-by: Marge Bot <!3391> Part-of: <!3391> (cherry picked from commit 65641e0c)
-
This patch changes lower_to_cssa to be much more conservative about assumptions which phi operands might interfere. Previously, this pass wasn't exhaustive and could miss some corner cases. v2: remove optimizations to find better insertion points as it's hard to guarantee that they are always correct and have overall no benefit. Fixes: 0b8216b2 ('aco: Lower to CSSA') Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!3385> (cherry picked from commit d098024c)
-
Also forgotten in the initial implementation. v2: Report begin timestamp scaled by the timestamp frequency (Windows behavior) v3: Rename split to disjoint to match GL terminology (Tapani) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Acked-by:
Tapani Pälli <tapani.palli@intel.com> Tested-by: Marge Bot <mesa/mesa!3112> Part-of: <mesa/mesa!3112> (cherry picked from commit 44ffeb4f)
-
This was forgotten in the initial implementation. v2: ensure the value is written for both GL & Vulkan queries Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Acked-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!3112> (cherry picked from commit 3bb8a4bf)
-
Marek Olšák authored
Cc: 19.2 19.3 <mesa-stable@lists.freedesktop.org> Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Tested-by: Marge Bot <mesa/mesa!3338> Part-of: <mesa/mesa!3338> (cherry picked from commit 8ff8e68e)
-
get_nir_image_intrinsic_image() was incorrectly mutating the value held by the register which holds the intrinsic's first source (image index). If this happened to be the register for an SSA def which is also used elsewhere in the program, this meant that we would clobber that value in subsequent uses. Note that this only affects i965, because neither anv nor iris use the binding table start sections, so nothing is ever added here. Fixes KHR-GL46.compute_shader.resources-max on i965 with Eric Anholt's MR !3240 applied. That MR reorders SSBOs and ABOs, so that test uses image 0 and SSBO 0, causing this code to brilliantly add binding table index 45 to both the image (correct) and the SSBO (bzzt, wrong!). Fixes: 09f1de97 ("anv,i965: Lower away image derefs in the driver") Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Tested-by: Marge Bot <mesa/mesa!3404> Part-of: <mesa/mesa!3404> (cherry picked from commit 0a1c4707)
-
Dylan Baker authored
-
- Jan 15, 2020
-
-
This fixes YUYV support on etnaviv. Fixes: 7404833c "gallium: add handling for YUV planar surfaces" Signed-off-by:
Jonathan Marek <jonathan@marek.ca> Reviewed-by:
Christian Gmeiner <christian.gmeiner@gmail.com>
-
Pierre-Eric Pelloux-Prayer authored
Closes: mesa/mesa#2248 Fixes: 095a5820 ("radeonsi: expand FMASK before MSAA image stores are used") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!3174> (cherry picked from commit c2df5389)
-
Pierre-Eric Pelloux-Prayer authored
'coord' variable was using TGSI_WRITEMASK_XYZ so subsequent uses of TGSI_WRITEMASK_W were dropped. The result for a 2 samples program was: 0: UMAD TEMP[0].xy, SV[1].xyyy, IMM[0].xxxx, SV[0].xyyy 1: STORE IMAGE[0], TEMP[0], TEMP[1], RESTRICT, 2D_MSAA 2: STORE IMAGE[0], TEMP[0], TEMP[2], RESTRICT, 2D_MSAA 3: END instead of the expected: 0: UMAD TEMP[0].xy, SV[1].xyyy, IMM[0].xxxx, SV[0].xyyy 1: MOV TEMP[0].w, IMM[0].yyyy 2: LOAD TEMP[1], IMAGE[0], TEMP[0], RESTRICT, 2D_MSAA 3: MOV TEMP[0].w, IMM[0].zzzz 4: LOAD TEMP[2], IMAGE[0], TEMP[0], RESTRICT, 2D_MSAA 5: MOV TEMP[0].w, IMM[0].yyyy 6: STORE IMAGE[0], TEMP[0], TEMP[1], RESTRICT, 2D_MSAA 7: MOV TEMP[0].w, IMM[0].zzzz 8: STORE IMAGE[0], TEMP[0], TEMP[2], RESTRICT, 2D_MSAA 9: END This fixes half of mesa/mesa#2248 Fixes: 095a5820 ("radeonsi: expand FMASK before MSAA image stores are used") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!3174> (cherry picked from commit b5e748b4)
-
The patch restricts triple buffering as minimum at driver for android color_buffers in order to fix onscreen performance hit for T-Rex and Manhattan. v2: Update min_buffer check condition (Tapani Pälli) v3: further code cleanup (Eric Engestrom) Closes: mesa/mesa#2332 Fixes: 0661c357 ("egl/android: Update color_buffers querying for buffer age") Signed-off-by:
Nataraj Deshpande <nataraj.deshpande@intel.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Tested-by: Marge Bot <mesa/mesa!3384> Part-of: <mesa/mesa!3384> (cherry picked from commit be08e6a4)
-
Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2350 Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Tested-by: Marge Bot <mesa/mesa!3392> Part-of: <mesa/mesa!3392> (cherry picked from commit 5ff12322)
-
Workaround for mesa/mesa#2163 CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Tested-by: Marge Bot <mesa/mesa!3236> Part-of: <mesa/mesa!3236> (cherry picked from commit 4e3c8151)
-
Dylan Baker authored
-