- Jun 08, 2023
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Eric Engestrom authored
I should've done this just after doing the .0 release but I forgot :]
-
cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!23515> (cherry picked from commit c3c9e281)
-
Since these were added to generic translation, lavapipe has been annoyed. Cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!23486> (cherry picked from commit d99dca86)
-
There is a typo in fixup_gfx9_cs_copy. Fixed dEQP-VK.api.copy_and_blit.*.image_to_buffer.2d_images.mip_copies_bc*_64x192_* in deqp 1.3.6.0. Fixes: 35f053ba ("radv: Fix corrupted mipmap copies on GFX9+") Part-of: <mesa/mesa!23483> (cherry picked from commit d0d7dda8)
-
We have to flush all event dependencies inside clWaitForEvents and clFinish implicitly otherwise applications might wait forever. Closes: mesa/mesa#9052 Fixes: ebfffa1d ("rusticl/event: wrong but non crashing impl of clWaitForEvents") Cc: mesa-stable Signed-off-by: Karol Herbst <git@karolherbst.de> Part-of: <mesa/mesa!23110> (cherry picked from commit 8616c0a5)
-
We need this rustc bugfix: https://github.com/rust-lang/rust/commit/6466f89fc5df36b4c841fca9d10e27c50dd744b5 Cc: mesa-stable Signed-off-by: Karol Herbst <git@karolherbst.de> Part-of: <mesa/mesa!23110> (cherry picked from commit 86dd5dd8)
-
These functions are used by gl[Get]TexImage, which imposes no alignment restructions on the void *pixels parameter. This fixes an unaligned access in GTK's "gtk:gdk / memorytexture" unit test on SPARC, which causes the test to fail. Fixes: 45ae4434 ("util: Use bitshift arithmetic to unpack pixels.") Part-of: <mesa/mesa!23482> (cherry picked from commit 19092576)
-
This reverts commit 8f159a85. This commit is correct but it exposes an existing bug: DISCARD_RANGE doesn't work well with shared buffers. So for now revert this commit as it's causing hangs on some APUs (see drm/amd#2447) and flickering in Metro Last Light Redux. Closes: mesa/mesa#9108 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!23492> (cherry picked from commit 96cf4531)
-
So the shuffleup tests did a shuffle up with const 5, we'd use invocation id (0..8) shuffle it down by 5, get (-5..3), then call llvmshufflevector with that which is totally illegal. There might be a nicer way to fix this, but I can't see it straight away, just bail on the fast path. Fixes: dEQP-VK.subgroups.shuffle.compute.subgroupshuffleup* Cc: mesa-stable Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!23484> (cherry picked from commit c20df7e2)
-
gallium has no mechanism for setting an offset to the index buffer, so this requires a new buffer to be created+bound dynamically at the specified offset in order to read the correct data cc: mesa-stable Acked-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!23394> (cherry picked from commit 32096095)
-
GPUs without native integers lower idiv in lower_int_to_float and there is no need to call nir_lower_idiv(..) for such GPUs. Fixes nir crashes I am seeing with gc2000_gles2 CI job. Fixes: f532202f ("etnaviv: use nir_lower_idiv(..) before opt loop") Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!23450> (cherry picked from commit add14d6c)
-
Fix defect reported by Coverity Scan. Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: return NULL;. Fixes: eadc64ab ("vulkan/wsi/display: do not dereference a NULL pointer") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <mesa/mesa!23415> (cherry picked from commit a62a22c9)
-
Eric Engestrom authored
-
- Jun 07, 2023
-
-
It make sense to enable CS stall so that it guarantees that the fast clear will start after tile cache flush has completed. cc: mesa-stable closes: mesa/mesa#9030 Fixes: e488773b ("anv: Fast clear depth/stencil surface in vkCmdClearAttachments" Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Nanley Chery <nanley.g.chery@intel.com> Part-of: <mesa/mesa!23063> (cherry picked from commit 688ee028)
-
Samplers and views can be re-created dynamically or long-lasting, resulting in the possibility of a tex cache collision. So instead of a simple counter, use idalloc. Fixes: a3c73987 ("freedreno/a6xx: Move rsc seqno out of tex cache key") Closes: mesa/mesa#9111 Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!23470> (cherry picked from commit 7b387997)
-
Instead of incrementing the seqno, just directly invalidate any existing tex cache entries when we update a sampler view. No reason not to just directly clear stale entries, and avoiding to re- assign the seqno will simplify the next patch. Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!23470> (cherry picked from commit 3f00f4ac)
-
Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!23470> (cherry picked from commit ca9dc7be)
-
Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!23470> (cherry picked from commit e527bd79)
-
Eric Engestrom authored
-
This fixes the remaining barrier issues. Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!23453> (cherry picked from commit bfed41d3)
-
I tried emitting less here but I'm just gonna hit it with the big seq_cst hammer. Fixes: dEQP-VK.memory_model.message_passing.* Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!23453> (cherry picked from commit 91e919f1)
-
The previous implementation was copying the data using the aligned length (size_dw). The aligned length could overflow the original buffer size. For instance, this issue is triggered with "piglit/bin/draw-batch -auto -fbo": ==5736==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fff139c77e8 at pc 0x7f25b350a9a0 bp 0x7fff139c6cb0 sp 0x7fff139c6460 READ of size 8 at 0x7fff139c77e8 thread T0 #0 0x7f25b350a99f in __interceptor_memcpy (/usr/lib64/libasan.so.6+0x3c99f) #1 0x7f25a8fcdf24 in radeon_emit_array ../src/gallium/include/winsys/radeon_winsys.h:760 #2 0x7f25a8fcdf24 in r600_draw_vbo ../src/gallium/drivers/r600/r600_state_common.c:2448 #3 0x7f25a8ae7ba1 in u_vbuf_draw_vbo ../src/gallium/auxiliary/util/u_vbuf.c:1791 #4 0x7f25a7bc18ca in _mesa_validated_drawrangeelements ../src/mesa/main/draw.c:1696 #5 0x7f25a7bc7e53 in _mesa_DrawElements ../src/mesa/main/draw.c:1824 Fixes: 0cf5d1f2 ("gallium: remove PIPE_CAP_INFO_START_WITH_USER_INDICES and fix all drivers") Signed-off-by: Patrick Lerda <patrick9876@free.fr> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!23436> (cherry picked from commit 340311da)
-
Fix defect reported by Coverity Scan. Double lock (LOCK) double_lock: mtx_lock locks qpool->queries_lock while it is locked. Fixes: a012b219 ("microsoft: Initial vulkan-on-12 driver") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Part-of: <mesa/mesa!23455> (cherry picked from commit ed759ad7)
-
It was accidentally used with geometry shaders. It might have caused hangs. Fixes: ccaaf8fe - amd: massively simplify how info->spi_cu_en is applied Reviewed-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!22833> (cherry picked from commit d98501f5)
-
This is supposed to check whether any channels of the element is used, but skipped_start is always 0 for packed formats. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Fixes: a46acdbc ("radv: Lower non-dynamic VS inputs in NIR.") Closes: mesa/mesa#9062 Part-of: <mesa/mesa!23370> (cherry picked from commit b9c1d74f)
-
Because strncpy may not append 0 if source string is longer than num(63) Fixes: b3b82fe8 ("virgl/vtest: add vtest driver") Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!21034> (cherry picked from commit b3feb485)
-
Otherwise the pipeline cache UUID isn't initialized as well, and the RADV meta shaders cache can be corrupted. Cc: mesa-stable Closes: mesa/mesa#9150 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!23439> (cherry picked from commit 8a22f5c3)
-
Cc: mesa-stable Part-of: <mesa/mesa!22865> (cherry picked from commit b44d4774)
-
This isn't needed for fragment shader. Cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!23066> (cherry picked from commit cbb86329)
-
instead of swizzling. Fixes a bunch of broken depth/stencil swizzling tests in CTS dEQP-VK.pipeline.monolithic.sampler.border_swizzle.s8_uint_stencil.argb.transparent_black.gather_0.no_swizzle_hint v2: kusma had nicer ideas. Fixes: 7826648e ("lavapipe: fix depth texturing swizzle") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!23428> (cherry picked from commit 48745d58)
-
Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable memobj going out of scope leaks the storage it points to. Fixes: a1571333 ("nvc0/nv50: support and enable EXT_memory_object*") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!23417> (cherry picked from commit bfb092b9)
-
This condition can occur in the wild (more specifically in RT shader call lowering), and it is handled correctly. Cc: mesa-stable Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <mesa/mesa!22536> (cherry picked from commit 87ac5d7d)
-
nir_repair_ssa_impl may insert phi nodes for any deref, but if the deref mode is uniform, validation fails. To fix this, rematerialize the derefs in the blocks they are used to avoid generating phi nodes for them. Cc: mesa-stable Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <mesa/mesa!22536> (cherry picked from commit ee2764d5)
-
this is otherwise broken for a sequence like draw_indirect -> draw_indirect_bc cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!23368> (cherry picked from commit b45594f4)
-
if a DS3 pipeline enabling dynamic samples is not bound when samples are set dynamically, then such a pipeline is later bound, min samples would have been incorrectly set to 1 instead, flag the update for later and do it just before draw cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!23368> (cherry picked from commit cc9e9580)
-
Fixes recent CTS dEQP-VK.api.image_clearing.*r64* since the Vulkan specification has been clarified. Only VK_FORMAT_R64_{UINT,SINT} are supported. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!23250> (cherry picked from commit 01bd012e)
-
In commit 284f0c9a I refactored the handling of the data source to just call a helper rather than special casing opcodes with 0 or 2 sources. Unfortunately, I also dropped the "else return 1", creating a fallthrough for all sources other than SURFACE_LOGICAL_SRC_ADDRESS and SURFACE_LOGICAL_SRC_DATA. The case below happened to return the correct value for all cases except SURFACE_LOGICAL_SRC_SURFACE, which has been returning 2 instead of 1 since that commit. Restore the else case. Thanks to Marcin Ślusarz for catching this. Fixes: 284f0c9a ("intel/compiler: Add an lsc_op_num_data_values() helper") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <mesa/mesa!23347> (cherry picked from commit 2d9a3bb0)
-
Eric Engestrom authored
-