- Dec 04, 2020
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Dec 03, 2020
-
-
Fixes a use-after-free of the state on the next iteration when it was probably just destroyed. Fixes: 6de01faa ("freedreno/a6xx: invalidate tex state cache entries on rebind") Part-of: <mesa/mesa!7695> (cherry picked from commit d3c67d7e)
-
Cc: mesa-stable Reviewed-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit daaf5f1d)
-
llvmpipe was reporting 32 max const buffers, while sizing its arrays to 16 according to gallivm's #define. Fixes: 1d35f772 ("gallivm,llvmpipe,draw: Support multiple constant buffers.") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit d90107a2)
-
Cc: mesa-stable Reviewed-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7695> (cherry picked from commit 634384e4)
-
Fixes: d1465b3a ("freedreno: use u_transfer_helper") Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!7695> (cherry picked from commit 9cc8fc7b)
-
computerator depends on ir3_parser.h, which is a generated file, but this dependency is not expressed in the build. Fixes: 1e8808a4 ("freedreno/ir3: refactor out helper to compile shader from asm") Signed-off-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!7870> (cherry picked from commit 9eee4054)
-
Fixes: fa97061a ("radv/winsys: Add binary syncobj ABI changes for timeline semaphores.") Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7866> (cherry picked from commit 6ec0953e) Conflicts: src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c
-
I think that reducing the CU mask to 1 disabled CU per SA broke the WGP mode on VanGogh, causing a hang. To be sure, disable it on all chips. Fixes: 9538b9a6 - radeonsi: add support for Sienna Cichlid Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7721> (cherry picked from commit 69c927de)
-
If you did: si_pm4_set_reg(pm4, reg, val0); si_pm4_cmd_add(pm4, val1); si_pm4 set_reg(pm4, reg + 4, val1); it wrote val0 to reg, val1 to reg + 4, and val2 to reg + 8. This fixes it by clearing last_opcode in si_pm4_cmd_add, so that si_pm4_set_reg doesn't try to combine set_reg calls across si_pm4_cmd_add. Fixes: da78d50b - radeonsi: make si_pm4_cmd_begin/end static and simplify all usages Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7721> (cherry picked from commit 0d4f1dcd)
-
Fixes: 1f213964 - radeonsi: add support for displayable DCC for multi-RB chips Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7721> (cherry picked from commit e64d5cc4)
-
Missing a copy of the pipe_sampler_state into the etna_sampler_state object lead to the texture_use_int_filter() to always see a max_anisotropy of 0, so the INT filter wasn't disabled when necessary. Also state emission should never change the state objects, as this might also lead to stale information being kept around the in the state object. Fixes: 89a41dae (etnaviv: do not use int filter when anisotropic filtering is used) Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!7638>
-
We were testing for -0.5 instead. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: 1210e0bd ("aco: create 16-bit input and output modifiers") Part-of: <mesa/mesa!7605>
-
The RDNA ISA doc says that omod doesn't preserve -0.0 in 6.2.2. LLVM appears to always disable omod in this situation, but clamp is unaffected. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: df645fa3 ("aco: implement VK_KHR_shader_float_controls") Part-of: <mesa/mesa!7605>
-
Check for clamp, SDWA or DPP. The optimization isn't possible with SDWA and DPP, so it would have been skipped anyway. Doing any of these with a clamp modifier present would be incorrect. No fossil-db changes. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!7045>
-
No fossil-db changes. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!7045>
-
fossil-db (Navi): Totals from 241 (0.18% of 137413) affected shaders: CodeSize: 856280 -> 856308 (+0.00%); split: -0.00%, +0.00% Instrs: 164220 -> 164514 (+0.18%); split: -0.00%, +0.18% Cycles: 1031916 -> 1033092 (+0.11%); split: -0.00%, +0.11% VMEM: 77855 -> 78514 (+0.85%); split: +0.85%, -0.01% SMEM: 20501 -> 20593 (+0.45%); split: +0.46%, -0.01% Copies: 9791 -> 9790 (-0.01%); split: -0.03%, +0.02% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!7045>
-
Dylan Baker authored
It's super annoying
-
Dylan Baker authored
-
- Dec 02, 2020
-
-
I think it only made the pass return false if there was a barrier Fixes: 2832bc97 - ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs() Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!7623> (cherry picked from commit 96593847)
-
Dylan Baker authored
So that code applies cleanly from master. This uses the same .clang-format settings that master does Equivalent to 82d2d73e, which has other changes.
-
- Dec 01, 2020
-
-
Screen is shared among contexts, other context might be already using vtbl while another initializes it again. ==45872== Possible data race during write of size 8 at 0x5DDAE78 by thread #549 ==45872== Locks held: 1, at address 0x5D1B6F8 ==45872== at 0x6D66D91: gen9_init_state (iris_state.c:7816) ==45872== by 0x6BA0A31: iris_create_context (iris_context.c:342) ==45872== by 0x621F390: st_api_create_context (st_manager.c:917) ==45872== by 0x620E6F9: dri_create_context (dri_context.c:163) ==45872== by 0x6A40DB1: driCreateContextAttribs (dri_util.c:480) ==45872== by 0x540B963: dri2_create_context (egl_dri2.c:1583) ==45872== by 0x53FB84E: eglCreateContext (eglapi.c:821) ==45872== ==45872== This conflicts with a previous read of size 8 by thread #544 ==45872== Locks held: 1, at address 0x5F6E0E0 ==45872== at 0x6CB779E: blorp_alloc_binding_table (iris_blorp.c:167) ==45872== by 0x6CAEF70: blorp_emit_surface_states (blorp_genX_exec.h:1540) ==45872== by 0x6CB67F9: blorp_exec (blorp_genX_exec.h:2016) ==45872== by 0x6CB7AFE: iris_blorp_exec (iris_blorp.c:307) ==45872== by 0x70F5916: try_blorp_blit (blorp_blit.c:2145) ==45872== by 0x70F5FCA: do_blorp_blit (blorp_blit.c:2273) ==45872== by 0x70F778F: blorp_copy (blorp_blit.c:2803) ==45872== by 0x6BB9EB6: iris_copy_region (iris_blit.c:725) v2: move as genX(init_screen_state) (Lionel) Signed-off-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Part-of: <!7544> (cherry picked from commit 460287ad) Conflicts: src/gallium/drivers/iris/iris_screen.c
-
Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Part-of: <mesa/mesa!7832> (cherry picked from commit aad0c7c6)
-
Fixes: 9545139c "mesa: skip FLUSH_VERTICES() if no samplers were changed" Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!6946> (cherry picked from commit 0a2117bc)
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: deaebc82 "nir: Add load_sampler_lod_paramaters_pan intrinsic" Part-of: <mesa/mesa!6587> (cherry picked from commit f6407b9b)
-
Fixes KHR-GL31.texture_size_promotion.functional Fixes: e4974852 Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!7792> (cherry picked from commit a569ffeb)
-
Quoting the spec : "When a pool is destroyed, all descriptor sets allocated from the pool are implicitly freed and become invalid. Descriptor sets allocated from a given pool do not need to be freed before destroying that descriptor pool." This implies we might leak nodes allocated in the vma object. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 0a6d2593 ("anv: Allocate descriptor buffers from the BO cache") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!7796> (cherry picked from commit 5d55ca9c)
-
Not every p_cbranch uses the SCC, but our optimizer thought so. Fixes: 8a32f57f Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!7677> (cherry picked from commit 8bd3fefb)
-
with a sequence like this: glClear(STENCIL) glBeginTransformFeedback() ... glEndTransformFeedback() glClear(STENCIL) The second clear sometimes may produce an unexpected result. Calling si_flush_gfx_cs() when doing ngg -> legacy transition seems to be a valid workaround (both for the synthetic reproducer and the real Blender bug). Using flush flags or events (BOTTOM_OF_PIPE_TS, RESET_TO_LOWEST_VGT) didn't help. Closes: mesa/mesa#2941 Cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!7750> (cherry picked from commit 0b3bd7c5)
-
It should only recurse if there's enough space to add the phi sources. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Fixes: 72ac3f60 ("nir: add nir_unsigned_upper_bound and nir_addition_might_overflow") Part-of: <mesa/mesa!7748> (cherry picked from commit 65fbae16)
-
You have to count the stats pre-culling here. Just like dc261cdd did for lines. VK-GL-CTS dEQP-VK.query_pool.statistics_query.clipping_primitives*point_list Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7705> (cherry picked from commit 2ed54033)
-
Until recently, we ended up using u_blitter here, because info->render_condition_enable was always true here. But when we recently fixed that overly broad check, this broke. So let's fix layered-resolves, by actually checking if the resource has layers respect them in that case, similar to what we do in blit_native. Fixes: 19906022 ("zink: more accurately track supported blits") Closes: mesa/mesa#3843 Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!7737> (cherry picked from commit 2ac396e2)
-
... even though I did review that commit. My bad :] Fixes: c56f0912 ("gitlab-ci: Move classic driver testing to a new meson-classic job") Signed-off-by: Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!5844> (cherry picked from commit 4da8323a)
-
I checked the Bspec for both Gen11 and Gen12, and it appears that rotate instructions cannot have source modifiers or saturate modifer. Saturate was already handled. Fixes: 1e92e838 ("intel/compiler: Emit ROR and ROL instruction") Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Part-of: <mesa/mesa!7650> (cherry picked from commit 6edc2a3d)
-
Dylan Baker authored
-
Currently dpb_size for VP9 profile0 and profile2 is same eventhough for profile2 dpb_size is multiplied by extra 3/2 and we are seeing VM_L2_PROTECTION_FAULT error and ring vcn_dec timeout because of less dpb_size for VP9_2. This patch will correct dpb_size for VP9_2 and fixes the issue. Signed-off-by: SureshGuttula <suresh.guttula@amd.com> Reviewed-by: Leo Liu <leo.liu@amd.com> Part-of: <mesa/mesa!7480> (cherry picked from commit 956228da)
-
This patch updates segmentation_abs_or_delta_update value based on VP9 bitstream header info. Netflix videos are showing corrupted output when codec is HW vp9 and segemantion enabled.This change will fix the corruption issue. Signed-off-by: SureshGuttula <suresh.guttula@amd.com> Reviewed-by: Leo Liu <leo.liu@amd.com> Part-of: <mesa/mesa!7290> (cherry picked from commit bef6007c)
-
- Nov 25, 2020
-
-
Issue: Encoding parameters not updated after changing FrameRate Root Cause: In rvce_begin_frame, need_rate_control was enabled if the target_bitrate, quant_i_frames, quant_p_frames, quant_b_frames or rate_ctrl_method changes. Due to this the rate_control() was not updating the encoder parameters with new framerate, peak_bits_per_picture_integer and avg_target_bits_per_picture Fix: Added the condition where we will check if there is a change in other parameters and enable need_rate_control. Eventually updating the encoder parameters with new framerate and bitrate. Signed-off-by: Krunal Patel <krunalkumarmukeshkumar.patel@amd.corp-partner.google.com> Reviewed-by: Leo Liu <leo.liu@amd.com> Part-of: <mesa/mesa!7696> (cherry picked from commit 35613c75)
-
- Nov 23, 2020
-
-
Dylan Baker authored
-