- Apr 21, 2022
-
-
Dylan Baker authored
-
this was an attempt to minimize the number of xfb barriers being emitted, but really xfb barriers need to always be emitted in order for xfb to work cc: mesa-stable fixes (nv): KHR-GL46.texture_view.reference_counting KHR-GL46.transform_feedback_overflow_query_ARB.multiple-streams-multiple-buffers-per-stream KHR-GL46.transform_feedback_overflow_query_ARB.multiple-streams-one-buffer-per-stream Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16065> (cherry picked from commit e5095984) Conflicts: src/gallium/drivers/zink/ci/zink-nv-fails.txt
-
a read barrier is needed for resume, yes, but the counter buffer is always being written to, so write access must always be set cc: mesa-stable fixes (nv): KHR-GL46.transform_feedback.draw_xfb_test Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16065> (cherry picked from commit fc5edf9b) Conflicts: src/gallium/drivers/zink/ci/zink-nv-fails.txt
-
this was well-documented, but ultimately wrong: the synchronization being used was for binding streamout buffers (not counter buffers) as vertex buffers, which was already handled just fine in the normal vertex buffer binding drawing from streamout ONLY uses the counter buffer, which means the counter buffer needs to be synchronized for reading cc: mesa-stable fixes (nv): KHR-GL46.transform_feedback.draw_xfb_feedbackk_test KHR-GL46.transform_feedback.draw_xfb_instanced_test KHR-GL46.transform_feedback.draw_xfb_stream_instanced_test Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16065> (cherry picked from commit a056cbc6) Conflicts: src/gallium/drivers/zink/ci/zink-nv-fails.txt
-
according to spec, this ensures that drivers will accurately return results relative to when the query was ended cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16049> (cherry picked from commit 373c8001)
-
Fixes: 9f3d5e99 ("compiler: Use util/bitset.h for system_values_read") Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!16063> (cherry picked from commit af718674)
-
Fixes: c8fe408f ("radv: Advertise ray primitive culling") Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!16028> (cherry picked from commit 324b2ae5)
-
The Command allocator and command list type must match, but we are forcing it to D3D12_COMMAND_LIST_TYPE_DIRECT in the reset path. Fixes: a012b219 ("microsoft: Initial vulkan-on-12 driver") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!16023> (cherry picked from commit 9fd02d49)
-
New "if" blocks may have been inserted. Fixes: bc4f8c07 ("intel/compiler: inject MUE initialization") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!15924> (cherry picked from commit 5dace41c)
-
New "if" blocks were inserted. Fixes: 303378e1 ("intel/rt: Add lowering for combined intersection/any-hit shaders") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15924> (cherry picked from commit 4fddef33)
-
lower_ubo_load_instr may insert "if" blocks. Fixes: 61749b5a ("anv: Add a pass for lowering A64 UBO access") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15924> (cherry picked from commit 5bd3ba5b)
-
There is no reason not to be able to get it. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 34a0ce58 ("anv: add a new execution mode for secondary command buffers") Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <mesa/mesa!15968> (cherry picked from commit 184084e2)
-
VkObjectType and VkDebugReportObjectTypeEXT has the same enum-values. Why the Vulkan WG thought this was a good idea, beats me. But it's what we have to live with now. Anyway, instead of having a statement that implicitly casts two different values from the former to the latter, let's fully relsove the type as the former, and cast the value when using it instead. Fixes: 41318a58 ("vulkan: Use vk_object_base::type for debug_report") Acked-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!15547> (cherry picked from commit b27a2ba4)
-
the dt might have been killed, so just assert that it's a display target fixes #6317 Fixes: 8ade5588 ("zink: add kopper api") Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!16017> (cherry picked from commit 3d97367a)
-
Fixes: 8ade5588 ("zink: add kopper api") Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!16017> (cherry picked from commit 9ecdc2e9)
-
these are all allowed with the ext cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15978> (cherry picked from commit 8806f444)
-
cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15978> (cherry picked from commit cd9424d9)
-
the pipe cap is used for gating wideline support, so this will always be 1.0 when not supported furthermore, the previous code wasn't accurately checking line width for tess shaders, breaking tests cc: mesa-stable fixes (nv): KHR-GL46.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_PatchVerticesIn Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15960> (cherry picked from commit d8b66fcb)
-
this is triggered by u_blitter when doing src==dst blits Fixes: 7781a752 ("zink: add a renderpass flag for mixed zs layout") affects: GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality* Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15960> (cherry picked from commit 9409756e)
-
if a rendertarget-specified image can't be a rendertarget or a blit dst then it can't be used for the designated functionality and must be rejected cc: mesa-stable fixes hangs on various nv driver versions: dEQP-GLES2.functional.texture.mipmap.2d.generate.rgba5551_fastest Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15960> (cherry picked from commit 37ac8647)
-
this is illegal, and we'll just have to eat some piglit fails until indirects are handled Fixes: f7ade1f1 ("zink: simplify shader i/o assignment") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15976> (cherry picked from commit 12cf9a15) Conflicts: src/gallium/drivers/zink/ci/zink-lvp-fails.txt
-
If we change the sate without flushing the bitmap cache, the cache might be rendered with the new scissor, which excludes some parts that should've been rendered with the old state, and vice versa. Cc: mesa-stable Closes: mesa/mesa#6233 Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!15881> (cherry picked from commit dd7278aa)
-
Here we just make sure we match the interpolation type on both sides of the shader interface. Drivers like d3d12 are expecting this. Fixes: 9401990e ("nir/linker: set varying from uniform as flat") Reviewed-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!16003> (cherry picked from commit 4b4bb46a)
-
This is used to determine the geometry shader info on GFX9, and it looks like it was broken for topologies that use adjacency. This is also used to remove PSIZ from shaders that don't need it. Found by inspection. fossils-db (Polaris10): Totals from 140 (0.10% of 135960) affected shaders: SGPRs: 10448 -> 9696 (-7.20%) VGPRs: 4376 -> 4264 (-2.56%) CodeSize: 164316 -> 161028 (-2.00%) Instrs: 26449 -> 25767 (-2.58%) Latency: 184448 -> 180468 (-2.16%) InvThroughput: 80772 -> 79092 (-2.08%) VClause: 337 -> 328 (-2.67%); split: -2.97%, +0.30% SClause: 859 -> 813 (-5.36%); split: -5.70%, +0.35% Copies: 1027 -> 790 (-23.08%) PreSGPRs: 2751 -> 2331 (-15.27%) PreVGPRs: 3887 -> 3836 (-1.31%) Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!15948> (cherry picked from commit ed7d8315)
-
We're missing a programming restriction. Hopefully fixing dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_1.* on Gfx9atoms Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Closes: mesa/mesa#6216 Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>.> Tested-by: Mark Janes <markjanes@swizzler.org> Part-of: <mesa/mesa!15596> (cherry picked from commit b07c215c)
-
The error was caught by the new nir_validation code. Fixes: 73ef225f nir: validate write_mask for all intrinsics that have it Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!15994> (cherry picked from commit ef75752e)
-
When we put NIR in the compiler stack for r300, indirect addressing broke for gallium nine. DX's array indirects round the float value, so the DX shader gets mapped to a TGSI "ARR ADDR[0] src.x" instruction. Translating that to NIR maps to r0[f2i32(fround(src.x))]. While we might hope that in translation back using nir-to-tgsi after optimization we would recognize the construct and emit ARR again, that's going to be error prone (think "what if src.x is in a NIR register?") so we need a fallback plan. r300 will be able to handle this lowering, so get it in place first to fix the regression. Fixes: #6297 Fixes: 7d2ea9b0 ("r300: Request NIR shaders from mesa/st and use NIR-to-TGSI.") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!15870> (cherry picked from commit 6947016b)
-
The line stride uses the number of bytes in the entire block, so both the width and height need to be reduced for compressed textures so that the surface stride is calculated correctly. Fixes: 051d62cf ("panfrost: Add a pan_image_layout_init() helper") Closes: mesa/mesa#6286 Part-of: <mesa/mesa!15989> (cherry picked from commit f2670002)
-
fixes: d760a915 Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!15840> (cherry picked from commit 4c1cb629)
-
Otherwise constant-folding will fold it to 0/1 instead of 0/~0. Fixes: 330e2815 ("nir: add 32-bit bool of fisfinite") Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!15984> (cherry picked from commit 5c9e4d40)
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Fixes: 61ac5acc ("radv,ac/nir: lower global access to _amd global access intrinsics") Closes: mesa/mesa#6321 Part-of: <mesa/mesa!15951> (cherry picked from commit 8fe8c5df)
-
the shaders will never see these, so set the expected value for 2D cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15895> (cherry picked from commit 2058ae7b)
-
queries still need the sampler_dim changed Fixes: 682e14d3 ("nir: lower_tex: Don't normalize coordinates for TXF with RECT") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!15895> (cherry picked from commit 5b0634d7)
-
This reverts commit 8506c2b7. Network admins say the fixed things, and we see the runners phoning home again. Part-of: <mesa/mesa!15936> (cherry picked from commit eb783783)
-
Dylan Baker authored
-
- Apr 14, 2022
-
-
Dylan Baker authored
-
- Apr 13, 2022
-
-
fossil-db (Sienna Cichlid): Totals from 376 (0.23% of 162293) affected shaders: MaxWaves: 9620 -> 9596 (-0.25%); split: +0.08%, -0.33% Instrs: 207533 -> 203901 (-1.75%); split: -1.76%, +0.01% CodeSize: 1130904 -> 1106420 (-2.16%); split: -2.17%, +0.01% VGPRs: 14016 -> 14120 (+0.74%); split: -0.34%, +1.08% Latency: 2143281 -> 2132212 (-0.52%); split: -0.56%, +0.05% InvThroughput: 389116 -> 387990 (-0.29%); split: -0.34%, +0.05% VClause: 4483 -> 4485 (+0.04%); split: -0.11%, +0.16% SClause: 5780 -> 5778 (-0.03%); split: -0.17%, +0.14% Copies: 15319 -> 15331 (+0.08%); split: -0.53%, +0.61% Branches: 5561 -> 5563 (+0.04%) PreSGPRs: 11776 -> 11775 (-0.01%) PreVGPRs: 11393 -> 11497 (+0.91%); split: -0.13%, +1.04% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!13778>
-