- Aug 04, 2021
-
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
- Aug 03, 2021
-
-
Also switch to array of strings to show high/low dwords. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: daba2894 ("intel/disasm: decode/describe more send messages") Acked-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!12183> (cherry picked from commit 97be8e42)
-
The `argument::size` is supposed to represent the size of a pointer on the host and not on the device (for which argument::target_size` exists). v3: Use `sizeof(buf)` instead of `marg.size`. (Francisco Jerez) Fixes: 7c6f1d3b ("clover/nir: extract constant buffer into its own section") Reviewed-by: Francisco Jerez <currojerez@riseup.net> Signed-off-by: Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!10256> (cherry picked from commit b4e5bf06)
-
This resolves clover returning `CL_INVALID_ARG_SIZE` whenever the OpenCL CTS called `clSetKernelArg()` for 3-component vectors. Fixes: 21473865 ("clover/spirv: Add functions for parsing arguments, linking programs, etc.") v2: Remove “api/clsetkernelarg/set kernel argument for cl_int3” from the expected fails for llvmpipe Reviewed-by: Karol Herbst <kherbst@redhat.com> Signed-off-by: Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!10256> (cherry picked from commit a6c26a6a)
-
SRV descriptors can require state-transitions before it's legal to set them on the command-list. We used to just set them right away, and get away with is, because the validator didn't verify this because we used to flag the parameters as volatile. Now that we don't, we trigger validation errors when setting a root parameter that needs a transition first. So let's split up the logic a bit, so we can prepare the tables, then do the transision, and finally set the tables. We do this for all tables instead of just the SRVs, just because it makes the logic a bit easier to follow. We leave root constants alone, because they will never require this, and doing them late would just compilcate things. Fixes: 12082905 ("d3d12: Sets all SRV descriptors as data-static") Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Bill Kristiansen <billkris@microsoft.com> Part-of: <mesa/mesa!12187> (cherry picked from commit cd79351f)
-
Most of the drivers don't set up the maximum value in the query info. So when later hud_pane_set_max_value() is invoked, we are using a rather "random" number. Turns out that in some 32bit cases, this random number is big enough that `leftmost_digit` is 0 because DIV_ROUND_UP() overflows, aborting with an assertion. Fixes: c91cf7d7 ("gallium: implement a heads-up display module") Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!12181> (cherry picked from commit 10541d1f)
-
The driver should accumulate the cache flush bits because if it uses CP DMA for clearing the last level, it won't flush. Found by inspection. Cc: 21.2 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!12170> (cherry picked from commit ad83c06a)
-
Fixes: d26bcc0f ("radv: always select the first active CU when profiling with SQTT") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!12167> (cherry picked from commit ebea075f)
-
This fixes a hang in the following piglit test when GCM moves a UBO load outside of the loop. tests/shaders/ssa/fs-if-def-else-break.shader_test The end NIR ends up looking like this: vec2 32 ssa_3 = intrinsic load_ubo (ssa_2, ssa_0) (0, 1073741824, 0, 0, 8) vec1 32 ssa_4 = mov ssa_3.x vec1 32 ssa_5 = inot ssa_3.y /* succs: block_1 */ loop { ... if ssa_5 { } } Fixes: 1edf67fc ("intel/fs: Generate if instructions with inverted conditions") Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!12064> (cherry picked from commit a654e39f)
-
Dylan Baker authored
-
- Aug 02, 2021
-
-
This is ported from 965 and fixes dEQP-GLES2.functional.fbo.render.recreate_colorbuffer.*rebind_tex2d_rgb* Fixes: f3630548 ("crocus: initial gallium driver for Intel gfx 4-7") Part-of: <mesa/mesa!12164> (cherry picked from commit 842b8c89)
-
This field should be a uint, further changes on top of previous ones in this area Fixes: 4d80ec8f ("intel/genxml: fix raster op fields on gen4/5") Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!12164> (cherry picked from commit de625ddd)
-
I don't think iris ever hits this path, but probably has the same bug if it did. Fixes texsubimage on gfx4 + gfx4.5 Fixes: 5bf6ec31 ("crocus/gen4: restrict memcpy mapping to gen5") Part-of: <mesa/mesa!12164> (cherry picked from commit c12444ab)
-
To properly init buffer memory requirement for AHB, memory type bits from dma_buf fd properties need to be masked. However, creating a test AHB at buffer creation is too costy. This patch caches the ahb backed buffer memory type bits at device creation time if the app is requesting AHB extension. Cc: 21.2 mesa-stable Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Chia-I Wu <olvaffe@gmail.com> Part-of: <mesa/mesa!12171> (cherry picked from commit e0896048)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 02709506 ("drm-shim: fix compile with glibc >= 2.33") Acked-by: Emma Anholt <emma@anholt.net> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!12129> (cherry picked from commit f86faee9)
-
Reviewed-by: Dylan Baker <dylan@pnwbakers.com> Cc: 21.2 mesa-stable Closes #5142 Part-of: <mesa/mesa!12139> (cherry picked from commit 80160a67)
-
Similar to the fix in 6bf8e960 ("pan/bi: Do helper termination analysis on clauses") Though apparently a "theoretical issue only", fixes artefacts in DarkPlaces with both D3D9 and GL renderers. Fixes: 9a7f0e26 ("pan/mdg: Use the helper invo analyze passes") Part-of: <mesa/mesa!12156> (cherry picked from commit a2b37e95)
-
Fixes: f1432fd3 ("zink: generate extension infrastructure using a python script") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!12137> (cherry picked from commit 86250c72)
-
Dylan Baker authored
-
- Jul 30, 2021
-
-
This worked around a symptom of the underlying issue worked around in the previous commit. This workaround is wrong in the sense of failing to correct some broken code sequences and needlessly rejecting some working code sequences. total tuples in shared programs: 123770 -> 123630 (-0.11%) tuples in affected programs: 9548 -> 9408 (-1.47%) helped: 133 HURT: 0 helped stats (abs) min: 1.0 max: 2.0 x̄: 1.05 x̃: 1 helped stats (rel) min: 0.42% max: 16.67% x̄: 4.07% x̃: 1.15% 95% mean confidence interval for tuples value: -1.09 -1.01 95% mean confidence interval for tuples %-change: -4.98% -3.17% Tuples are helped. total cycles in shared programs: 12114.83 -> 12114.50 (<.01%) cycles in affected programs: 34.08 -> 33.75 (-0.98%) helped: 9 HURT: 1 helped stats (abs) min: 0.04166599999999998 max: 0.04166700000000034 x̄: 0.04 x̃: 0 helped stats (rel) min: 0.72% max: 12.50% x̄: 2.99% x̃: 2.04% HURT stats (abs) min: 0.04166700000000034 max: 0.04166700000000034 x̄: 0.04 x̃: 0 HURT stats (rel) min: 0.62% max: 0.62% x̄: 0.62% x̃: 0.62% 95% mean confidence interval for cycles value: -0.05 -0.01 95% mean confidence interval for cycles %-change: -5.27% <.01% Inconclusive result (%-change mean confidence interval includes 0). total arith in shared programs: 4603.42 -> 4601.54 (-0.04%) arith in affected programs: 50.50 -> 48.62 (-3.71%) helped: 41 HURT: 1 helped stats (abs) min: 0.04166599999999998 max: 0.08333299999999999 x̄: 0.05 x̃: 0 helped stats (rel) min: 0.72% max: 33.33% x̄: 17.23% x̃: 13.33% HURT stats (abs) min: 0.04166700000000034 max: 0.04166700000000034 x̄: 0.04 x̃: 0 HURT stats (rel) min: 0.62% max: 0.62% x̄: 0.62% x̃: 0.62% 95% mean confidence interval for arith value: -0.05 -0.04 95% mean confidence interval for arith %-change: -20.93% -12.69% Arith are helped. total quadwords in shared programs: 110116 -> 110009 (-0.10%) quadwords in affected programs: 7829 -> 7722 (-1.37%) helped: 106 HURT: 0 helped stats (abs) min: 1.0 max: 2.0 x̄: 1.01 x̃: 1 helped stats (rel) min: 0.49% max: 7.14% x̄: 1.91% x̃: 1.35% 95% mean confidence interval for quadwords value: -1.03 -0.99 95% mean confidence interval for quadwords %-change: -2.23% -1.59% Quadwords are helped. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!12114> (cherry picked from commit be7d964f)
-
Hand typed. We could generate this from the XML to avoid the repititon but I think the cure is worse than the disease. This fixes instruction encoding faults seen in conformance tests. Only a single shader-db affected, and it was likely already broken... quadwords HURT: shaders/glmark/22-1.shader_test MESA_SHADER_FRAGMENT: 133 -> 135 (1.50%) Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!12114> (cherry picked from commit 2cdf9570) Conflicts: src/panfrost/bifrost/bi_schedule.c
-
The existing code handled the case where the new definition of the same field was larger than the old one. This commit adds a check to handle the reverse case: the new def is smaller than the old one (= so writing using the merged macro would affect the next fields). The affected fields are: * LGKM_CNT (in SQ_WAVE_IB_STS) * DONUT_SPLIT (in VGT_TESS_DISTRIBUTION) * HEAD_QUEUE (in GDS_GWS_RESOURCE) DONUT_SPLIT is the only one used by radeonsi/radv. Fixes: e6184b08 ("amd/registers: scripts for processing register descriptions in JSON") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12063> (cherry picked from commit 3914bd45)
-
Add 1 to the key index otherwise we hit the following assert in hash_table_insert: assert(!key_pointer_is_reserved(ht, key)); Cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12105> (cherry picked from commit 2ea88d7c)
-
Fixes crash in dEQP-GLES2.functional.uniform_api.random.79 Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12093> (cherry picked from commit c8783001)
-
Failure to create a buffer for scanout should not be fatal when importing a buffer. Buffers allocated from a render-only device may not be able to scanned out directly but can still be used for other rendering purposes (e.g. as a texture). Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Reviewed-by: Simon Ser <contact@emersion.fr> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Cc: mesa-stable Part-of: <mesa/mesa!12081> (cherry picked from commit 7bcb2236)
-
The previous logic was returning a handle valid for the render-only device if rsc->scanout was NULL. However the caller doesn't expect this: the caller will use the handle with the KMS device. Instead of returning a handle for the wrong device, fail if we don't have one. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!12074> (cherry picked from commit 47f000c1)
-
The previous logic was returning a handle valid for the render-only device if rsc->scanout was NULL. However the caller doesn't expect this: the caller will use the handle with the KMS device. Instead of returning a handle for the wrong device, fail if we don't have one. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Daniel Stone <daniels@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!12074> (cherry picked from commit 4c092947)
-
The previous logic was returning a handle valid for the render-only device if rsc->scanout was NULL. However the caller doesn't expect this: the caller will use the handle with the KMS device. Instead of returning a handle for the wrong device, fail if we don't have one. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Emma Anholt <emma@anholt.net> Cc: mesa-stable Part-of: <mesa/mesa!12074> (cherry picked from commit 465eb786)
-
The previous logic was returning a handle valid for the render-only device if rsc->scanout was NULL. However the caller doesn't expect this: the caller will use the handle with the KMS device. Instead of returning a handle for the wrong device, fail if we don't have one. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!12074> (cherry picked from commit 9da901d2)
-
When the driver hasn't been initialized via renderonly, screen->ro will be NULL. This fixes a crash when passing USE_SCANOUT to etnaviv when it's missing renderonly. Signed-off-by: Simon Ser <contact@emersion.fr> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!12074> (cherry picked from commit 3b3cd512)
-
A previous commit cleaned up the asserts but the last part of this assert looks like it got mixed up. It should have allowed param->rel for D3DSPR_INPUT if version is 3.0. Instead it does && on the enum value D3DSPR_ADDR which is of course always true, with the version check. The result is that we miss input validation with version 3.0. Spotted by a compile warning Fixes: 5974401a ("st/nine: Regroup param->rel tests") Reviewed-by: Axel Davy <davyaxel0@gmail.com> Part-of: <mesa/mesa!11880> (cherry picked from commit 71a5bcb8)
-
Dylan Baker authored
-
- Jul 29, 2021
-
-
Dylan Baker authored
-
If we have 2 command buffers back to back, one with a query pool, one without, we don't want to retain the second query pool value (NULL). Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 0a7224f3 ("anv: group as many command buffers into a single execbuf") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!12107> (cherry picked from commit b8e29e89)
-
These were fixed previously, but due to the CI not really running all tests any more, I didn't notice these fixes. Let's bring the expected results up to date. Fixes: 2e29857b ("llvmpipe: only report supported shader-image formats") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!12077> (cherry picked from commit 0cfd1da8)
-
No need to build the simulator with NEON; and also v3dv3 simulator is not for VC4, so don't inherit v3dv3 requirement when building vc4 driver. Fixes: mesa/mesa#5126 Fixes: d198e26a ("broadcom/common: move v3d_tiling to common") Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!12078> (cherry picked from commit fe9d2d20)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!12112> (cherry picked from commit 7e3bad0f)
-
Dylan Baker authored
This is required (at least for me on x86) to get the tool to pass it's own test, otherwise it fails the build_id assertion. Fixes: 1462b003 ("freedreno/ir3: Add a unit test for our disassembler.") Acked-by: Rob Clark <robclark@freedesktop.org> Part-of: <mesa/mesa!12084> (cherry picked from commit 097cf395)
-