Skip to content
Snippets Groups Projects
  1. Apr 20, 2021
  2. Apr 19, 2021
    • Miguel París Díaz's avatar
      pad: clear probes holding mutex · fad60301
      Miguel París Díaz authored
      Protect clearing probes against concurrent modification which might happen
      due to dispose does NOT guarantee that the object is not used anymore, as
      it could be referenced again and so being continued used.
      So, as in the rest of places where probes hook list is used, on dispose
      it should be accessed holding the mutex "GST_OBJECT_LOCK (pad);" as
      GHookList is not thread-safe.
      
      Part-of: <gstreamer/gstreamer!798>
      fad60301
  3. Apr 16, 2021
    • Edward Hervey's avatar
      queue2: Refuse all serialized queries when posting buffering messages · 4eef67cc
      Edward Hervey authored and Edward Hervey's avatar Edward Hervey committed
      When posting buffering messages there are no safe places or timing to avoid
      deadlocks.
      
      Previously the code was trying to be "smart" by only forwarding serialized
      queries if the queue was empty ... but that could happen when queue2 hadn't yet
      posted a 100% buffering message. Meaning the pipeline might be paused and
      pushing a serialized query downstream might never complete.
      
      Therefore let's completely disable forwarding of serialized queries when
      `queue2` is used as a buffering element (meaning `ALLOCATION` and `DRAIN`
      queries).
      
      Part-of: <!796>
      4eef67cc
  4. Apr 12, 2021
  5. Apr 10, 2021
  6. Apr 08, 2021
  7. Apr 07, 2021
  8. Apr 06, 2021
  9. Apr 02, 2021
  10. Mar 31, 2021
  11. Mar 26, 2021
  12. Mar 24, 2021
  13. Mar 19, 2021
  14. Mar 18, 2021
  15. Mar 17, 2021
  16. Mar 11, 2021
  17. Mar 08, 2021
    • Stéphane Cerveau's avatar
      element: remove useless ret test · 0da17213
      Stéphane Cerveau authored
      The ret test is unrelevant and confusing.
      We dont want the code to fail and the register
      to succeed by example.
      In the case of a conditional element_init,
      the element should be defined with
      GST_ELEMENT_REGISTER_DEFINE_CUSTOM instead
      of GST_ELEMENT_REGISTER_DEFINE_WITH_CODE.
      
      Part-of: <!768>
      0da17213
  18. Mar 03, 2021
    • Stéphane Cerveau's avatar
      bash-completion: various bash fixes · d093b289
      Stéphane Cerveau authored
      -d tests the folder which is existing but with .in file, so I prefered
      the -f to test if the gst file was available which is not the case, so
      it fallbacks on the pkg-config
      
      Part-of: <!766>
      d093b289
  19. Feb 26, 2021
  20. Feb 24, 2021
  21. Feb 17, 2021
  22. Feb 16, 2021
  23. Feb 15, 2021
    • Mathieu Duponchelle's avatar
      docs: standardize GstContext, GstControlBinding documentation · 45d11f65
      Mathieu Duponchelle authored
      * Document virtual methods in standalone comments, in order to properly
        annotate them
      
      * Don't repeat what annotations are stating with respect to ownership
        transfer, nullability
      
      * Mark GstControlBinding ABI field as private
      
      * Misc cleanup / typo fixes / addition of links
      
      Part-of: <!758>
      45d11f65
    • Mathieu Duponchelle's avatar
      docs: standardize GstClock documentation · d5ae9f29
      Mathieu Duponchelle authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      * Don't mention explicitly that API is MT safe, this implies that
        other API is not. GStreamer API is assumed to be MT safe, thread
        safety should only be explicitly mentioned when API is *not* MT safe
      
      * Don't repeat what annotations are stating with respect to ownership
        transfer, nullability
      
      * Document virtual methods in standalone comments, so that parameters
        can be documented. This is not critical here, as parameters do not
        need annotations / specific documentation, but serves as an up to
        date example
      
      * Document enumeration members in standalone comments, so that their
        Since tag is accounted for by gobject-introspection
      
      * Misc cleanup / typo fixes / addition of links
      
      Part-of: <!756>
      d5ae9f29
    • Stéphane Cerveau's avatar
      features: remove extra G_BEGIN_DECLS/G_END_DECLS · 3952e19c
      Stéphane Cerveau authored
      _GST_ELEMENT_REGISTER_DEFINE_BEGIN
      _GST_ELEMENT_REGISTER_DEFINE_END was introducing
      an extra extern "C" in case of c++ build.
      
      Add missing ";" in GST_ELEMENT_REGISTER_DECLARE
      
      Part-of: <!757>
      3952e19c
  24. Feb 11, 2021
    • Mathieu Duponchelle's avatar
      docs: standardize GstCapsFeatures, GstChildProxy documentation · c53ea138
      Mathieu Duponchelle authored
      * Don't mention explicitly that API is MT safe, this implies that
        other API is not. GStreamer API is assumed to be MT safe, thread
        safety should only be explicitly mentioned when API is *not* MT safe
      
      * Document virtual methods in standalone comments, in order to properly
        annotate them
      
      * Don't repeat what annotations are stating with respect to ownership
        transfer, nullability
      
      * Misc cleanup / typo fixes / addition of links
      
      Part-of: <!755>
      c53ea138
  25. Feb 10, 2021
    • Mathieu Duponchelle's avatar
      docs: standardize GstCaps documentation · 3f5042d7
      Mathieu Duponchelle authored
      * Don't repeat what annotations are stating with respect to ownership
        transfer, nullability
      
      * Reword the warnings for caps nestability in light of the 1.20
        improvements
      
      * Misc cleanup / typo fixes / addition of links
      
      Part-of: <!754>
      3f5042d7
    • Jan Schmidt's avatar
      tests: Add disjoint pad probe removal test. · 87fd35d5
      Jan Schmidt authored
      Add a test that removing a blocking probe on events when there
      is a different blocking probe on buffers releases the data flow.
      
      Part-of: <!749>
      87fd35d5
    • Jan Schmidt's avatar
      pad: Improve the documentation for GstPadProbeReturn. · da3886ac
      Jan Schmidt authored
      Explain that GST_PAD_PROBE_PASS will pass data even if there is
      another pad probe that says to block, and that GST_PAD_PROBE_REMOVE
      passes data and potentially unblocks the pad.
      
      Part-of: <!749>
      da3886ac
    • Jan Schmidt's avatar
      pad: Fix for multiple blocking probes interaction. · 170f6941
      Jan Schmidt authored
      Change the way the marshalled flag in the internal ProbeMarshall state
      is handled when iterating over pad probes so that it only counts
      probes that still exist and would be called when retrying.
      
      This improves the way that removing a blocking probe works when
      there are multiple blocking probes for different conditions (data vs
      events for example).
      
      As a side-effect, probes aren't put into the the called_probes array
      unless they actually match the current probe type and would be called,
      potentially reducing the number of hooks that get stored in the
      called_probes array, and the cost of the looping check on retries.
      
      Fixes #658
      
      Part-of: <!749>
      170f6941
  26. Feb 09, 2021
    • Mathieu Duponchelle's avatar
      docs: standardize GstBus documentation · 5df982fd
      Mathieu Duponchelle authored
      * Don't mention explicitly that API is MT safe, this implies that
        other API is not. GStreamer API is assumed to be MT safe, thread
        safety should only be explicitly mentioned when API is *not* MT safe
      
      * Don't repeat what annotations are stating with respect to ownership
        transfer, nullability
      
      * Document virtual methods and the class structure
      
      * Misc cleanup / typo fixes / addition of links
      
      Part-of: <!753>
      5df982fd
Loading