Skip to content
Snippets Groups Projects
Commit 8c25b0f2 authored by Iago Toral's avatar Iago Toral Committed by Emil Velikov
Browse files

i965: Fix out-of-bounds accesses into pull_constant_loc array

The piglit test glsl-fs-uniform-array-loop-unroll.shader_test was designed
to do an out of bounds access into an uniform array to make sure that we
handle that situation gracefully inside the driver, however, as Ken describes
in bug 79202, Valgrind reports that this is leading to an out-of-bounds access
in fs_visitor::demote_pull_constants().

Before accessing the pull_constant_loc array we should make sure that
the uniform we are trying to access is valid.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79202


Reviewed-by: default avatarMatt Turner <mattst88@gmail.com>
(cherry picked from commit 6ac1bc90)
Nominated-by: default avatarMatt Turner <mattst88@gmail.com>
parent a91ee1e1
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment