Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
xserver
xserver
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 892
    • Issues 892
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 86
    • Merge Requests 86
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • xorg
  • xserverxserver
  • Merge Requests
  • !540

Merged
Opened Nov 06, 2020 by Olivier Fourdan@ofourdan🛠Maintainer

xwayland: Create an xwl window for toplevel only

  • Overview 12
  • Commits 1
  • Pipelines 4
  • Changes 1

The present support in Xwayland assumes the xwl_window is the same for all the child windows of the toplevel.

When mapping a new X11 window, ensure_surface_for_window() checks for an existing xwl_window by using xwl_window_get() which will just check for the registered xwl_window for the window.

That means that a client mapping a child window of an existing window with a xwl_window will get another different xwl_window.

One ill effect of this is that Present will fail to match the frame callback for that window, causing a 1 fps repaint of the window as with some wine apps (e.g. https://bugs.winehq.org/show_bug.cgi?id=47066).

Fix ensure_surface_for_window() by using xwl_window_get_from_window() which will walk the window tree, so that a child window won't get another xwl_window than its parent.

#1099 (closed)

Edited Nov 06, 2020 by Olivier Fourdan
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: xorg/xserver!540
Source branch: issue1099