Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 921
    • Issues 921
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 118
    • Merge requests 118
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !540

xwayland: Create an xwl window for toplevel only

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:issue1099 into master Nov 06, 2020
  • Overview 12
  • Commits 1
  • Pipelines 4
  • Changes 1

The present support in Xwayland assumes the xwl_window is the same for all the child windows of the toplevel.

When mapping a new X11 window, ensure_surface_for_window() checks for an existing xwl_window by using xwl_window_get() which will just check for the registered xwl_window for the window.

That means that a client mapping a child window of an existing window with a xwl_window will get another different xwl_window.

One ill effect of this is that Present will fail to match the frame callback for that window, causing a 1 fps repaint of the window as with some wine apps (e.g. https://bugs.winehq.org/show_bug.cgi?id=47066).

Fix ensure_surface_for_window() by using xwl_window_get_from_window() which will walk the window tree, so that a child window won't get another xwl_window than its parent.

#1099 (closed)

Edited Nov 06, 2020 by Olivier Fourdan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue1099