Signed-off-by: Matt Turner <mattst88@gmail.com>

Signed-off-by: Matt Turner <mattst88@gmail.com>

Signed-off-by: Matt Turner <mattst88@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Reverting to avoid an out-of-bounds access of the colors array.
These additional colors were used in t_tsrccoords.

This reverts commit cadf1d2f.

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Fixes: f0e123ad
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

v2: Call the build directory 'build/' to clarify that it's a
    directory, not a target (suggestion by Eric Engestrom)

Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Stone <daniels@collabora.com> (v1)
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> (v1)
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

The previous code was contorting itself to do the substitution in the
same source format as the xorg automake macros.  Now that automake is
gone, we can simplify it.

Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Meson allows the configure step to be run faster (.3 seconds compared to
autogen.sh's 3.9 seconds on my system) and a full rebuild (touch
rendercheck.h; make) to run faster (.05s instead of .07s).

Rendercheck is pretty much the best case scenario for autotools, with
limited configure-time autodetection, non-recursive make, and no
libtool, so it seems like an interesting test-case to start with for
meson conversion.

v2: Add missing check for err.h
v3: Add a linebreak after printing the version (by Peter),
    fix manpage variable substitution (anholt).

Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Peter Hutterer authored 8 years ago and Emma Anholt committed 8 years ago

And set the function attribute to printf-style

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Eric Anholt <eric@anholt.net>

Found when I accidentally built with !HAVE_ERR_H

Signed-off-by: Eric Anholt <eric@anholt.net>

Aaron Plattner authored 8 years ago and Emma Anholt committed 8 years ago

Some drivers don't support SHM pixmaps, but rendercheck doesn't care
and tries to use them anyway. This causes the test to abort:

 Beginning SHM blend test from a8
 X Error of failed request:  BadImplementation (server does not implement operation)
   Major opcode of failed request:  130 (MIT-SHM)
   Minor opcode of failed request:  5 (X_ShmCreatePixmap)
   Serial number of failed request:  805
   Current serial number in output stream:  811
 X Error of failed request:  BadDrawable (invalid Pixmap or Window parameter)
   Major opcode of failed request:  139 (RENDER)
   Minor opcode of failed request:  4 (RenderCreatePicture)
   Resource id in failed request:  0x3200215
   Serial number of failed request:  806
   Current serial number in output stream:  811

Fix this by skipping the shmblend tests if the extension is missing or
doesn't support pixmaps.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Eric Anholt <eric@anholt.net>

Emil Velikov authored 8 years ago and Peter Hutterer committed 8 years ago

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

We're using exec now, so shuffle it down.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

See xserver commit 4bf3eac5fe2: "All this does is make it so editing
configure.ac or Makefile.am doesn't rebuild the makefiles.  Which is just
stupid."

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

On a standard Xvfb configuration, this means a4, and both rgb orders of
each of a4r4g4b4 and x4r4g4b4.

Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Adam Jackson <ajax@redhat.com>

Without this, trying to test eg. just r5g6b5 would fail, because we'd
ignore anything we didn't whitelist.

Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Adam Jackson <ajax@redhat.com>

Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Adam Jackson <ajax@redhat.com>

The expected destination color needs to vary by op in the same way as
for the base ops. Takes us from 1170 tests passed of 1710 total to
1710/1710 on Xvfb.

Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Adam Jackson <ajax@redhat.com>

Emma Anholt authored 9 years ago and Adam Jackson committed 9 years ago

Signed-off-by: Eric Anholt <eric@anholt.net>

Emma Anholt authored 9 years ago and Adam Jackson committed 9 years ago

There's a giant pile of code in glamor for uploading SHM pixmaps to
temporary GL memory for accelerating a Composite operation, and most of
its code is about how you convert formats.  Add a test that runs through
all the formats, to give us some coverage.

Signed-off-by: Eric Anholt <eric@anholt.net>

Emma Anholt authored 9 years ago and Adam Jackson committed 9 years ago

Managing the group logic was really error-prone (forget to edit
success_mask when copy and pasting?  Forget to printf a description of
the group?).  Most new tests being written can be described as a single
call that does a couple subtests.

This doesn't convert all of the tests.  Some of the remaining ones use
"win" for presenting results (which we may want to just put in a
global?), and the rest use the pre-created pictures, which would need
some much bigger refactoring if we want to move their test logic into
their test files.

Signed-off-by: Eric Anholt <eric@anholt.net>

Emma Anholt authored 9 years ago and Adam Jackson committed 9 years ago

I'd like to move driving of tests out of tests.c and into t_*.c, and
part of that will be allowing tests to use the formats list.  While I'm
at it, save the name of the format in the array so it doesn't need to be
recomputed.

Signed-off-by: Eric Anholt <eric@anholt.net>

Emma Anholt authored 9 years ago and Adam Jackson committed 9 years ago

I have a hard time typing anything else at this point.

Signed-off-by: Eric Anholt <eric@anholt.net>

Signed-off-by: Dave Airlie <airlied@redhat.com>

This fixes a bunch of Dst operator, when the dst color
is r5g5b5.

Signed-off-by: Dave Airlie <airlied@redhat.com>

This makes rendercheck at least useful for regression testing,

18731 tests passed of 51681 total
to
49373 tests passed of 51681 total

Signed-off-by: Dave Airlie <airlied@redhat.com>

After changing the get/putimage code in glamor, we found a render
regression that was surprisingly not caught by rendercheck.

v2: Add a variant with using the GC to invert the bits that were put,
    which reproduces the problem on master.

I converted this from a standalone testcase Keith sent me to a
rendercheck test, with a reformat and a minor fixup to make sure we
actually found the PictFormats we wanted.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Keith Packard <keithp@keithp.com>

Trying to make all the callchain related to these const is too hard, and
it's not like marking things const helps either the developer or the
compiler.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Keith Packard <keithp@keithp.com>

They never find real bugs in my experience.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Keith Packard <keithp@keithp.com>

This simplifies the manual strcatting mess and avoids potential overflow
issues.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Keith Packard <keithp@keithp.com>

We only store string literals here.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Keith Packard <keithp@keithp.com>

Matt Craighead authored 11 years ago and Aaron Plattner committed 11 years ago

Removed redundant declarations.  Removed an unused variable.
Fixed the sign of some loop variables.

Signed-off-by: Matt Craighead <mcraighead@nvidia.com>
Signed-off-by: Robert Morell <rmorell@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>

Vikram Fugro authored 11 years ago and Aaron Plattner committed 11 years ago

Since pixman v28, the Src and other operators (in, Out, Clear)
clear the background when drawing trapezoids, fixing the
trapezoid drawing for such operators. Making the necessary change
in rendercheck for the color "expected" in the background.

Signed-off-by: Vikram Fugro <vfugro@nvidia.com>
Reviewed-by: Søren Sandmann <ssp@redhat.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>