Skip to content
Snippets Groups Projects
  1. Feb 25, 2023
  2. Feb 17, 2023
  3. Nov 27, 2022
  4. Nov 10, 2022
    • Peter Harris's avatar
      Fix font server reconnection timeout · 5ca90ec8
      Peter Harris authored and Alan Coopersmith's avatar Alan Coopersmith committed
      
      The great libxfont2 rewrite 135fb032 split
      fs_wakeup into fs_wakeup and fs_fd_handler. The fs_fd_handler side is
      called when there is new data on the socket. The fs_wakeup side is called
      on a timeout.
      
      If there's a connection timeout, the block handler will set the timeout
      to zero, expecting fs_wakeup to handle the timeout. Therefore, we need to
      call _fs_check_reconnect in fs_wakeup to handle the connection timeout.
      If we don't, the X server will go to 100% CPU (and the font server
      connection will not be retried).
      
      Signed-off-by: default avatarPeter Harris <pharris@opentext.com>
      5ca90ec8
  5. Nov 05, 2022
  6. Oct 06, 2022
  7. Aug 26, 2022
  8. Aug 11, 2022
  9. Jun 22, 2022
  10. Jun 21, 2022
  11. Jun 20, 2022
  12. Apr 06, 2022
  13. Aug 02, 2021
  14. Jul 14, 2021
    • Alexander Richardson's avatar
      Fix out-of-bounds read in FontFileMakeDir() · daff8876
      Alexander Richardson authored
      BuiltinReadDirectory() calls FontFileMakeDir ("", builtin_dir_count); and
      this causes the `dirName[dirlen - 1]` access to read before the start of
      the string. I found this while porting Xvnc to CHERI-RISC-V (which has
      bounds and permissions on all pointers).
      daff8876
  15. Jun 12, 2021
  16. Mar 02, 2021
    • Peter Harris's avatar
      Fix use after free when font server connection lost · 9529d235
      Peter Harris authored
      
      If there are multiple blocks waiting for the same font, only one of them
      will have ->freeFont set. The rest will be in a state of FS_DEPENDING.
      
      If the font server dies before the font finishes opening, the block with
      ->freeFont set will call ->unload_font, invalidating the pfont pointers
      in the remaining FS_DEPENDING blocks.
      
      Avoid a use after free (and potential crash) by passing conn to
      fs_cleanup_font instead of dereferencing pfont to find the conn.
      
      Signed-off-by: default avatarPeter Harris <pharris@opentext.com>
      9529d235
  17. Mar 06, 2020
    • Peter Harris's avatar
      Fix crash when font server connection lost · e7b2cae1
      Peter Harris authored
      
      Always initialize the return value of fs_new_block_rec. Even if the
      conn->blockState is FS_BROKEN_CONNECTION | FS_RECONNECTING, we must not
      return with an uninitialized blockrec on the block list. When the
      blockrec times out, _fs_clean_aborted_blockrec calls fs_cleanup_bfont,
      which will try to follow pointers in the blockrec (which has not been
      initialized).
      
      Signed-off-by: default avatarPeter Harris <pharris@opentext.com>
      e7b2cae1
  18. Oct 25, 2019
  19. Sep 16, 2019
  20. Sep 14, 2019
  21. Aug 17, 2019
  22. Aug 04, 2019
  23. Aug 03, 2019
    • Alan Coopersmith's avatar
      Add some unit testing utilities · c4ed2e06
      Alan Coopersmith authored
      
      The test/utils directory contains some standalone test programs for testing
      libXfont funtionality without needing a full X server session.  They could
      be used to generate automated unit testing in the future, but that work has
      not yet been done.
      
      [v2: updated original work from libXfont 1.5 to 2.0 API & makefiles]
      
      Signed-off-by: default avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      c4ed2e06
  24. May 14, 2019
  25. Mar 16, 2019
  26. Nov 20, 2018
  27. Mar 25, 2018
  28. Nov 25, 2017
Loading