Clears warning from clang 13.0.1:

TextPop.c:679:64: warning: arithmetic on a null pointer treated as a cast
 from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    XtSetArg(args[num_args], XtNradioData, (XPointer)XawsdLeft + R_OFFSET);
                                           ~~~~~~~~~~~~~~~~~~~ ^

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <!38>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Instead of calling XInternAtom once per atom, call XInternAtoms once
instead. This is both simpler code and should reduce network
traffic. Although the latter is probably not measurable.

This allows macOS to respect the linking order as on other platforms.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

When listing multiple parameters of the same type, the first one was
often run together with the type and not shown as a parameter name,
and the type name was not shown for the second one (since it had been
listed as a K&R style definition but was being displayed as an ANSI/ISO
style prototype).

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

My previous commit in July 2019

  build-fixes when _CONST_X_STRING is defined

modified the interface of XawListChange() to use "_Xconst char *"
to fix builds when the Xt symbol _CONST_X_STRING is defined (which
makes the String typedef "const").

While this fixed building Xaw, clients which use Xaw were impacted.
Changing that function to use String resolves both problems.

(report by Karl Berry).

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

XtConvertAndStore may update the XrmValue value, changing its size.
clang and gcc warn about undefined behavior in the case-statement
following the call (which uses the size), but do not explain what
the problem is.  Since this code is not intended to handle changes
of the size, simply reject that case.  That quiets the gcc warnings
and is actually all that is needed for correctness.  clang still
complains (neither knows what the call does), but can be quieted
by initializing the variable before calling the function.

The code happens to work without the fix as long as it is not
used to convert between resource types which would increase the
size.

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Thomas E. Dickey authored 1 year ago and Thomas E. Dickey committed 1 year ago

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Thomas E. Dickey authored 1 year ago and Thomas E. Dickey committed 1 year ago

Branden Robinson says macros have to go after ".TH"; the existing macros did
not match the format used in groff, etc., and can be simply removed.  The
".TQ" macro is used only without a parameter, causing an extra space to be
emitted (and fixed that by dropping the parameter).

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Thomas E. Dickey authored 1 year ago and Thomas E. Dickey committed 1 year ago

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>