Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • libX11 libX11
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • lib
  • libX11libX11
  • Merge requests
  • !96

Merged
Created Jan 14, 2022 by Benno Schulenberg@bennoDeveloper

XKBMAlloc: use the correct first-key variable when extending a key range

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

When extending the range of changed virtual-modifier keys, one should pass the two variables relevant to that range.

These two mistakes were found by grepping for 'modmap_key' and then looking for asymmetries between the handling of the plain modmap thing and the virtual modmap thing. Inspired by issue #76 (closed).

(I suspect these mistakes were at the base of some intractable bugs reported against xkeyboard-config where virtual modifiers refused to work and had to be worked around by making other changes too.)

Signed-off-by: Benno Schulenberg bensberg@telfort.nl

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: vmodmap-range