Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • libX11 libX11
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 69
    • Issues 69
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • lib
  • libX11libX11
  • Issues
  • #76
Closed
Open
Created Jul 16, 2015 by Bugzilla Migration User@bugzilla-migration

libX11 missing very old fixes

Submitted by Ulrich Sibiller

Assigned to Xorg Project Team

Link to original bug (#91368)

Description

Created attachment 117184 off-by-one fixes ported to xorg git

I stumbled across an off-by-one fix for XKBMAlloc.c in NoMachine's NX code (http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=15cee47a496ef891923949ade073cf4ffabb9c73#patch3).

It turned out that this bug (along with some others) had been fixed in 2005 in the xfree86 code by Michal Maruška (see http://cgit.freedesktop.org/~libv/xfree86/commit/lib/X11?id=23202557b77fd2edd167ae00103dcd81782401d5)

(more Details here: https://www.mail-archive.com/devel@xfree86.org/msg07272.html)

These fixes never made their way to xorg, it seems.

At least the off-by-one fix should be included. I have attached a patch for this.

Attachment 117184, "off-by-one fixes ported to xorg git":
0001-fix-off-by-one-bug-in-XKBMAlloc.c.patch

Version: git

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking