Commit d6d6cba9 impacts performance in video games (namely CS:GO and DOTA2)
While playing CS:GO today after updating my software, performance became really odd with weird freezes/stutters every half a second to second. I noticed this issue on the Valve CS:GO GitHub issues page here, with the same issue referenced here, and decided to bisect libx11 myself and figure out the cause to save you guys some time. I cannot be 100% certain that reverting this issue is a good thing, as this does appear to fix a bug according to the commit message, but introduces a regression either way. I am hoping this can be remedied soon, I'll paste my bisect log below.
Thanks,
Amaan Qureshi
git bisect start
# status: waiting for both good and bad commits
# bad: [48487c4b9028e9eec5371742f51e1d64c2e17296] libX11 1.8.3
git bisect bad 48487c4b9028e9eec5371742f51e1d64c2e17296
# status: waiting for good commit(s), bad commit known
# good: [3a30ada60c5217ada37b143b541c8e6f6284c7fa] libX11 1.8.1
git bisect good 3a30ada60c5217ada37b143b541c8e6f6284c7fa
# bad: [48487c4b9028e9eec5371742f51e1d64c2e17296] libX11 1.8.3
git bisect bad 48487c4b9028e9eec5371742f51e1d64c2e17296
# good: [701e9e9afb88bdc68c84a4611adc533400a3df36] Use same pthread-stubs as libxcb
git bisect good 701e9e9afb88bdc68c84a4611adc533400a3df36
# good: [1294bfa487bdecfd32621822922fec03203ee188] specs: document change in XIMPreeditCallbacks
git bisect good 1294bfa487bdecfd32621822922fec03203ee188
# good: [a9e845809bcaae22496bc8aa3ca252b410d5f39b] Fix 797755 Allow X*IfEvent() to reenter libX11
git bisect good a9e845809bcaae22496bc8aa3ca252b410d5f39b
# good: [7f7bcd7b6f569e9f70e3ddd134924f178e2596b1] nls: consecutive cs number in en_US.UTF-8/XLC_LOCALE
git bisect good 7f7bcd7b6f569e9f70e3ddd134924f178e2596b1
# bad: [d6d6cba90215d323567fef13d6565756c9956f60] Update XPutBackEvent() to support clients that put back unpadded events
git bisect bad d6d6cba90215d323567fef13d6565756c9956f60
# good: [496d9bfeedda89a2211ec665f9214c2693c022f4] ximcp: Address warning found by UBSan when growing an empty tree
git bisect good 496d9bfeedda89a2211ec665f9214c2693c022f4
# first bad commit: [d6d6cba90215d323567fef13d6565756c9956f60] Update XPutBackEvent() to support clients that put back unpadded events