Also updates the gitlab CI config to test both build types
and compare the generated output/installed files.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <!11>

Clears 5 clang warnings of the form:
Eyes.c:252:27: warning: implicit conversion loses integer precision:
 'Window' (aka 'unsigned long') to 'xcb_drawable_t' (aka 'unsigned int')
 [-Wshorten-64-to-32]
                          XtWindow(w),
                          ^~~~~~~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <!10>

Clears 16 clang warnings of the form:
Eyes.c:298:45: warning: unused parameter 'closure' [-Wunused-parameter]

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <!10>

No need to cast things to the exact type they're already defined as being.

Also fix up a bonus needless cast gcc didn't warn about (the argument
to repaint_window can use the already-converted variable we've been
using in the rest of the function).

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <!9>

From gcc 14.1:

Eyes.c: In function ‘EyesConfigure’:
Eyes.c:132:45: warning: ‘calloc’ sizes specified with ‘sizeof’ in the
 earlier argument and not in the later argument [-Wcalloc-transposed-args]
  132 |         EyeConfiguration *c = calloc(sizeof(EyeConfiguration), 1);
      |                                             ^~~~~~~~~~~~~~~~
Eyes.c:132:45: note: earlier argument should specify number of elements,
 later size of each element

Eyes.c: In function ‘Initialize’:
Eyes.c:409:36: warning: ‘calloc’ sizes specified with ‘sizeof’ in the
 earlier argument and not in the later argument [-Wcalloc-transposed-args]
  409 |     TPoint *pupils = calloc(sizeof(TPoint), config->count);
      |                                    ^~~~~~
Eyes.c:409:36: note: earlier argument should specify number of elements,
 later size of each element

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <!8>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

This removes the assumption that an xeyes instance displays just a pair
of eyes, and instead allows future developers to implement different
kinds of ocular layouts.

Currently, the ocular layout system only allows for specifying offsets,
but a future change might also make different parts of the eye geometry
configurable: size of different elements, padding, etc.

Signed-off-by: Serge Bazanski <q3k@q3k.org>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Processed before the display is opened so they work even if a
connection to the display can't be opened.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

The X(7) man page doesn't list any license information as this had claimed.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Found by using:
    codespell --builtin clear,rare,usage,informal,code,names

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Fixes gcc warning:
Eyes.c:54:15: warning: redundant redeclaration of ‘hypot’ [-Wredundant-decls]
 extern double hypot(double, double);
               ^~~~~

since it's already declared in <math.h>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Add (char *) casts to initializers in Xt structs.
Remove unused variables.

Signed-off-by: Keith Packard <keithp@keithp.com>

v2:
	We only need Xi version 2.0, not 2.2
Suggested-by: Peter Hutterer <peter.hutterer@who-t.net>

Signed-off-by: Keith Packard <keithp@keithp.com>

This makes updating the eyes nicely vblank synchronized.

v2:
	Ensure extensions exist before calling query_version

	These calls add calls to xcb_get_extension_data before calling
	query_version calls, as those calls will mark the connection
	with an error if made against an X server without the
	extension present.

Suggested-by: Uli Schlachter <psychon@znc.in>

v3:
	check the 'present' field in the return from
	xcb_get_extension_data; the xcb_get_extension_data call will
	always succeed (save for out of memory), the only way to tell
	if the extension is supported in the target X server is to
	test the 'present' field in the query extension reply value.

Signed-off-by: Keith Packard <keithp@keithp.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Mihail Konev authored 8 years ago and Peter Hutterer committed 8 years ago

Signed-off-by: Mihail Konev <k.mvc@ya.ru>

Emil Velikov authored 10 years ago and Peter Hutterer committed 8 years ago

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Syncs the invocation of configure with the one from the server.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

See http://people.gnome.org/~walters/docs/build-api.txt



Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Use services provided by XORG_MANPAGE_SECTIONS.
Use standard Makefile for man pages.

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

This silences an Automake warning.

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Regroup AC statements under the Autoconf initialization section.
Regroup AM sttaements under the Automake initialization section.
Add missing AC_CONFIG_SRCDIR

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.

Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
Enables use of platform appropriate version of sed.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Gaetan Nadon authored 14 years ago and Alan Coopersmith committed 14 years ago

Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.

ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz



Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Jesse Adkins authored 14 years ago and Alan Coopersmith committed 14 years ago

Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Compiler warning flags should be explicitly set in the makefile
rather than being merged with other packages compiler flags.

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>